Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/911566/?format=api
{ "id": 911566, "url": "http://patchwork.ozlabs.org/api/patches/911566/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180510125949.79823-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180510125949.79823-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-05-10T12:59:48", "name": "[next,S91,10/11] i40e: free the skb after clearing the bitlock", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a8b7f1e59bad930b6edbbab0653fd34389bb364", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180510125949.79823-10-alice.michael@intel.com/mbox/", "series": [ { "id": 43730, "url": "http://patchwork.ozlabs.org/api/series/43730/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=43730", "date": "2018-05-10T12:59:39", "name": "[next,S91,01/11] virtchnl: Whitespace and parenthesis cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/43730/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/911566/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/911566/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40hm6z6ddkz9s1p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 11 May 2018 07:08:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 88C552279B;\n\tThu, 10 May 2018 21:08:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oNdUfQdb4hoL; Thu, 10 May 2018 21:08:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1FEBE22757;\n\tThu, 10 May 2018 21:08:56 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C79361C1017\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 21:08:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C4C972274A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 21:08:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hTMtoS4JGATm for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 21:08:51 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5E8D422130\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 21:08:51 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 May 2018 14:08:50 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga001.fm.intel.com with ESMTP; 10 May 2018 14:08:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,386,1520924400\"; d=\"scan'208\";a=\"54159901\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 10 May 2018 05:59:48 -0700", "Message-Id": "<20180510125949.79823-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180510125949.79823-1-alice.michael@intel.com>", "References": "<20180510125949.79823-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S91 10/11] i40e: free the skb after\n\tclearing the bitlock", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nIn commit bbc4e7d273b5 (\"i40e: fix race condition with PTP_TX_IN_PROGRESS\nbits\") we modified the code which handles Tx timestamps so that we would\nclear the progress bit as soon as possible.\n\nA later commit 0bc0706b46cd (\"i40e: check for Tx timestamp timeouts during\nwatchdog\") introduced similar code for detecting and handling cleanup of\na blocked Tx timestamp. This code did not use the same pattern for cleaning\nup the skb.\n\nUpdate this code to wait to free the skb until after the bit lock is\nfree, by first setting the ptp_tx_skb to NULL and clearing the lock.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ptp.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\nindex 8f30cd5..4280018 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n@@ -321,6 +321,8 @@ void i40e_ptp_rx_hang(struct i40e_pf *pf)\n **/\n void i40e_ptp_tx_hang(struct i40e_pf *pf)\n {\n+\tstruct sk_buff *skb;\n+\n \tif (!(pf->flags & I40E_FLAG_PTP) || !pf->ptp_tx)\n \t\treturn;\n \n@@ -333,9 +335,12 @@ void i40e_ptp_tx_hang(struct i40e_pf *pf)\n \t * within a second it is reasonable to assume that we never will.\n \t */\n \tif (time_is_before_jiffies(pf->ptp_tx_start + HZ)) {\n-\t\tdev_kfree_skb_any(pf->ptp_tx_skb);\n+\t\tskb = pf->ptp_tx_skb;\n \t\tpf->ptp_tx_skb = NULL;\n \t\tclear_bit_unlock(__I40E_PTP_TX_IN_PROGRESS, pf->state);\n+\n+\t\t/* Free the skb after we clear the bitlock */\n+\t\tdev_kfree_skb_any(skb);\n \t\tpf->tx_hwtstamp_timeouts++;\n \t}\n }\n", "prefixes": [ "next", "S91", "10/11" ] }