Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/911303/?format=api
{ "id": 911303, "url": "http://patchwork.ozlabs.org/api/patches/911303/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180510072835.5549-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180510072835.5549-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2018-05-10T07:28:35", "name": "e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fe804d1775e1172d84e318b3885f608b84aa5d23", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180510072835.5549-1-bpoirier@suse.com/mbox/", "series": [ { "id": 43602, "url": "http://patchwork.ozlabs.org/api/series/43602/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=43602", "date": "2018-05-10T07:28:35", "name": "e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/43602/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/911303/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/911303/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=suse.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40hPxK3Jh2z9s3q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 May 2018 17:29:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2D7C28765E;\n\tThu, 10 May 2018 07:29:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q37_P9FBqQ36; Thu, 10 May 2018 07:29:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 093AC87650;\n\tThu, 10 May 2018 07:29:21 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4D98E1CEA12\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 07:29:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4821D89A8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 07:29:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v36GWa56OUoN for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 07:29:17 +0000 (UTC)", "from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 50D7F89A8A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 May 2018 07:29:17 +0000 (UTC)", "from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 28DACACB6;\n\tThu, 10 May 2018 07:29:14 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "by amavisd-new at test-mx.suse.de" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Thu, 10 May 2018 16:28:35 +0900", "Message-Id": "<20180510072835.5549-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.16.3", "In-Reply-To": "<02874ECE860811409154E81DA85FBB5882D918F3@ORSMSX115.amr.corp.intel.com>", "References": "<02874ECE860811409154E81DA85FBB5882D918F3@ORSMSX115.amr.corp.intel.com>", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Ignore TSYNCRXCTL when getting\n\tI219 clock attributes", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "ehabkost@redhat.com, netdev@vger.kernel.org, jayanth@goubiq.com,\n\tlinux-kernel@vger.kernel.org, Bart.VanAssche@wdc.com,\n\tpostmodern.mod3@gmail.com,\n\tAchim Mildenberger <admin@fph.physik.uni-karlsruhe.de>,\n\tintel-wired-lan@lists.osuosl.org, olouvignes@gmail.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "There have been multiple reports of crashes that look like\nkernel: RIP: 0010:[<ffffffff8110303f>] timecounter_read+0xf/0x50\n[...]\nkernel: Call Trace:\nkernel: [<ffffffffa0806b0f>] e1000e_phc_gettime+0x2f/0x60 [e1000e]\nkernel: [<ffffffffa0806c5d>] e1000e_systim_overflow_work+0x1d/0x80 [e1000e]\nkernel: [<ffffffff810992c5>] process_one_work+0x155/0x440\nkernel: [<ffffffff81099e16>] worker_thread+0x116/0x4b0\nkernel: [<ffffffff8109f422>] kthread+0xd2/0xf0\nkernel: [<ffffffff8163184f>] ret_from_fork+0x3f/0x70\n\nThese can be traced back to the fact that e1000e_systim_reset() skips the\ntimecounter_init() call if e1000e_get_base_timinca() returns -EINVAL, which\nleads to a null deref in timecounter_read().\n\nCommit 83129b37ef35 (\"e1000e: fix systim issues\", v4.2-rc1) reworked\ne1000e_get_base_timinca() in such a way that it can return -EINVAL for\ne1000_pch_spt if the SYSCFI bit is not set in TSYNCRXCTL.\n\nSome experimentation has shown that on I219 (e1000_pch_spt, \"MAC: 12\")\nadapters, the E1000_TSYNCRXCTL_SYSCFI flag is unstable; TSYNCRXCTL reads\nsometimes don't have the SYSCFI bit set. Retrying the read shortly after\nfinds the bit to be set. This was observed at boot (probe) but also link up\nand link down.\n\nMoreover, the phc (PTP Hardware Clock) seems to operate normally even after\nreads where SYSCFI=0. Therefore, remove this register read and\nunconditionally set the clock parameters.\n\nReported-by: Achim Mildenberger <admin@fph.physik.uni-karlsruhe.de>\nMessage-Id: <20180425065243.g5mqewg5irkwgwgv@f2>\nBugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1075876\nFixes: 83129b37ef35 (\"e1000e: fix systim issues\")\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex ec4a9759a6f2..3afb1f3b6f91 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3546,15 +3546,12 @@ s32 e1000e_get_base_timinca(struct e1000_adapter *adapter, u32 *timinca)\n \t\t}\n \t\tbreak;\n \tcase e1000_pch_spt:\n-\t\tif (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {\n-\t\t\t/* Stable 24MHz frequency */\n-\t\t\tincperiod = INCPERIOD_24MHZ;\n-\t\t\tincvalue = INCVALUE_24MHZ;\n-\t\t\tshift = INCVALUE_SHIFT_24MHZ;\n-\t\t\tadapter->cc.shift = shift;\n-\t\t\tbreak;\n-\t\t}\n-\t\treturn -EINVAL;\n+\t\t/* Stable 24MHz frequency */\n+\t\tincperiod = INCPERIOD_24MHZ;\n+\t\tincvalue = INCVALUE_24MHZ;\n+\t\tshift = INCVALUE_SHIFT_24MHZ;\n+\t\tadapter->cc.shift = shift;\n+\t\tbreak;\n \tcase e1000_pch_cnp:\n \t\tif (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {\n \t\t\t/* Stable 24MHz frequency */\n", "prefixes": [] }