Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/910863/?format=api
{ "id": 910863, "url": "http://patchwork.ozlabs.org/api/patches/910863/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180509135848.20530-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180509135848.20530-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-05-09T13:58:48", "name": "ixgbe: fix memory leak on ipsec allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f096734ac93514d3e7082fbf43e8573cc95de2b7", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180509135848.20530-1-colin.king@canonical.com/mbox/", "series": [ { "id": 43424, "url": "http://patchwork.ozlabs.org/api/series/43424/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=43424", "date": "2018-05-09T13:58:48", "name": "ixgbe: fix memory leak on ipsec allocation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/43424/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/910863/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/910863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40gydN16w3z9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 May 2018 23:59:03 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BF74F87543;\n\tWed, 9 May 2018 13:59:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KNGcI-aupY+R; Wed, 9 May 2018 13:59:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 09B8987391;\n\tWed, 9 May 2018 13:59:00 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 64DD01C01A6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 May 2018 13:58:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5FD7B87345\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 May 2018 13:58:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OY75v3EqwFsS for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 May 2018 13:58:56 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id A48AC86460\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 May 2018 13:58:56 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1fGPcG-0002xZ-Ou; Wed, 09 May 2018 13:58:48 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Wed, 9 May 2018 14:58:48 +0100", "Message-Id": "<20180509135848.20530-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.17.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: fix memory leak on ipsec allocation", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThe error clean up path kfree's adapter->ipsec and should be\ninstead kfree'ing ipsec. Fix this. Also, the err1 error exit path\ndoes not need to kfree ipsec because this failure path was for\nthe failed allocation of ipsec.\n\nDetected by CoverityScan, CID#146424 (\"Resource Leak\")\n\nFixes: 63a67fe229ea (\"ixgbe: add ipsec offload add and remove SA\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex 41af2b81e960..195c0b65eee2 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -919,8 +919,8 @@ void ixgbe_init_ipsec_offload(struct ixgbe_adapter *adapter)\n \tkfree(ipsec->ip_tbl);\n \tkfree(ipsec->rx_tbl);\n \tkfree(ipsec->tx_tbl);\n+\tkfree(ipsec);\n err1:\n-\tkfree(adapter->ipsec);\n \tnetdev_err(adapter->netdev, \"Unable to allocate memory for SA tables\");\n }\n \n", "prefixes": [] }