Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/910396/?format=api
{ "id": 910396, "url": "http://patchwork.ozlabs.org/api/patches/910396/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180508180957.6923-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180508180957.6923-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2018-05-08T18:09:57", "name": "[v2] fm10k: reduce duplicate fm10k_stat macro code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "49f968656a00ae99e1664283e904c8cede1ff3ee", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180508180957.6923-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 43254, "url": "http://patchwork.ozlabs.org/api/series/43254/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=43254", "date": "2018-05-08T18:09:57", "name": "[v2] fm10k: reduce duplicate fm10k_stat macro code", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/43254/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/910396/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/910396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40gSFZ0fwkz9s27\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 May 2018 04:10:09 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DF7A987335;\n\tTue, 8 May 2018 18:10:07 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fEDAVhHFMIS8; Tue, 8 May 2018 18:10:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 56A32872F7;\n\tTue, 8 May 2018 18:10:06 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 47B3E1C0197\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 May 2018 18:10:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4400A228A0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 May 2018 18:10:01 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id etYmlpINDSfx for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 May 2018 18:10:00 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E702B22869\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 May 2018 18:09:59 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 May 2018 11:09:59 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.177.161])\n\tby fmsmga007.fm.intel.com with ESMTP; 08 May 2018 11:09:59 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,379,1520924400\"; d=\"scan'208\";a=\"37804303\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 8 May 2018 11:09:57 -0700", "Message-Id": "<20180508180957.6923-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.17.0.536.g43f547f64b90", "Subject": "[Intel-wired-lan] [PATCH v2] fm10k: reduce duplicate fm10k_stat\n\tmacro code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Joe Perches <joe@perches.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Share some of the code for setting up fm10k_stat macros by implementing\nan FM10K_STAT_FIELDS macro which we can use when setting up the type\nspecific macros.\n\nChange-Id: Ifeedfafa4707cbeb4fac818ed6672eb1db268e1a\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nTitle: reduce duplicate fm10k_stat macro code\nChange-type: ImplementationChange\nReviewed-on: https://git-amr-1.devtools.intel.com/gerrit/198021\n---\n\nChanges in v2\n* use __stringify() macro in definition of FM10K_NETDEV_STAT\n\n .../net/ethernet/intel/fm10k/fm10k_ethtool.c | 30 ++++++++++---------\n 1 file changed, 16 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex eeac2b75a195..73fe7bec8c3d 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -11,12 +11,18 @@ struct fm10k_stats {\n \tint stat_offset;\n };\n \n-#define FM10K_NETDEV_STAT(_net_stat) { \\\n-\t.stat_string = #_net_stat, \\\n-\t.sizeof_stat = FIELD_SIZEOF(struct net_device_stats, _net_stat), \\\n-\t.stat_offset = offsetof(struct net_device_stats, _net_stat) \\\n+#define FM10K_STAT_FIELDS(_type, _name, _stat) { \\\n+\t.stat_string = _name, \\\n+\t.sizeof_stat = FIELD_SIZEOF(_type, _stat), \\\n+\t.stat_offset = offsetof(_type, _stat) \\\n }\n \n+/* netdevice statistics */\n+#define FM10K_NETDEV_STAT(_net_stat) \\\n+\tFM10K_STAT_FIELDS(struct net_device_stats, \\\n+\t\t\t __stringify(_net_stat), \\\n+\t\t\t _net_stat)\n+\n static const struct fm10k_stats fm10k_gstrings_net_stats[] = {\n \tFM10K_NETDEV_STAT(tx_packets),\n \tFM10K_NETDEV_STAT(tx_bytes),\n@@ -34,11 +40,9 @@ static const struct fm10k_stats fm10k_gstrings_net_stats[] = {\n \n #define FM10K_NETDEV_STATS_LEN\tARRAY_SIZE(fm10k_gstrings_net_stats)\n \n-#define FM10K_STAT(_name, _stat) { \\\n-\t.stat_string = _name, \\\n-\t.sizeof_stat = FIELD_SIZEOF(struct fm10k_intfc, _stat), \\\n-\t.stat_offset = offsetof(struct fm10k_intfc, _stat) \\\n-}\n+/* General interface statistics */\n+#define FM10K_STAT(_name, _stat) \\\n+\tFM10K_STAT_FIELDS(struct fm10k_intfc, _name, _stat)\n \n static const struct fm10k_stats fm10k_gstrings_global_stats[] = {\n \tFM10K_STAT(\"tx_restart_queue\", restart_queue),\n@@ -75,11 +79,9 @@ static const struct fm10k_stats fm10k_gstrings_pf_stats[] = {\n \tFM10K_STAT(\"nodesc_drop\", stats.nodesc_drop.count),\n };\n \n-#define FM10K_MBX_STAT(_name, _stat) { \\\n-\t.stat_string = _name, \\\n-\t.sizeof_stat = FIELD_SIZEOF(struct fm10k_mbx_info, _stat), \\\n-\t.stat_offset = offsetof(struct fm10k_mbx_info, _stat) \\\n-}\n+/* mailbox statistics */\n+#define FM10K_MBX_STAT(_name, _stat) \\\n+\tFM10K_STAT_FIELDS(struct fm10k_mbx_info, _name, _stat)\n \n static const struct fm10k_stats fm10k_gstrings_mbx_stats[] = {\n \tFM10K_MBX_STAT(\"mbx_tx_busy\", tx_busy),\n", "prefixes": [ "v2" ] }