Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/908221/?format=api
{ "id": 908221, "url": "http://patchwork.ozlabs.org/api/patches/908221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/152537762239.62474.691804492516629751.stgit@bhelgaas-glaptop.roam.corp.google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<152537762239.62474.691804492516629751.stgit@bhelgaas-glaptop.roam.corp.google.com>", "list_archive_url": null, "date": "2018-05-03T20:00:22", "name": "[v6,2/5] bnxt_en: Report PCIe link properties with pcie_print_link_status()", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "a0101bc597610aa4d38952fd88a7cb324d7d9000", "submitter": { "id": 67298, "url": "http://patchwork.ozlabs.org/api/people/67298/?format=api", "name": "Bjorn Helgaas", "email": "helgaas@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/152537762239.62474.691804492516629751.stgit@bhelgaas-glaptop.roam.corp.google.com/mbox/", "series": [ { "id": 42437, "url": "http://patchwork.ozlabs.org/api/series/42437/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=42437", "date": "2018-05-03T20:00:07", "name": "PCI: Improve PCIe link status reporting", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/42437/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/908221/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/908221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"Dh7IF3jm\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40cQxB5lPnz9s4r\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 4 May 2018 06:00:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 39A8025EC9;\n\tThu, 3 May 2018 20:00:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7opBlj8NZBKv; Thu, 3 May 2018 20:00:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 227AA25D64;\n\tThu, 3 May 2018 20:00:27 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6083D1CEF86\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5DEDA89D5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zvb7oWEG4LOu for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:24 +0000 (UTC)", "from mail.kernel.org (mail.kernel.org [198.145.29.99])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 3AAD389CD9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:24 +0000 (UTC)", "from localhost (unknown [69.71.5.252])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 9BC402176D;\n\tThu, 3 May 2018 20:00:23 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1525377624;\n\tbh=mS3UNwjQYLylw/r1t5R04sSRHZehsdhqAY5HZss6vrE=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=Dh7IF3jmwN6X+9QS2nLR8wcBwejiuVPdVq4plKTcq4bDNB3mzuT2USo4x3r/cYsUD\n\tdhhD92f3KkbXWOK4QZ0Zrl6wvkBoRuYgA2+tangndfompFy25vF7uR+flTXidzakUs\n\t3OC9DnQP1SrKCO1XCvwzLKVgLTz1dAWnuuMnfSOU=", "From": "Bjorn Helgaas <helgaas@kernel.org>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tGanesh Goudar <ganeshgr@chelsio.com>,\n\tMichael Chan <michael.chan@broadcom.com>, \n\tAriel Elior <ariel.elior@cavium.com>", "Date": "Thu, 03 May 2018 15:00:22 -0500", "Message-ID": "<152537762239.62474.691804492516629751.stgit@bhelgaas-glaptop.roam.corp.google.com>", "In-Reply-To": "<152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>", "References": "<152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>", "User-Agent": "StGit/0.18", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v6 2/5] bnxt_en: Report PCIe link\n\tproperties with pcie_print_link_status()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jakub Kicinski <kubakici@wp.pl>, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Tal Gilboa <talgi@mellanox.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\teverest-linux-l2@cavium.com, Tariq Toukan <tariqt@mellanox.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bjorn Helgaas <bhelgaas@google.com>\n\nPreviously the driver used pcie_get_minimum_link() to warn when the NIC\nis in a slot that can't supply as much bandwidth as the NIC could use.\n\npcie_get_minimum_link() can be misleading because it finds the slowest link\nand the narrowest link (which may be different links) without considering\nthe total bandwidth of each link. For a path with a 16 GT/s x1 link and a\n2.5 GT/s x16 link, it returns 2.5 GT/s x1, which corresponds to 250 MB/s of\nbandwidth, not the true available bandwidth of about 1969 MB/s for a\n16 GT/s x1 link.\n\nUse pcie_print_link_status() to report PCIe link speed and possible\nlimitations instead of implementing this in the driver itself. This finds\nthe slowest link in the path to the device by computing the total bandwidth\nof each link and compares that with the capabilities of the device.\n\nThe dmesg change is:\n\n - PCIe: Speed %s Width x%d\n + %u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n\nSigned-off-by: Bjorn Helgaas <bhelgaas@google.com>\n---\n drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 +------------------\n 1 file changed, 1 insertion(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c\nindex f83769d8047b..34fddb48fecc 100644\n--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c\n+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c\n@@ -8621,22 +8621,6 @@ static int bnxt_init_mac_addr(struct bnxt *bp)\n \treturn rc;\n }\n \n-static void bnxt_parse_log_pcie_link(struct bnxt *bp)\n-{\n-\tenum pcie_link_width width = PCIE_LNK_WIDTH_UNKNOWN;\n-\tenum pci_bus_speed speed = PCI_SPEED_UNKNOWN;\n-\n-\tif (pcie_get_minimum_link(pci_physfn(bp->pdev), &speed, &width) ||\n-\t speed == PCI_SPEED_UNKNOWN || width == PCIE_LNK_WIDTH_UNKNOWN)\n-\t\tnetdev_info(bp->dev, \"Failed to determine PCIe Link Info\\n\");\n-\telse\n-\t\tnetdev_info(bp->dev, \"PCIe: Speed %s Width x%d\\n\",\n-\t\t\t speed == PCIE_SPEED_2_5GT ? \"2.5GT/s\" :\n-\t\t\t speed == PCIE_SPEED_5_0GT ? \"5.0GT/s\" :\n-\t\t\t speed == PCIE_SPEED_8_0GT ? \"8.0GT/s\" :\n-\t\t\t \"Unknown\", width);\n-}\n-\n static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)\n {\n \tstatic int version_printed;\n@@ -8851,8 +8835,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tnetdev_info(dev, \"%s found at mem %lx, node addr %pM\\n\",\n \t\t board_info[ent->driver_data].name,\n \t\t (long)pci_resource_start(pdev, 0), dev->dev_addr);\n-\n-\tbnxt_parse_log_pcie_link(bp);\n+\tpcie_print_link_status(pdev);\n \n \treturn 0;\n \n", "prefixes": [ "v6", "2/5" ] }