Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/908220/?format=api
{ "id": 908220, "url": "http://patchwork.ozlabs.org/api/patches/908220/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/152537761536.62474.4071016337645118753.stgit@bhelgaas-glaptop.roam.corp.google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<152537761536.62474.4071016337645118753.stgit@bhelgaas-glaptop.roam.corp.google.com>", "list_archive_url": null, "date": "2018-05-03T20:00:15", "name": "[v6,1/5] bnx2x: Report PCIe link properties with pcie_print_link_status()", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "ab52b2c52816bdf34c2f018d3ffcd3889331b7ac", "submitter": { "id": 67298, "url": "http://patchwork.ozlabs.org/api/people/67298/?format=api", "name": "Bjorn Helgaas", "email": "helgaas@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/152537761536.62474.4071016337645118753.stgit@bhelgaas-glaptop.roam.corp.google.com/mbox/", "series": [ { "id": 42437, "url": "http://patchwork.ozlabs.org/api/series/42437/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=42437", "date": "2018-05-03T20:00:07", "name": "PCI: Improve PCIe link status reporting", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/42437/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/908220/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/908220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"D1lnOyzQ\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40cQx075ZHz9s2t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 4 May 2018 06:00:20 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8C9C488D06;\n\tThu, 3 May 2018 20:00:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mp0r6g4bnu5l; Thu, 3 May 2018 20:00:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CFCC188AB1;\n\tThu, 3 May 2018 20:00:18 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id EE81F1CEF86\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EB01988AB1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KfPcb7lTeIGQ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:17 +0000 (UTC)", "from mail.kernel.org (mail.kernel.org [198.145.29.99])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 64B7688AA6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 20:00:17 +0000 (UTC)", "from localhost (unknown [69.71.5.252])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id E867D21770;\n\tThu, 3 May 2018 20:00:16 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1525377617;\n\tbh=WC/VF6BmLNs8GcKZevzlmmda/jz4RLNRwgTWQwWVMRk=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=D1lnOyzQx8Zg0iblwtOClCqvWLKZrrSgTQUeO74Kj+w76xaednndOO922ssZNSxnG\n\tpL5Xxpc4YMQCWIRqXEbxCS6QKZVi5RaV/fxbnx09Xhe5Mvfs350MjU4ECdmip93BQl\n\txlSMhGwadwulvQrzon856oSsgn4yCKo5TTi6LVPo=", "From": "Bjorn Helgaas <helgaas@kernel.org>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tGanesh Goudar <ganeshgr@chelsio.com>,\n\tMichael Chan <michael.chan@broadcom.com>, \n\tAriel Elior <ariel.elior@cavium.com>", "Date": "Thu, 03 May 2018 15:00:15 -0500", "Message-ID": "<152537761536.62474.4071016337645118753.stgit@bhelgaas-glaptop.roam.corp.google.com>", "In-Reply-To": "<152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>", "References": "<152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>", "User-Agent": "StGit/0.18", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v6 1/5] bnx2x: Report PCIe link properties\n\twith pcie_print_link_status()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jakub Kicinski <kubakici@wp.pl>, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Tal Gilboa <talgi@mellanox.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\teverest-linux-l2@cavium.com, Tariq Toukan <tariqt@mellanox.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bjorn Helgaas <bhelgaas@google.com>\n\nPreviously the driver used pcie_get_minimum_link() to warn when the NIC\nis in a slot that can't supply as much bandwidth as the NIC could use.\n\npcie_get_minimum_link() can be misleading because it finds the slowest link\nand the narrowest link (which may be different links) without considering\nthe total bandwidth of each link. For a path with a 16 GT/s x1 link and a\n2.5 GT/s x16 link, it returns 2.5 GT/s x1, which corresponds to 250 MB/s of\nbandwidth, not the true available bandwidth of about 1969 MB/s for a\n16 GT/s x1 link.\n\nUse pcie_print_link_status() to report PCIe link speed and possible\nlimitations instead of implementing this in the driver itself. This finds\nthe slowest link in the path to the device by computing the total bandwidth\nof each link and compares that with the capabilities of the device.\n\nThe dmesg change is:\n\n - %s (%c%d) PCI-E x%d %s found at mem %lx, IRQ %d, node addr %pM\n + %s (%c%d) PCI-E found at mem %lx, IRQ %d, node addr %pM\n + %u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n\nSigned-off-by: Bjorn Helgaas <bhelgaas@google.com>\n---\n drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 23 ++++++----------------\n 1 file changed, 6 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c\nindex c766ae23bc74..5b1ed240bf18 100644\n--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c\n+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c\n@@ -13922,8 +13922,6 @@ static int bnx2x_init_one(struct pci_dev *pdev,\n {\n \tstruct net_device *dev = NULL;\n \tstruct bnx2x *bp;\n-\tenum pcie_link_width pcie_width;\n-\tenum pci_bus_speed pcie_speed;\n \tint rc, max_non_def_sbs;\n \tint rx_count, tx_count, rss_count, doorbell_size;\n \tint max_cos_est;\n@@ -14091,21 +14089,12 @@ static int bnx2x_init_one(struct pci_dev *pdev,\n \t\tdev_addr_add(bp->dev, bp->fip_mac, NETDEV_HW_ADDR_T_SAN);\n \t\trtnl_unlock();\n \t}\n-\tif (pcie_get_minimum_link(bp->pdev, &pcie_speed, &pcie_width) ||\n-\t pcie_speed == PCI_SPEED_UNKNOWN ||\n-\t pcie_width == PCIE_LNK_WIDTH_UNKNOWN)\n-\t\tBNX2X_DEV_INFO(\"Failed to determine PCI Express Bandwidth\\n\");\n-\telse\n-\t\tBNX2X_DEV_INFO(\n-\t\t \"%s (%c%d) PCI-E x%d %s found at mem %lx, IRQ %d, node addr %pM\\n\",\n-\t\t board_info[ent->driver_data].name,\n-\t\t (CHIP_REV(bp) >> 12) + 'A', (CHIP_METAL(bp) >> 4),\n-\t\t pcie_width,\n-\t\t pcie_speed == PCIE_SPEED_2_5GT ? \"2.5GHz\" :\n-\t\t pcie_speed == PCIE_SPEED_5_0GT ? \"5.0GHz\" :\n-\t\t pcie_speed == PCIE_SPEED_8_0GT ? \"8.0GHz\" :\n-\t\t \"Unknown\",\n-\t\t dev->base_addr, bp->pdev->irq, dev->dev_addr);\n+\tBNX2X_DEV_INFO(\n+\t \"%s (%c%d) PCI-E found at mem %lx, IRQ %d, node addr %pM\\n\",\n+\t board_info[ent->driver_data].name,\n+\t (CHIP_REV(bp) >> 12) + 'A', (CHIP_METAL(bp) >> 4),\n+\t dev->base_addr, bp->pdev->irq, dev->dev_addr);\n+\tpcie_print_link_status(bp->pdev);\n \n \tbnx2x_register_phc(bp);\n \n", "prefixes": [ "v6", "1/5" ] }