Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/908070/?format=api
{ "id": 908070, "url": "http://patchwork.ozlabs.org/api/patches/908070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180503035931.22439-2-pasha.tatashin@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180503035931.22439-2-pasha.tatashin@oracle.com>", "list_archive_url": null, "date": "2018-05-03T03:59:30", "name": "[1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "bb2034dd94bdd577db19a1c9dcd8395fd44ccf03", "submitter": { "id": 71010, "url": "http://patchwork.ozlabs.org/api/people/71010/?format=api", "name": "Pavel Tatashin", "email": "pasha.tatashin@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180503035931.22439-2-pasha.tatashin@oracle.com/mbox/", "series": [ { "id": 42367, "url": "http://patchwork.ozlabs.org/api/series/42367/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=42367", "date": "2018-05-03T03:59:29", "name": "multi-threading device shutdown", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/42367/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/908070/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/908070/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"VUQfDchS\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40cHyD0MVKz9s4t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 4 May 2018 00:45:56 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 861AE88C00;\n\tThu, 3 May 2018 14:45:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JClSDr9ald59; Thu, 3 May 2018 14:45:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9F8A988AB8;\n\tThu, 3 May 2018 14:45:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A256F1C07E1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 03:59:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9ED6188898\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 03:59:43 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TCyIw+pPJyLQ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 03:59:43 +0000 (UTC)", "from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E53E08868A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 3 May 2018 03:59:42 +0000 (UTC)", "from pps.filterd (userp2120.oracle.com [127.0.0.1])\n\tby userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw433pGVK026852; Thu, 3 May 2018 03:59:40 GMT", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp2120.oracle.com with ESMTP id 2hmhmfqq9t-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 03 May 2018 03:59:40 +0000", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w433xeSb019215\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 3 May 2018 03:59:40 GMT", "from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w433xdp2005228; \n\tThu, 3 May 2018 03:59:39 GMT", "from xakep.us.oracle.com (/10.154.188.87)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Wed, 02 May 2018 20:59:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : subject :\n\tdate : message-id : in-reply-to : references; s=corp-2017-10-26;\n\tbh=A7/dEoWk1iDkrlpuqltxj8FdRRRpYUXHRc+RH3CAjsk=;\n\tb=VUQfDchSN5vnyhxYkWuwfQtCW9T9MF72h+gjbh/xAvjawELy1+b7vx2+nJnSwzjnQY2E\n\tXQ4/HEEw/p54v/r/01BOyavg+FjBL54FF1MTE5OrffX+dSVl+0+SS49+jWkYu941GEu+\n\tzBPcrrwOvhpobDR26sYOo3gM606KtuYfHKBr12vfr2nvMhDSNtvG4c53c8huQLdBXSph\n\t7P0JcknmJG38OYiz+7Gad+OzjDEli1qENJoO/GUwsvvWIjD9yF3iSowigZT4G2U3OhA7\n\tNj5vroxp+WmRetHb4Ejvc5ckx3v1qL3XknMgcbUBr0/o8CPqJ6ZB9AyixT4VRjhhwT99\n\tPg== ", "From": "Pavel Tatashin <pasha.tatashin@oracle.com>", "To": "pasha.tatashin@oracle.com, steven.sistare@oracle.com,\n\tdaniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org,\n\tjeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org, gregkh@linuxfoundation.org", "Date": "Wed, 2 May 2018 23:59:30 -0400", "Message-Id": "<20180503035931.22439-2-pasha.tatashin@oracle.com>", "X-Mailer": "git-send-email 2.17.0", "In-Reply-To": "<20180503035931.22439-1-pasha.tatashin@oracle.com>", "References": "<20180503035931.22439-1-pasha.tatashin@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8881\n\tsignatures=668698", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=714\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1805030034", "X-Mailman-Approved-At": "Thu, 03 May 2018 14:45:49 +0000", "Subject": "[Intel-wired-lan] [PATCH 1/2] ixgbe: release lock for the duration\n\tof ixgbe_suspend_close()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration\nof lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards\nthis lock prevents scaling if device_shutdown() function is multi-threaded.\n\nIt is not necessary to hold this lock during ixgbe_close_suspend()\nas it is not held when ixgbe_close() is called also during shutdown but for\nkexec case.\n\nSigned-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex afadba99f7b8..e7875b58854b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6748,8 +6748,15 @@ static int __ixgbe_shutdown(struct pci_dev *pdev, bool *enable_wake)\n \trtnl_lock();\n \tnetif_device_detach(netdev);\n \n-\tif (netif_running(netdev))\n+\tif (netif_running(netdev)) {\n+\t\t/* Suspend takes a long time, device_shutdown may be\n+\t\t * parallelized this function, so drop lock for the\n+\t\t * duration of this call.\n+\t\t */\n+\t\trtnl_unlock();\n \t\tixgbe_close_suspend(adapter);\n+\t\trtnl_lock();\n+\t}\n \n \tixgbe_clear_interrupt_scheme(adapter);\n \trtnl_unlock();\n", "prefixes": [ "1/2" ] }