Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/902057/?format=api
{ "id": 902057, "url": "http://patchwork.ozlabs.org/api/patches/902057/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180420084140.8081-4-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180420084140.8081-4-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-04-20T08:41:36", "name": "[next,S90,4/8] i40evf: Fix turning TSO, GSO and GRO on after", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9771eb8576ff993e876bd522ce4c148a0ef1dd9d", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180420084140.8081-4-alice.michael@intel.com/mbox/", "series": [ { "id": 40130, "url": "http://patchwork.ozlabs.org/api/series/40130/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=40130", "date": "2018-04-20T08:41:38", "name": "[next,S90,1/8] i40e/i40evf: cleanup incorrect function doxygen comments", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/40130/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/902057/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/902057/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40SML53SSfz9s1t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 21 Apr 2018 02:50:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0F58C883DF;\n\tFri, 20 Apr 2018 16:50:36 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KjHEcYkrdGmY; Fri, 20 Apr 2018 16:50:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 80D4888350;\n\tFri, 20 Apr 2018 16:50:31 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7599F1CF121\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Apr 2018 16:50:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 72E8622609\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Apr 2018 16:50:26 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MhYsEVPmP+zA for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Apr 2018 16:50:23 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5CCE52EE8D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Apr 2018 16:50:23 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Apr 2018 09:50:22 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga008.fm.intel.com with ESMTP; 20 Apr 2018 09:50:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,302,1520924400\"; d=\"scan'208\";a=\"34086374\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 20 Apr 2018 01:41:36 -0700", "Message-Id": "<20180420084140.8081-4-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180420084140.8081-1-alice.michael@intel.com>", "References": "<20180420084140.8081-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S90 4/8] i40evf: Fix turning TSO,\n\tGSO and GRO on after", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "=?utf-8?b?UGF3ZcWCIEphYsWCb8WEc2tp?= <pawel.jablonski@intel.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paweł Jabłoński <pawel.jablonski@intel.com>\n\nThis patch fixes the problem where each MTU change turns TSO,\nGSO and GRO on from off state.\n\nNow when TSO, GSO or GRO is turned off, MTU change does not\nturn them on.\n\nSigned-off-by: Paweł Jabłoński <pawel.jablonski@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 28a8cc4..3f04a182 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -3357,6 +3357,24 @@ int i40evf_process_config(struct i40evf_adapter *adapter)\n \tif (vfres->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN)\n \t\tnetdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;\n \n+\t/* Do not turn on offloads when they are requested to be turned off.\n+\t * TSO needs minimum 576 bytes to work correctly.\n+\t */\n+\tif (netdev->wanted_features) {\n+\t\tif (!(netdev->wanted_features & NETIF_F_TSO) ||\n+\t\t netdev->mtu < 576)\n+\t\t\tnetdev->features &= ~NETIF_F_TSO;\n+\t\tif (!(netdev->wanted_features & NETIF_F_TSO6) ||\n+\t\t netdev->mtu < 576)\n+\t\t\tnetdev->features &= ~NETIF_F_TSO6;\n+\t\tif (!(netdev->wanted_features & NETIF_F_TSO_ECN))\n+\t\t\tnetdev->features &= ~NETIF_F_TSO_ECN;\n+\t\tif (!(netdev->wanted_features & NETIF_F_GRO))\n+\t\t\tnetdev->features &= ~NETIF_F_GRO;\n+\t\tif (!(netdev->wanted_features & NETIF_F_GSO))\n+\t\t\tnetdev->features &= ~NETIF_F_GSO;\n+\t}\n+\n \tadapter->vsi.id = adapter->vsi_res->vsi_id;\n \n \tadapter->vsi.back = adapter;\n", "prefixes": [ "next", "S90", "4/8" ] }