Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/902010/?format=api
{ "id": 902010, "url": "http://patchwork.ozlabs.org/api/patches/902010/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20180420155314.8920-5-stefan@agner.ch/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180420155314.8920-5-stefan@agner.ch>", "list_archive_url": null, "date": "2018-04-20T15:53:09", "name": "[U-Boot,v1,4/9] mtd: nand: mxs_nand: add use_minimum_ecc to struct", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e4f8fc3516fb02b259a04020f43d9e34503d9e0b", "submitter": { "id": 4137, "url": "http://patchwork.ozlabs.org/api/people/4137/?format=api", "name": "Stefan Agner", "email": "stefan@agner.ch" }, "delegate": { "id": 1693, "url": "http://patchwork.ozlabs.org/api/users/1693/?format=api", "username": "sbabic", "first_name": "Stefano", "last_name": "Babic", "email": "sbabic@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20180420155314.8920-5-stefan@agner.ch/mbox/", "series": [ { "id": 40110, "url": "http://patchwork.ozlabs.org/api/series/40110/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=40110", "date": "2018-04-20T15:53:05", "name": "mtd: nand: mxs_nand: add device tree support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/40110/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/902010/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/902010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=agner.ch", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=agner.ch header.i=@agner.ch header.b=\"QmpBw7Q9\";\n\tdkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 40SLBK0yzxz9s1p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 21 Apr 2018 01:58:49 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid CFD30C21E0D; Fri, 20 Apr 2018 15:56:03 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AC4F3C21E02;\n\tFri, 20 Apr 2018 15:54:34 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid D5551C21DFB; Fri, 20 Apr 2018 15:54:26 +0000 (UTC)", "from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109])\n\tby lists.denx.de (Postfix) with ESMTPS id C8A57C21CB1\n\tfor <u-boot@lists.denx.de>; Fri, 20 Apr 2018 15:54:24 +0000 (UTC)", "from trochilidae.toradex.int (unknown [IPv6:2001:1620:c6e:10::3])\n\tby mail.kmu-office.ch (Postfix) with ESMTPSA id 3FBCD5C175B;\n\tFri, 20 Apr 2018 17:54:24 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED,\n\tSPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim;\n\tt=1524239664;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:content-type:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=XX8DC9vApUbOjC9rgJhu9MLDmCPZ58TQiUT5FeO69BM=;\n\tb=QmpBw7Q9la3paN7SKIM2tC9ZfobE8x6GzEOY+KrnTxHIa1jK5vSVqJreGmDwwdpkrZx2Z9\n\tnfbL6MBPYtuuKZwNcMCUSBQceSbFZnXJvyi6H4glH4wM+nKrtbVVFXUke4axeg/ezSjJP5\n\t9AyZfyrxD2uxm2EA4szqcFfgh/y4WLk=", "From": "Stefan Agner <stefan@agner.ch>", "To": "u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>, oss@buserror.net", "Date": "Fri, 20 Apr 2018 17:53:09 +0200", "Message-Id": "<20180420155314.8920-5-stefan@agner.ch>", "X-Mailer": "git-send-email 2.17.0", "In-Reply-To": "<20180420155314.8920-1-stefan@agner.ch>", "References": "<20180420155314.8920-1-stefan@agner.ch>", "X-Spamd-Result": "default: False [-2.10 / 15.00]; RCVD_TLS_ALL(0.00)[];\n\tASN(0.00)[asn:13030, ipnet:2001:1620::/32, country:CH];\n\tRCVD_COUNT_ZERO(0.00)[0]; FROM_HAS_DN(0.00)[];\n\tMID_CONTAINS_FROM(1.00)[]; TO_DN_SOME(0.00)[];\n\tMIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%];\n\tARC_NA(0.00)[]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]", "Cc": "marex@denx.de, Stefan Agner <stefan.agner@toradex.com>,\n\tMarcel Ziswiler <marcel.ziswiler@toradex.com>,\n\tMax Krummenacher <max.krummenacher@toradex.com>, han.xu@nxp.com", "Subject": "[U-Boot] [PATCH v1 4/9] mtd: nand: mxs_nand: add use_minimum_ecc to\n\tstruct", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "From: Stefan Agner <stefan.agner@toradex.com>\n\nAdd use_minimum_ecc as struct mxs_nand_info field in preparation\nfor device tree support.\n\nSigned-off-by: Stefan Agner <stefan.agner@toradex.com>\n---\n\n drivers/mtd/nand/mxs_nand.c | 34 ++++++++++++++++++++--------------\n 1 file changed, 20 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c\nindex b5fd0fdd62..978f6a6893 100644\n--- a/drivers/mtd/nand/mxs_nand.c\n+++ b/drivers/mtd/nand/mxs_nand.c\n@@ -70,6 +70,8 @@ struct bch_geometry {\n \n struct mxs_nand_info {\n \tstruct nand_chip chip;\n+\tunsigned int\tmax_ecc_strength_supported;\n+\tbool\t\tuse_minimum_ecc;\n \tint\t\tcur_chip;\n \n \tuint32_t\tcmd_queue_len;\n@@ -214,19 +216,11 @@ static inline int mxs_nand_calc_mark_offset(struct bch_geometry *geo,\n \treturn 0;\n }\n \n-static inline unsigned int mxs_nand_max_ecc_strength_supported(void)\n-{\n-\t/* Refer to Chapter 17 for i.MX6DQ, Chapter 18 for i.MX6SX */\n-\tif (is_mx6sx() || is_mx7())\n-\t\treturn 62;\n-\telse\n-\t\treturn 40;\n-}\n-\n static inline int mxs_nand_calc_ecc_layout_by_info(struct bch_geometry *geo,\n \t\t\t\t\t\t struct mtd_info *mtd)\n {\n \tstruct nand_chip *chip = mtd_to_nand(mtd);\n+\tstruct mxs_nand_info *nand_info = nand_get_controller_data(chip);\n \n \tif (!(chip->ecc_strength_ds > 0 && chip->ecc_step_ds > 0))\n \t\treturn -ENOTSUPP;\n@@ -249,7 +243,7 @@ static inline int mxs_nand_calc_ecc_layout_by_info(struct bch_geometry *geo,\n \tif (geo->ecc_chunk_size < mtd->oobsize)\n \t\treturn -EINVAL;\n \n-\tif (geo->ecc_strength > mxs_nand_max_ecc_strength_supported())\n+\tif (geo->ecc_strength > nand_info->max_ecc_strength_supported)\n \t\treturn -EINVAL;\n \n \tgeo->ecc_chunk_count = mtd->writesize / geo->ecc_chunk_size;\n@@ -260,6 +254,9 @@ static inline int mxs_nand_calc_ecc_layout_by_info(struct bch_geometry *geo,\n static inline int mxs_nand_calc_ecc_layout(struct bch_geometry *geo,\n \t\t\t\t\t struct mtd_info *mtd)\n {\n+\tstruct nand_chip *chip = mtd_to_nand(mtd);\n+\tstruct mxs_nand_info *nand_info = nand_get_controller_data(chip);\n+\n \t/* The default for the length of Galois Field. */\n \tgeo->gf_len = 13;\n \n@@ -291,7 +288,7 @@ static inline int mxs_nand_calc_ecc_layout(struct bch_geometry *geo,\n \t\t\t/ (geo->gf_len * geo->ecc_chunk_count);\n \n \tgeo->ecc_strength = min(round_down(geo->ecc_strength, 2),\n-\t\t\t\tmxs_nand_max_ecc_strength_supported());\n+\t\t\t\tnand_info->max_ecc_strength_supported);\n \n \treturn 0;\n }\n@@ -1041,9 +1038,8 @@ static int mxs_nand_setup_ecc(struct mtd_info *mtd)\n \tuint32_t tmp;\n \tint ret = -ENOTSUPP;\n \n-#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC\n-\tret = mxs_nand_calc_ecc_layout_by_info(geo, mtd);\n-#endif\n+\tif (nand_info->use_minimum_ecc)\n+\t\tret = mxs_nand_calc_ecc_layout_by_info(geo, mtd);\n \n \tif (ret == -ENOTSUPP)\n \t\tret = mxs_nand_calc_ecc_layout(geo, mtd);\n@@ -1279,5 +1275,15 @@ void board_nand_init(void)\n \tnand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;\n \tnand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;\n \n+\t/* Refer to Chapter 17 for i.MX6DQ, Chapter 18 for i.MX6SX */\n+\tif (is_mx6sx() || is_mx7())\n+\t\tnand_info->max_ecc_strength_supported = 62;\n+\telse\n+\t\tnand_info->max_ecc_strength_supported = 40;\n+\n+#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC\n+\tnand_info->use_minimum_ecc = true;\n+#endif\n+\n \tmxs_nand_init(nand_info);\n }\n", "prefixes": [ "U-Boot", "v1", "4/9" ] }