Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/901567/?format=api
{ "id": 901567, "url": "http://patchwork.ozlabs.org/api/patches/901567/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180420000657.2316.31792.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180420000657.2316.31792.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2018-04-20T00:06:57", "name": "ixgbe: return error on upsupported SFP module when resetting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fb67f8c0fd6a222bb528f2586e6e3a064cf18c87", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180420000657.2316.31792.stgit@localhost6.localdomain6/mbox/", "series": [ { "id": 39966, "url": "http://patchwork.ozlabs.org/api/series/39966/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=39966", "date": "2018-04-20T00:06:57", "name": "ixgbe: return error on upsupported SFP module when resetting", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/39966/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/901567/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/901567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40Rwsh4hnCz9s1s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Apr 2018 09:57:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 683B22E4C6;\n\tThu, 19 Apr 2018 23:57:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id inutIBOE+W7G; Thu, 19 Apr 2018 23:57:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 077072E2B2;\n\tThu, 19 Apr 2018 23:57:57 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id D69501C2314\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Apr 2018 23:57:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D1FD42E2B2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Apr 2018 23:57:51 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4l9c3cI4Ch2T for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Apr 2018 23:57:51 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F3A1B22F58\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Apr 2018 23:57:50 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Apr 2018 16:57:50 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.100])\n\tby fmsmga001.fm.intel.com with ESMTP; 19 Apr 2018 16:57:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,298,1520924400\"; d=\"scan'208\";a=\"48386964\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 19 Apr 2018 17:06:57 -0700", "Message-ID": "<20180420000657.2316.31792.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: return error on upsupported SFP\n\tmodule when resetting", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add check for unsupported module and return the error code.\nThis fixes a Coverity hit due to unused return status from setup_sfp.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex beec1d0..a8148c7 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -3408,6 +3408,9 @@ static s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)\n \t\thw->phy.sfp_setup_needed = false;\n \t}\n \n+\tif (status == IXGBE_ERR_SFP_NOT_SUPPORTED)\n+\t\treturn status;\n+\n \t/* Reset PHY */\n \tif (!hw->phy.reset_disable && hw->phy.ops.reset)\n \t\thw->phy.ops.reset(hw);\n", "prefixes": [] }