Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/900296/?format=api
{ "id": 900296, "url": "http://patchwork.ozlabs.org/api/patches/900296/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180418182327.31854-1-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180418182327.31854-1-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-04-18T18:23:27", "name": "ice: Set rq_last_status when cleaning rq", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "36c5d662473c36f09e3a59b7bacf5223463e9cb2", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180418182327.31854-1-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 39599, "url": "http://patchwork.ozlabs.org/api/series/39599/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=39599", "date": "2018-04-18T18:23:27", "name": "ice: Set rq_last_status when cleaning rq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/39599/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/900296/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/900296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40R9VG1M3jz9s4c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 19 Apr 2018 04:23:33 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DFD9486B6D;\n\tWed, 18 Apr 2018 18:23:31 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LWoF3ZbxQz5z; Wed, 18 Apr 2018 18:23:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 477F386978;\n\tWed, 18 Apr 2018 18:23:30 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5D1251CF162\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 18:23:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 58B282273A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 18:23:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mScdHYdHDBxv for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 18:23:28 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 6359A22641\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 18:23:28 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Apr 2018 11:23:27 -0700", "from shasta.jf.intel.com ([10.166.241.32])\n\tby orsmga005.jf.intel.com with ESMTP; 18 Apr 2018 11:23:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,466,1517904000\"; d=\"scan'208\";a=\"217602468\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 18 Apr 2018 11:23:27 -0700", "Message-Id": "<20180418182327.31854-1-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "Subject": "[Intel-wired-lan] [PATCH] ice: Set rq_last_status when cleaning rq", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jeff Shaw <jeffrey.b.shaw@intel.com>\n\nPrior to this commit, the rq_last_status was only set when hardware\nresponded with an error. This leads to rq_last_status being invalid\nin the future when hardware eventually responds without error. This\ncommit resolves the issue by unconditionally setting rq_last_status\nwith the value returned in the descriptor.\n\nFixes: 940b61af02f4 (\"ice: Initialize PF and setup miscellaneous\ninterrupt\")\n\nSigned-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_controlq.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c b/drivers/net/ethernet/intel/ice/ice_controlq.c\nindex 5909a4407e38..7c511f144ed6 100644\n--- a/drivers/net/ethernet/intel/ice/ice_controlq.c\n+++ b/drivers/net/ethernet/intel/ice/ice_controlq.c\n@@ -1014,10 +1014,10 @@ ice_clean_rq_elem(struct ice_hw *hw, struct ice_ctl_q_info *cq,\n \tdesc = ICE_CTL_Q_DESC(cq->rq, ntc);\n \tdesc_idx = ntc;\n \n+\tcq->rq_last_status = (enum ice_aq_err)le16_to_cpu(desc->retval);\n \tflags = le16_to_cpu(desc->flags);\n \tif (flags & ICE_AQ_FLAG_ERR) {\n \t\tret_code = ICE_ERR_AQ_ERROR;\n-\t\tcq->rq_last_status = (enum ice_aq_err)le16_to_cpu(desc->retval);\n \t\tice_debug(hw, ICE_DBG_AQ_MSG,\n \t\t\t \"Control Receive Queue Event received with error 0x%x\\n\",\n \t\t\t cq->rq_last_status);\n", "prefixes": [] }