Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/900279/?format=api
{ "id": 900279, "url": "http://patchwork.ozlabs.org/api/patches/900279/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1524071815-32439-1-git-send-email-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1524071815-32439-1-git-send-email-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2018-04-18T17:16:55", "name": "ixgbe: Fix free irq process when removing device due to PCI Errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "44b8199862dbf5d719fafab21440b47cba3bacaa", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1524071815-32439-1-git-send-email-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 39590, "url": "http://patchwork.ozlabs.org/api/series/39590/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=39590", "date": "2018-04-18T17:16:55", "name": "ixgbe: Fix free irq process when removing device due to PCI Errors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/39590/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/900279/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/900279/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40R8300LFVz9s4l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 19 Apr 2018 03:18:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E514E864D4;\n\tWed, 18 Apr 2018 17:18:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PmZq+7uF1ZE8; Wed, 18 Apr 2018 17:18:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1203D86650;\n\tWed, 18 Apr 2018 17:18:17 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 398991C0CF8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 17:18:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 358B6873D1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 17:18:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wftNYeQ1gK5p for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 17:18:14 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id B9F4F86F42\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 17:18:14 +0000 (UTC)", "from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw3IHI1Zr025031 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 13:18:14 -0400", "from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2he9p99n4v-1\n\t(version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Apr 2018 13:18:04 -0400", "from localhost\n\tby e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <intel-wired-lan@lists.osuosl.org> from\n\t<maurosr@linux.vnet.ibm.com>; Wed, 18 Apr 2018 11:17:08 -0600", "from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18)\n\tby e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 18 Apr 2018 11:17:06 -0600", "from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id w3IHH0w112124512; Wed, 18 Apr 2018 10:17:05 -0700", "from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 264C278037;\n\tWed, 18 Apr 2018 11:17:05 -0600 (MDT)", "from localhost (unknown [9.18.239.64])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id EBC397804D;\n\tWed, 18 Apr 2018 11:17:04 -0600 (MDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org", "Date": "Wed, 18 Apr 2018 14:16:55 -0300", "X-Mailer": "git-send-email 2.7.4", "X-TM-AS-GCONF": "00", "x-cbid": "18041817-0028-0000-0000-00000976F49F", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00008878; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000257; SDB=6.01019783; UDB=6.00520282;\n\tIPR=6.00799024; \n\tMB=3.00020644; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-18 17:17:07", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "18041817-0029-0000-0000-00003A6E1875", "Message-Id": "<1524071815-32439-1-git-send-email-maurosr@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2018-04-18_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1709140000\n\tdefinitions=main-1804180155", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Fix free irq process when removing\n\tdevice due to PCI Errors", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "abdhalee@in.ibm.com, nbannoth@in.ibm.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When a PCI error is detected ixgbe's pci error handler\nixgbe_io_error_detected detaches the network device. In general the PCI\nerror recovery mechanism may try to recover the device from the error or\neventually remove it completely from the system.\n\nSince commit f7f37e7ff2b9 (\"ixgbe: handle close/suspend race with\nnetif_device_detach/present\")\nwe only follow to ixgbe_close_suspend if\nthe device is preset, i.e. if it wasn't detached, and then the irqs are\nfreed. That prevents to free irqs when the PCI error recovery system\ndecides to remove the device and hitting a BUG_ON free_msi_irqs when it\nsearch for non freed irqs associated with the device being removed:\n\nBUG_ON(irq_has_action(entry->irq + i));\n\nThis is fixed allowing the ixgbe_close_suspend, and thus ixgbe_free_irq,\nto be called also when the PCI error recovery mechanism sets the device\nchannel to permanent failure state.\n\nReported-by: Naresh Bannoth <nbannoth@in.ibm.com>\nReported-by: Abdul Haleem <abdhalee@in.ibm.com>\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex afadba9..d170de8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6679,7 +6679,8 @@ int ixgbe_close(struct net_device *netdev)\n \n \tixgbe_ptp_stop(adapter);\n \n-\tif (netif_device_present(netdev))\n+\tif (netif_device_present(netdev) ||\n+\t adapter->pdev->error_state == pci_channel_io_perm_failure)\n \t\tixgbe_close_suspend(adapter);\n \n \tixgbe_fdir_filter_exit(adapter);\n", "prefixes": [] }