Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/897754/?format=api
{ "id": 897754, "url": "http://patchwork.ozlabs.org/api/patches/897754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180412181559.4343-6-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180412181559.4343-6-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2018-04-12T18:15:59", "name": "[6/6] fm10k: don't protect fm10k_queue_mac_request by fm10k_host_mbx_ready", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e83eb224c1ba4c49ee3c78a8bdec43068c556b09", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180412181559.4343-6-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 38679, "url": "http://patchwork.ozlabs.org/api/series/38679/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=38679", "date": "2018-04-12T18:15:54", "name": "[1/6] fm10k: setup VLANs for l2 accelerated macvlan interfaces", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/38679/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/897754/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/897754/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40MTcf0DPwz9s25\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 Apr 2018 04:16:17 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 708C32C885;\n\tThu, 12 Apr 2018 18:16:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R94NL6aHk-oj; Thu, 12 Apr 2018 18:16:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D7745221DF;\n\tThu, 12 Apr 2018 18:16:15 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3A5201CF13A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Apr 2018 18:16:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 375F122070\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Apr 2018 18:16:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B4AsANbx4iXo for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Apr 2018 18:16:11 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 919B2221D2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Apr 2018 18:16:11 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Apr 2018 11:16:11 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.177.161])\n\tby fmsmga004.fm.intel.com with ESMTP; 12 Apr 2018 11:16:10 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,442,1517904000\"; d=\"scan'208\";a=\"45707736\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 12 Apr 2018 11:15:59 -0700", "Message-Id": "<20180412181559.4343-6-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.15.1.478.ga1e07cd25f8b", "In-Reply-To": "<20180412181559.4343-1-jacob.e.keller@intel.com>", "References": "<20180412181559.4343-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 6/6] fm10k: don't protect\n\tfm10k_queue_mac_request by fm10k_host_mbx_ready", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We don't actually need to check if the host mbx is ready when queuing\nMAC requests, because these are not handled by a special queue which\nqueues up requests until the mailbox is capable of handling them.\n\nPull these requests outside the fm10k_host_mbx_ready() check, as it is\nnot necessary.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 36200dec941d..11204fdbb484 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -1555,12 +1555,12 @@ static void *fm10k_dfwd_add_station(struct net_device *dev,\n \n \tglort = l2_accel->dglort + 1 + i;\n \n-\tif (fm10k_host_mbx_ready(interface)) {\n+\tif (fm10k_host_mbx_ready(interface))\n \t\thw->mac.ops.update_xcast_mode(hw, glort,\n \t\t\t\t\t FM10K_XCAST_MODE_NONE);\n-\t\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n-\t\t\t\t\thw->mac.default_vid, true);\n-\t}\n+\n+\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n+\t\t\t\thw->mac.default_vid, true);\n \n \tfor (vid = fm10k_find_next_vlan(interface, 0);\n \t vid < VLAN_N_VID;\n@@ -1601,12 +1601,12 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)\n \n \tglort = l2_accel->dglort + 1 + i;\n \n-\tif (fm10k_host_mbx_ready(interface)) {\n+\tif (fm10k_host_mbx_ready(interface))\n \t\thw->mac.ops.update_xcast_mode(hw, glort,\n \t\t\t\t\t FM10K_XCAST_MODE_NONE);\n-\t\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n-\t\t\t\t\thw->mac.default_vid, false);\n-\t}\n+\n+\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n+\t\t\t\thw->mac.default_vid, false);\n \n \tfor (vid = fm10k_find_next_vlan(interface, 0);\n \t vid < VLAN_N_VID;\n", "prefixes": [ "6/6" ] }