Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/896859/?format=api
{ "id": 896859, "url": "http://patchwork.ozlabs.org/api/patches/896859/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180410174959.18757-9-vinicius.gomes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180410174959.18757-9-vinicius.gomes@intel.com>", "list_archive_url": null, "date": "2018-04-10T17:49:57", "name": "[next-queue,v7,08/10] igb: Add MAC address support for ethtool nftuple filters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ae1533248d2f060cf8438aa6520123ddb3f96e78", "submitter": { "id": 72272, "url": "http://patchwork.ozlabs.org/api/people/72272/?format=api", "name": "Vinicius Costa Gomes", "email": "vinicius.gomes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180410174959.18757-9-vinicius.gomes@intel.com/mbox/", "series": [ { "id": 38278, "url": "http://patchwork.ozlabs.org/api/series/38278/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=38278", "date": "2018-04-10T17:49:50", "name": "igb: offloading of receive filters", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/38278/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/896859/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/896859/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40LF7w4s4fz9s3B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 11 Apr 2018 03:50:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 20B8286776;\n\tTue, 10 Apr 2018 17:50:35 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DoE4eVdAucaB; Tue, 10 Apr 2018 17:50:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 08A3D867FB;\n\tTue, 10 Apr 2018 17:50:31 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1DE631C11AD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Apr 2018 17:50:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1B88584FCA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Apr 2018 17:50:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8K2sWoJDz5-o for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Apr 2018 17:50:28 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 462CE851B1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Apr 2018 17:50:28 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Apr 2018 10:50:28 -0700", "from kjnewhou-mobl1.amr.corp.intel.com (HELO localhost.localdomain)\n\t([10.254.183.149])\n\tby orsmga005.jf.intel.com with ESMTP; 10 Apr 2018 10:50:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,433,1517904000\"; d=\"scan'208\";a=\"215551520\"", "From": "Vinicius Costa Gomes <vinicius.gomes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 10 Apr 2018 10:49:57 -0700", "Message-Id": "<20180410174959.18757-9-vinicius.gomes@intel.com>", "X-Mailer": "git-send-email 2.17.0", "In-Reply-To": "<20180410174959.18757-1-vinicius.gomes@intel.com>", "References": "<20180410174959.18757-1-vinicius.gomes@intel.com>", "Subject": "[Intel-wired-lan] [next-queue PATCH v7 08/10] igb: Add MAC address\n\tsupport for ethtool nftuple filters", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This adds the capability of configuring the queue steering of arriving\npackets based on their source and destination MAC addresses.\n\nSource address steering (i.e. driving traffic to a specific queue),\nfor the i210, does not work, but filtering does (i.e. accepting\ntraffic based on the source address). So, trying to add a filter\nspecifying only a source address will be an error.\n\nIn practical terms this adds support for the following use cases,\ncharacterized by these examples:\n\n$ ethtool -N eth0 flow-type ether dst aa:aa:aa:aa:aa:aa action 0\n(this will direct packets with destination address \"aa:aa:aa:aa:aa:aa\"\nto the RX queue 0)\n\n$ ethtool -N eth0 flow-type ether src 44:44:44:44:44:44 \\\n \t \t \t \t proto 0x22f0 action 3\n(this will direct packets with source address \"44:44:44:44:44:44\" and\nethertype 0x22f0 to the RX queue 3)\n\nSigned-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 43 ++++++++++++++++++--\n 1 file changed, 39 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 31b2960a7869..6697c273ab59 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -2495,6 +2495,23 @@ static int igb_get_ethtool_nfc_entry(struct igb_adapter *adapter,\n \t\t\tfsp->h_ext.vlan_tci = rule->filter.vlan_tci;\n \t\t\tfsp->m_ext.vlan_tci = htons(VLAN_PRIO_MASK);\n \t\t}\n+\t\tif (rule->filter.match_flags & IGB_FILTER_FLAG_DST_MAC_ADDR) {\n+\t\t\tether_addr_copy(fsp->h_u.ether_spec.h_dest,\n+\t\t\t\t\trule->filter.dst_addr);\n+\t\t\t/* As we only support matching by the full\n+\t\t\t * mask, return the mask to userspace\n+\t\t\t */\n+\t\t\teth_broadcast_addr(fsp->m_u.ether_spec.h_dest);\n+\t\t}\n+\t\tif (rule->filter.match_flags & IGB_FILTER_FLAG_SRC_MAC_ADDR) {\n+\t\t\tether_addr_copy(fsp->h_u.ether_spec.h_source,\n+\t\t\t\t\trule->filter.src_addr);\n+\t\t\t/* As we only support matching by the full\n+\t\t\t * mask, return the mask to userspace\n+\t\t\t */\n+\t\t\teth_broadcast_addr(fsp->m_u.ether_spec.h_source);\n+\t\t}\n+\n \t\treturn 0;\n \t}\n \treturn -EINVAL;\n@@ -2768,8 +2785,16 @@ static int igb_rxnfc_write_vlan_prio_filter(struct igb_adapter *adapter,\n \n int igb_add_filter(struct igb_adapter *adapter, struct igb_nfc_filter *input)\n {\n+\tstruct e1000_hw *hw = &adapter->hw;\n \tint err = -EINVAL;\n \n+\tif (hw->mac.type == e1000_i210 &&\n+\t !(input->filter.match_flags & ~IGB_FILTER_FLAG_SRC_MAC_ADDR)) {\n+\t\tdev_err(&adapter->pdev->dev,\n+\t\t\t\"i210 doesn't support flow classification rules specifying only source addresses.\\n\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n \tif (input->filter.match_flags & IGB_FILTER_FLAG_ETHER_TYPE) {\n \t\terr = igb_rxnfc_write_etype_filter(adapter, input);\n \t\tif (err)\n@@ -2933,10 +2958,6 @@ static int igb_add_ethtool_nfc_entry(struct igb_adapter *adapter,\n \tif ((fsp->flow_type & ~FLOW_EXT) != ETHER_FLOW)\n \t\treturn -EINVAL;\n \n-\tif (fsp->m_u.ether_spec.h_proto != ETHER_TYPE_FULL_MASK &&\n-\t fsp->m_ext.vlan_tci != htons(VLAN_PRIO_MASK))\n-\t\treturn -EINVAL;\n-\n \tinput = kzalloc(sizeof(*input), GFP_KERNEL);\n \tif (!input)\n \t\treturn -ENOMEM;\n@@ -2946,6 +2967,20 @@ static int igb_add_ethtool_nfc_entry(struct igb_adapter *adapter,\n \t\tinput->filter.match_flags = IGB_FILTER_FLAG_ETHER_TYPE;\n \t}\n \n+\t/* Only support matching addresses by the full mask */\n+\tif (is_broadcast_ether_addr(fsp->m_u.ether_spec.h_source)) {\n+\t\tinput->filter.match_flags |= IGB_FILTER_FLAG_SRC_MAC_ADDR;\n+\t\tether_addr_copy(input->filter.src_addr,\n+\t\t\t\tfsp->h_u.ether_spec.h_source);\n+\t}\n+\n+\t/* Only support matching addresses by the full mask */\n+\tif (is_broadcast_ether_addr(fsp->m_u.ether_spec.h_dest)) {\n+\t\tinput->filter.match_flags |= IGB_FILTER_FLAG_DST_MAC_ADDR;\n+\t\tether_addr_copy(input->filter.dst_addr,\n+\t\t\t\tfsp->h_u.ether_spec.h_dest);\n+\t}\n+\n \tif ((fsp->flow_type & FLOW_EXT) && fsp->m_ext.vlan_tci) {\n \t\tif (fsp->m_ext.vlan_tci != htons(VLAN_PRIO_MASK)) {\n \t\t\terr = -EINVAL;\n", "prefixes": [ "next-queue", "v7", "08/10" ] }