Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/894803/?format=api
{ "id": 894803, "url": "http://patchwork.ozlabs.org/api/patches/894803/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180403211635.7880.27194.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180403211635.7880.27194.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2018-04-03T21:16:35", "name": "[iwl,next-queue,08/10] ixgbe/fm10k: Only support macvlan offload for types that support destination filtering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eb027327025e93a6a6794d418dc958d3f1d51f78", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180403211635.7880.27194.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 37262, "url": "http://patchwork.ozlabs.org/api/series/37262/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=37262", "date": "2018-04-03T21:15:53", "name": "Clean-up macvlan offloading", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/37262/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/894803/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/894803/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40G2BV4DdGz9s08\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 Apr 2018 07:23:14 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id F3E6F30AFB;\n\tTue, 3 Apr 2018 21:23:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id M5xideLNo0xT; Tue, 3 Apr 2018 21:23:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 81E10306A8;\n\tTue, 3 Apr 2018 21:23:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2927D1C039A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Apr 2018 21:23:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 267DA306A8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Apr 2018 21:23:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pNHCsSQua73z for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Apr 2018 21:23:11 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 70C7C2C899\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Apr 2018 21:23:11 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2018 14:23:11 -0700", "from ahduyck-green-test.jf.intel.com ([10.166.244.179])\n\tby orsmga002.jf.intel.com with ESMTP; 03 Apr 2018 14:23:10 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,402,1517904000\"; d=\"scan'208\";a=\"47715174\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Tue, 03 Apr 2018 17:16:35 -0400", "Message-ID": "<20180403211635.7880.27194.stgit@ahduyck-green-test.jf.intel.com>", "In-Reply-To": "<20180403211519.7880.70243.stgit@ahduyck-green-test.jf.intel.com>", "References": "<20180403211519.7880.70243.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [iwl next-queue PATCH 08/10] ixgbe/fm10k: Only\n\tsupport macvlan offload for types that support destination filtering", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Both the ixgbe and fm10k drivers support destination filtering.\n\nInstead of adding a ton of complexity to support either source or passthru\nmode we can instead just avoid offloading them for now. Doing this we avoid\nleaking packets into interfaces that aren't meant to receive them.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 8 ++++++++\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 +++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex ee645ba..26e7497 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -22,6 +22,7 @@\n #include \"fm10k.h\"\n #include <linux/vmalloc.h>\n #include <net/udp_tunnel.h>\n+#include <linux/if_macvlan.h>\n \n /**\n * fm10k_setup_tx_resources - allocate Tx resources (Descriptors)\n@@ -1449,6 +1450,13 @@ static void *fm10k_dfwd_add_station(struct net_device *dev,\n \tint size = 0, i;\n \tu16 glort;\n \n+\t/* The hardware supported by fm10k only filters on the destination MAC\n+\t * address. In order to avoid issues we only support offloading modes\n+\t * where the hardware can actually provide the functionality.\n+\t */\n+\tif (!macvlan_supports_dest_filter(sdev))\n+\t\treturn ERR_PTR(-EMEDIUMTYPE);\n+\n \t/* allocate l2 accel structure if it is not available */\n \tif (!l2_accel) {\n \t\t/* verify there is enough free GLORTs to support l2_accel */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 2c5100e..7c0f310 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9744,6 +9744,13 @@ static void *ixgbe_fwd_add(struct net_device *pdev, struct net_device *vdev)\n \tunsigned int limit;\n \tint pool, err;\n \n+\t/* The hardware supported by ixgbe only filters on the destination MAC\n+\t * address. In order to avoid issues we only support offloading modes\n+\t * where the hardware can actually provide the functionality.\n+\t */\n+\tif (!macvlan_supports_dest_filter(vdev))\n+\t\treturn ERR_PTR(-EMEDIUMTYPE);\n+\n \t/* Hardware has a limited number of available pools. Each VF, and the\n \t * PF require a pool. Check to ensure we don't attempt to use more\n \t * then the available number of pools.\n", "prefixes": [ "iwl", "next-queue", "08/10" ] }