Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/894356/?format=api
{ "id": 894356, "url": "http://patchwork.ozlabs.org/api/patches/894356/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1522695990-31082-7-git-send-email-okaya@codeaurora.org/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1522695990-31082-7-git-send-email-okaya@codeaurora.org>", "list_archive_url": null, "date": "2018-04-02T19:06:29", "name": "[v8,6/7] ixgbevf: keep writel() closer to wmb()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e8a3d5ef139c39d65f7b005ff47725370936c89d", "submitter": { "id": 67496, "url": "http://patchwork.ozlabs.org/api/people/67496/?format=api", "name": "Sinan Kaya", "email": "okaya@codeaurora.org" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1522695990-31082-7-git-send-email-okaya@codeaurora.org/mbox/", "series": [ { "id": 37041, "url": "http://patchwork.ozlabs.org/api/series/37041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=37041", "date": "2018-04-02T19:06:25", "name": "[v8,1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/37041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/894356/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/894356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=codeaurora.org", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"kIaRfpgl\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"A2Lb6ybA\"; dkim-atps=neutral", "pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org", "pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40FMCg50Nmz9s1s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 3 Apr 2018 05:06:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1FC908955A;\n\tMon, 2 Apr 2018 19:06:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WbTRl-McRTZi; Mon, 2 Apr 2018 19:06:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D117589565;\n\tMon, 2 Apr 2018 19:06:52 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 404211C066A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3C78330A0E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:51 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id IZqXnhzpuDPT for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:48 +0000 (UTC)", "from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A796C30A66\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:47 +0000 (UTC)", "by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 30C3F60F93; Mon, 2 Apr 2018 19:06:47 +0000 (UTC)", "from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com\n\t[129.46.232.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 76609602B7;\n\tMon, 2 Apr 2018 19:06:44 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1522696007;\n\tbh=IHU8mKvBFJa0OWfPU1yx26ts/T+hPvggeaY1EEvxYno=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kIaRfpglzqRQP2qH8dVwf5053B1MBBuUQLn4YFjCni6GRpb8ZPWRshsek5FJurALj\n\tBucyBAAbMnZY9aR7rL2ZH7FQOnt4qDpB8Pvss8bm+HI8d0oBcpcnNxTokFkEK6JhUo\n\tG7NyWqVJtgGC1Btmy1HR6z/blLeF38H/GxMcF6Mc=", "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1522696005;\n\tbh=IHU8mKvBFJa0OWfPU1yx26ts/T+hPvggeaY1EEvxYno=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A2Lb6ybA6ltYQgoa/sNKM8+iLHNQXtKULY6Z8fSsA104yu0YDRStfXUYEm2lVtKLv\n\tE//0bRX7qEjnpb2zzbOLLSMk27WJxwjtZrnWTfQLSTBxAZV8w5TISuln9bdw6jyUEJ\n\t2XlHbDzMRQWGeon9lcxhgmRAVglLx1AXFv2fVN0w=" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 smtp.codeaurora.org 76609602B7", "From": "Sinan Kaya <okaya@codeaurora.org>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Mon, 2 Apr 2018 15:06:29 -0400", "Message-Id": "<1522695990-31082-7-git-send-email-okaya@codeaurora.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1522695990-31082-1-git-send-email-okaya@codeaurora.org>", "References": "<1522695990-31082-1-git-send-email-okaya@codeaurora.org>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v8 6/7] ixgbevf: keep writel() closer to\n\twmb()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org,\n\tlinux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,\n\tintel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Remove ixgbevf_write_tail() in favor of moving writel() close to\nwmb().\n\nSigned-off-by: Sinan Kaya <okaya@codeaurora.org>\nReviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 -----\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 +++---\n 2 files changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\nindex 447ce1d..c75ea1f 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n@@ -312,11 +312,6 @@ static inline u16 ixgbevf_desc_unused(struct ixgbevf_ring *ring)\n \treturn ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1;\n }\n \n-static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value)\n-{\n-\twritel(value, ring->tail);\n-}\n-\n #define IXGBEVF_RX_DESC(R, i)\t\\\n \t(&(((union ixgbe_adv_rx_desc *)((R)->desc))[i]))\n #define IXGBEVF_TX_DESC(R, i)\t\\\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex e3d04f2..757dac6 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -725,7 +725,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,\n \t\t * such as IA-64).\n \t\t */\n \t\twmb();\n-\t\tixgbevf_write_tail(rx_ring, i);\n+\t\twritel(i, rx_ring->tail);\n \t}\n }\n \n@@ -1232,7 +1232,7 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,\n \t\t * know there are new descriptors to fetch.\n \t\t */\n \t\twmb();\n-\t\tixgbevf_write_tail(xdp_ring, xdp_ring->next_to_use);\n+\t\twritel(xdp_ring->next_to_use, xdp_ring->tail);\n \t}\n \n \tu64_stats_update_begin(&rx_ring->syncp);\n@@ -4004,7 +4004,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring,\n \ttx_ring->next_to_use = i;\n \n \t/* notify HW of packet */\n-\tixgbevf_write_tail(tx_ring, i);\n+\twritel(i, tx_ring->tail);\n \n \treturn;\n dma_error:\n", "prefixes": [ "v8", "6/7" ] }