Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/894354/?format=api
{ "id": 894354, "url": "http://patchwork.ozlabs.org/api/patches/894354/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1522695990-31082-4-git-send-email-okaya@codeaurora.org/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1522695990-31082-4-git-send-email-okaya@codeaurora.org>", "list_archive_url": null, "date": "2018-04-02T19:06:26", "name": "[v8,3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b09f7f9ed68d01721c6163961b31599e613312bf", "submitter": { "id": 67496, "url": "http://patchwork.ozlabs.org/api/people/67496/?format=api", "name": "Sinan Kaya", "email": "okaya@codeaurora.org" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1522695990-31082-4-git-send-email-okaya@codeaurora.org/mbox/", "series": [ { "id": 37041, "url": "http://patchwork.ozlabs.org/api/series/37041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=37041", "date": "2018-04-02T19:06:25", "name": "[v8,1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/37041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/894354/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/894354/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=codeaurora.org", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"VAHQiJFN\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"MKUXYhjq\"; dkim-atps=neutral", "pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org", "pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40FMCY3TFbz9s21\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 3 Apr 2018 05:06:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EB40030A0E;\n\tMon, 2 Apr 2018 19:06:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YHimJf9u3AxW; Mon, 2 Apr 2018 19:06:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5514930A51;\n\tMon, 2 Apr 2018 19:06:46 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 646451C066A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 613098A384\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9TnzjXQ3pQrn for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:41 +0000 (UTC)", "from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id B068E8A387\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 2 Apr 2018 19:06:41 +0000 (UTC)", "by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 820E360F8D; Mon, 2 Apr 2018 19:06:41 +0000 (UTC)", "from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com\n\t[129.46.232.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id E4F0F60F6C;\n\tMon, 2 Apr 2018 19:06:39 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1522696001;\n\tbh=Cy8/4TyQ1VUmAg+Q6qTAguoMnhcWm7Jc0TpasDD11WA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VAHQiJFNvpEQelqNcljyhg0H7mArZZhGio0ThMymgoJYpc0RlSrjRdbyVuIRpCimy\n\tLw1FXEgyYHkVfssLq9M1cXfIMcd2MvVDdpkgM8uKtlyGbwoiFMFskQeLSVVzHAQ+/J\n\t4OLUCFISbXgC/+WOldX9OW+x0QX5P11fLGO6rZ8c=", "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1522696000;\n\tbh=Cy8/4TyQ1VUmAg+Q6qTAguoMnhcWm7Jc0TpasDD11WA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MKUXYhjqGuJj7FvnBH0nyaj6wbdeLIDNuhkT4yaZTuNDWw6z1G/hboUa598f9dXUX\n\t372Few8VK1SYu9VNN/5Iy7eYl1pqpwksYxuoenU2Kbub/4WU8AitH2tbLIWq2bgaGr\n\t+v6Zf4UdgOeIdQ8/L8P82hUuq3MZNM5wtYjIqpvc=" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 smtp.codeaurora.org E4F0F60F6C", "From": "Sinan Kaya <okaya@codeaurora.org>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Mon, 2 Apr 2018 15:06:26 -0400", "Message-Id": "<1522695990-31082-4-git-send-email-okaya@codeaurora.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1522695990-31082-1-git-send-email-okaya@codeaurora.org>", "References": "<1522695990-31082-1-git-send-email-okaya@codeaurora.org>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v8 3/7] igbvf: eliminate duplicate\n\tbarriers on weakly-ordered archs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org,\n\tlinux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,\n\tintel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "memory-barriers.txt has been updated as follows:\n\n\"When using writel(), a prior wmb() is not needed to guarantee that the\ncache coherent memory writes have completed before writing to the MMIO\nregion.\"\n\nRemove old IA-64 comments in the code along with unneeded wmb() in front\nof writel().\n\nThere are places in the code where wmb() has been used as a double barrier\nfor CPU and IO in place of smp_wmb() and wmb() as an optimization. For\nsuch places, keep the wmb() but replace the following writel() with\nwritel_relaxed() to have a sequence as\n\nwmb()\nwritel_relaxed()\nmmio_wb()\n\nSigned-off-by: Sinan Kaya <okaya@codeaurora.org>\n---\n drivers/net/ethernet/intel/igbvf/netdev.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c\nindex e2b7502..d9f186a 100644\n--- a/drivers/net/ethernet/intel/igbvf/netdev.c\n+++ b/drivers/net/ethernet/intel/igbvf/netdev.c\n@@ -246,12 +246,6 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring,\n \t\telse\n \t\t\ti--;\n \n-\t\t/* Force memory writes to complete before letting h/w\n-\t\t * know there are new descriptors to fetch. (Only\n-\t\t * applicable for weak-ordered memory model archs,\n-\t\t * such as IA-64).\n-\t\t*/\n-\t\twmb();\n \t\twritel(i, adapter->hw.hw_addr + rx_ring->tail);\n \t}\n }\n@@ -2289,16 +2283,16 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter,\n \t}\n \n \ttx_desc->read.cmd_type_len |= cpu_to_le32(adapter->txd_cmd);\n-\t/* Force memory writes to complete before letting h/w\n-\t * know there are new descriptors to fetch. (Only\n-\t * applicable for weak-ordered memory model archs,\n-\t * such as IA-64).\n+\n+\t/* We use this memory barrier to make certain all of the\n+\t * status bits have been updated before next_to_watch is\n+\t * written.\n \t */\n \twmb();\n \n \ttx_ring->buffer_info[first].next_to_watch = tx_desc;\n \ttx_ring->next_to_use = i;\n-\twritel(i, adapter->hw.hw_addr + tx_ring->tail);\n+\twritel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail);\n \t/* we need this if more than one processor can write to our tail\n \t * at a time, it synchronizes IO on IA64/Altix systems\n \t */\n", "prefixes": [ "v8", "3/7" ] }