Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/893600/?format=api
{ "id": 893600, "url": "http://patchwork.ozlabs.org/api/patches/893600/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180331000652.2855-1-vinicius.gomes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180331000652.2855-1-vinicius.gomes@intel.com>", "list_archive_url": null, "date": "2018-03-31T00:06:52", "name": "[next-queue] igb: Fix the transmission mode of queue 0 for Qav mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0958aca84afabb4e0e9f842c17e11277680f8d4b", "submitter": { "id": 72272, "url": "http://patchwork.ozlabs.org/api/people/72272/?format=api", "name": "Vinicius Costa Gomes", "email": "vinicius.gomes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180331000652.2855-1-vinicius.gomes@intel.com/mbox/", "series": [ { "id": 36748, "url": "http://patchwork.ozlabs.org/api/series/36748/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=36748", "date": "2018-03-31T00:06:52", "name": "[next-queue] igb: Fix the transmission mode of queue 0 for Qav mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/36748/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/893600/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/893600/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40Cf593HJPz9s12\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 31 Mar 2018 11:10:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E6FB289CDC;\n\tSat, 31 Mar 2018 00:10:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BLqAh6TcKs6H; Sat, 31 Mar 2018 00:10:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E1BA689CD3;\n\tSat, 31 Mar 2018 00:10:15 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 629211CF0FE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 31 Mar 2018 00:09:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5EA1989CC8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 31 Mar 2018 00:09:44 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id chua7yUfUhPt for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 31 Mar 2018 00:09:43 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4A75289CC6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 31 Mar 2018 00:09:43 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Mar 2018 17:09:40 -0700", "from ellie.jf.intel.com (HELO localhost.localdomain)\n\t([10.54.70.23])\n\tby fmsmga008.fm.intel.com with ESMTP; 30 Mar 2018 17:09:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,383,1517904000\"; d=\"scan'208\";a=\"28970102\"", "From": "Vinicius Costa Gomes <vinicius.gomes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 30 Mar 2018 17:06:52 -0700", "Message-Id": "<20180331000652.2855-1-vinicius.gomes@intel.com>", "X-Mailer": "git-send-email 2.16.3", "Subject": "[Intel-wired-lan] [next-queue PATCH] igb: Fix the transmission mode\n\tof queue 0 for Qav mode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When Qav mode is enabled, queue 0 should be kept on Stream Reservation\nmode. From the i210 datasheet, section 8.12.19:\n\n\"Note: Queue0 QueueMode must be set to 1b when TransmitMode is set to\nQav.\" (\"QueueMode 1b\" represents the Stream Reservation mode)\n\nThe solution is to give queue 0 the all the credits it might need, so\nit has priority over queue 1.\n\nA situation where this can happen is when cbs is \"installed\" only on\nqueue 1, leaving queue 0 alone. For example:\n\n$ tc qdisc replace dev enp2s0 handle 100: parent root mqprio num_tc 3 \\\n \t map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 queues 1@0 1@1 2@2 hw 0\n\n$ tc qdisc replace dev enp2s0 parent 100:2 cbs locredit -1470 \\\n \t hicredit 30 sendslope -980000 idleslope 20000 offload 1\n\nSigned-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex c1c0bc30a16d..cce7ada89255 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -1700,7 +1700,22 @@ static void igb_configure_cbs(struct igb_adapter *adapter, int queue,\n \tWARN_ON(hw->mac.type != e1000_i210);\n \tWARN_ON(queue < 0 || queue > 1);\n \n-\tif (enable) {\n+\tif (enable || queue == 0) {\n+\t\t/* i210 does not allow the queue 0 to be in the Strict\n+\t\t * Priority mode while the Qav mode is enabled, so,\n+\t\t * instead of disabling strict priority mode, we give\n+\t\t * queue 0 the maximum of credits possible.\n+\t\t *\n+\t\t * See section 8.12.19 of the i210 datasheet, \"Note:\n+\t\t * Queue0 QueueMode must be set to 1b when\n+\t\t * TransmitMode is set to Qav.\"\n+\t\t */\n+\t\tif (queue == 0 && !enable) {\n+\t\t\t/* max \"linkspeed\" idleslope in kbps */\n+\t\t\tidleslope = 1000000;\n+\t\t\thicredit = ETH_FRAME_LEN;\n+\t\t}\n+\n \t\tset_tx_desc_fetch_prio(hw, queue, TX_QUEUE_PRIO_HIGH);\n \t\tset_queue_mode(hw, queue, QUEUE_MODE_STREAM_RESERVATION);\n \n", "prefixes": [ "next-queue" ] }