Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/892820/?format=api
{ "id": 892820, "url": "http://patchwork.ozlabs.org/api/patches/892820/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1522335096-11689-1-git-send-email-serhe.popovych@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1522335096-11689-1-git-send-email-serhe.popovych@gmail.com>", "list_archive_url": null, "date": "2018-03-29T14:51:36", "name": "[next-queue] intel: correct return from set features callback", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0fa9e0ea49434225bec356bac8d0509fe1e123d9", "submitter": { "id": 71807, "url": "http://patchwork.ozlabs.org/api/people/71807/?format=api", "name": "Serhey Popovych", "email": "serhe.popovych@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1522335096-11689-1-git-send-email-serhe.popovych@gmail.com/mbox/", "series": [ { "id": 36509, "url": "http://patchwork.ozlabs.org/api/series/36509/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=36509", "date": "2018-03-29T14:51:36", "name": "[next-queue] intel: correct return from set features callback", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/36509/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/892820/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/892820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QWP13eSZ\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40Bnlm4Xlqz9s1S\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 30 Mar 2018 01:52:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2BF4688BEE;\n\tThu, 29 Mar 2018 14:52:18 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id atBC4FRMDH2Z; Thu, 29 Mar 2018 14:52:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 81BCB88BB3;\n\tThu, 29 Mar 2018 14:52:17 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8B2981C0BD3\n\tfor <intel-wired-lan@osuosl.org>;\n\tThu, 29 Mar 2018 14:52:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 81A2189AFA\n\tfor <intel-wired-lan@osuosl.org>;\n\tThu, 29 Mar 2018 14:52:15 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fByIm4iJrWTY for <intel-wired-lan@osuosl.org>;\n\tThu, 29 Mar 2018 14:52:15 +0000 (UTC)", "from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id A729D89AFB\n\tfor <intel-wired-lan@osuosl.org>;\n\tThu, 29 Mar 2018 14:52:14 +0000 (UTC)", "by mail-lf0-f68.google.com with SMTP id o102-v6so8791880lfg.8\n\tfor <intel-wired-lan@osuosl.org>;\n\tThu, 29 Mar 2018 07:52:14 -0700 (PDT)", "from tuxracer.localdomain ([2a01:6d80::195:20:96:53])\n\tby smtp.gmail.com with ESMTPSA id\n\tj199-v6sm1186729lfe.53.2018.03.29.07.52.11\n\tfor <intel-wired-lan@osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 29 Mar 2018 07:52:11 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id;\n\tbh=gDPcpfWtXLLBNJJd/r/RY58nfkfDZE/qcjnHfPuUpkg=;\n\tb=QWP13eSZLlT862im938JLgDglD8R1Ozd+M9hu5wiYhKlcl38ROSsydObDWoRnelq8K\n\tMY3bCs9g0ry9lhkJLU2BHJG6OHSnfuvPNoRoiRyRoZWYecHNxfII3Ek4d3axcKKt6U1K\n\t2LctIfsWz4LAg6z88A2tQ+i4jKdH/UwJG77ddv7Vkl3kyWuaoeGdTrc8SyUeATu7WEAc\n\tZ2riIR5TU5T6F3pyhaC9WUXm/dV9XhzSZj3s1lwzVhcRuTiVRilA9HmtUkrxo1f0ehtc\n\trwJMPCbsl8M5zV+DpB62NRHZ8j1YoM7MBaEc55cOK/39JDyiwUEHFypsPVlICOQhjEOu\n\tjmGw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=gDPcpfWtXLLBNJJd/r/RY58nfkfDZE/qcjnHfPuUpkg=;\n\tb=rMi5s+Cz90zK3QvIrClbZ/X8zm6VXK7n2cdIpIaIWx+wBigIHn/UcLRjuhWF63vWA+\n\t/G/Qg4xvj57sOayhLUyE24RbGpu4pOuTgZtiuwP6sTOjIj9mPN0VPm+yZCKogZrGRmI5\n\tU2KJbosYpuxuvAwkC8EG9q2HWG9JpLCCzCsqg5obhf0C2dO4BMHdt+WfYvVhOh5hVAIh\n\tWdUBKW4Kskv/KgdNy+KyWCXLba6xngQ2hQ1OiDGDZKnhpPxOLjpTtzLegCvLJ3nWfdbv\n\trhOYN6qq/c+uWngvNaV0kInipSYpioQ+KSORTnXnoSTzBfhFZRj+l9PaByOU8838ymHH\n\t+Jwg==", "X-Gm-Message-State": "AElRT7HiUP1N9Zg7T7KhxzvUWDBbHbJyb0QBWxM5f2PddJeINJwZ+lzk\n\t62uwMMjd+Anx3jUhVr+WK1dlqA==", "X-Google-Smtp-Source": "AIpwx4+ZldDEy+0gXFpVC6tm7+cHSibe4B1VKbYdKAX6zCEkSGpIRY8jIm5NP3tH/UPS06FyOJhTeA==", "X-Received": "by 2002:a19:17d4:: with SMTP id\n\t81-v6mr5472587lfx.22.1522335132606; \n\tThu, 29 Mar 2018 07:52:12 -0700 (PDT)", "From": "Serhey Popovych <serhe.popovych@gmail.com>", "To": "intel-wired-lan@osuosl.org", "Date": "Thu, 29 Mar 2018 17:51:36 +0300", "Message-Id": "<1522335096-11689-1-git-send-email-serhe.popovych@gmail.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[Intel-wired-lan] [PATCH next-queue] intel: correct return from set\n\tfeatures callback", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "According to comments in <linux/netdevice.h> we should return either >0\nor -errno from ->ndo_set_features() if changing dev->features by itself.\n\nReturn 1 in such places to notify netdev_update_features() about applied\nchanges in dev->features.\n\nSigned-off-by: Serhey Popovych <serhe.popovych@gmail.com>\n---\n drivers/net/ethernet/intel/e100.c | 2 +-\n drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n drivers/net/ethernet/intel/igb/igb_main.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n 5 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c\nindex 41ad56e..27fa59b 100644\n--- a/drivers/net/ethernet/intel/e100.c\n+++ b/drivers/net/ethernet/intel/e100.c\n@@ -2821,7 +2821,7 @@ static int e100_set_features(struct net_device *netdev,\n \n \tnetdev->features = features;\n \te100_exec_cb(nic, NULL, e100_configure);\n-\treturn 0;\n+\treturn 1;\n }\n \n static const struct net_device_ops e100_netdev_ops = {\ndiff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex d5eb19b..7068b82 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -846,7 +846,7 @@ static int e1000_set_features(struct net_device *netdev,\n \telse\n \t\te1000_reset(adapter);\n \n-\treturn 0;\n+\treturn 1;\n }\n \n static const struct net_device_ops e1000_netdev_ops = {\ndiff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex ec4a975..e4cd14d 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -7007,7 +7007,7 @@ static int e1000_set_features(struct net_device *netdev,\n \telse\n \t\te1000e_reset(adapter);\n \n-\treturn 0;\n+\treturn 1;\n }\n \n static const struct net_device_ops e1000e_netdev_ops = {\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex c1c0bc3..dbf9294 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2409,7 +2409,7 @@ static int igb_set_features(struct net_device *netdev,\n \telse\n \t\tigb_reset(adapter);\n \n-\treturn 0;\n+\treturn 1;\n }\n \n static int igb_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex afadba9..3b21eb6 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9530,7 +9530,7 @@ static int ixgbe_set_features(struct net_device *netdev,\n \t\t\t NETIF_F_HW_VLAN_CTAG_FILTER))\n \t\tixgbe_set_rx_mode(netdev);\n \n-\treturn 0;\n+\treturn 1;\n }\n \n /**\n", "prefixes": [ "next-queue" ] }