Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/891599/?format=api
{ "id": 891599, "url": "http://patchwork.ozlabs.org/api/patches/891599/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180327142148.13603-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180327142148.13603-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-03-27T14:21:48", "name": "[next] ixgbevf: ensure xdp_ring resources are free'd on error exit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "600e0f16e1c58a27d7e6dd36307439388a76dad5", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180327142148.13603-1-colin.king@canonical.com/mbox/", "series": [ { "id": 36052, "url": "http://patchwork.ozlabs.org/api/series/36052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=36052", "date": "2018-03-27T14:21:48", "name": "[next] ixgbevf: ensure xdp_ring resources are free'd on error exit", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/36052/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/891599/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/891599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 409Y9d1gK2z9s0m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Mar 2018 01:21:56 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 446EC87763;\n\tTue, 27 Mar 2018 14:21:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SbTaubgH2qnZ; Tue, 27 Mar 2018 14:21:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B289B876BD;\n\tTue, 27 Mar 2018 14:21:53 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0735E1C041E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Mar 2018 14:21:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 00C892E70B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Mar 2018 14:21:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ruVwyXBgp0mt for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Mar 2018 14:21:51 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5B7A722699\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Mar 2018 14:21:51 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1f0pTx-0006N7-3o; Tue, 27 Mar 2018 14:21:49 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Tue, 27 Mar 2018 15:21:48 +0100", "Message-Id": "<20180327142148.13603-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.15.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH][next] ixgbevf: ensure xdp_ring resources\n\tare free'd on error exit", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThe current error handling for failed resource setup for xdp_ring\ndata is a break out of the loop and returning 0 indicated everying\nwas OK, when in fact it is not. Fix this by exiting via the\nerror exit label err_setup_tx that will clean up the resources\ncorrectly and return and error status.\n\nDetected by CoverityScan, CID#1466879 (\"Logically dead code\")\n\nFixes: 21092e9ce8b1 (\"ixgbevf: Add support for XDP_TX action\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 3d9033f26eff..e3d04f226d57 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -3420,7 +3420,7 @@ static int ixgbevf_setup_all_tx_resources(struct ixgbevf_adapter *adapter)\n \t\tif (!err)\n \t\t\tcontinue;\n \t\thw_dbg(&adapter->hw, \"Allocation for XDP Queue %u failed\\n\", j);\n-\t\tbreak;\n+\t\tgoto err_setup_tx;\n \t}\n \n \treturn 0;\n", "prefixes": [ "next" ] }