Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/889173/?format=api
{ "id": 889173, "url": "http://patchwork.ozlabs.org/api/patches/889173/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180322003353.29970-6-vinicius.gomes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180322003353.29970-6-vinicius.gomes@intel.com>", "list_archive_url": null, "date": "2018-03-22T00:33:49", "name": "[next-queue,v5,5/9] igb: Add support for enabling queue steering in filters", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f7a783bcd6f7635c69617156f987d32a8af5ba17", "submitter": { "id": 72272, "url": "http://patchwork.ozlabs.org/api/people/72272/?format=api", "name": "Vinicius Costa Gomes", "email": "vinicius.gomes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180322003353.29970-6-vinicius.gomes@intel.com/mbox/", "series": [ { "id": 35168, "url": "http://patchwork.ozlabs.org/api/series/35168/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=35168", "date": "2018-03-22T00:33:44", "name": "igb: offloading of receive filters", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/35168/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/889173/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/889173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40673h0NqLz9s37\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Mar 2018 11:34:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1CA6A89CB8;\n\tThu, 22 Mar 2018 00:34:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zNQB9-tbfrKz; Thu, 22 Mar 2018 00:34:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5512C89C40;\n\tThu, 22 Mar 2018 00:34:53 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 852201C0AF7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 814A087BCB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HQdKbCKnz4rR for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:50 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id EEFB887C95\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:49 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Mar 2018 17:34:48 -0700", "from ellie.jf.intel.com (HELO localhost.localdomain)\n\t([10.54.70.23])\n\tby orsmga006.jf.intel.com with ESMTP; 21 Mar 2018 17:34:48 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,341,1517904000\"; d=\"scan'208\";a=\"27785568\"", "From": "Vinicius Costa Gomes <vinicius.gomes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 21 Mar 2018 17:33:49 -0700", "Message-Id": "<20180322003353.29970-6-vinicius.gomes@intel.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180322003353.29970-1-vinicius.gomes@intel.com>", "References": "<20180322003353.29970-1-vinicius.gomes@intel.com>", "Subject": "[Intel-wired-lan] [next-queue PATCH v5 5/9] igb: Add support for\n\tenabling queue steering in filters", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On some igb models (82575 and i210) the MAC address filters can\ncontrol to which queue the packet will be assigned.\n\nThis extends the 'state' with one more state to signify that queue\nselection should be enabled for that filter.\n\nAs 82575 parts are no longer easily obtained (and this was developed\nagainst i210), only support for the i210 model is enabled.\n\nThese functions are exported and will be used in the next patch.\n\nSigned-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>\n---\n drivers/net/ethernet/intel/igb/e1000_defines.h | 1 +\n drivers/net/ethernet/intel/igb/igb.h | 6 ++++++\n drivers/net/ethernet/intel/igb/igb_main.c | 26 ++++++++++++++++++++++++++\n 3 files changed, 33 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_defines.h b/drivers/net/ethernet/intel/igb/e1000_defines.h\nindex a3e5514b044e..c6f552de30dd 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_defines.h\n+++ b/drivers/net/ethernet/intel/igb/e1000_defines.h\n@@ -491,6 +491,7 @@\n */\n #define E1000_RAH_AV 0x80000000 /* Receive descriptor valid */\n #define E1000_RAH_ASEL_SRC_ADDR 0x00010000\n+#define E1000_RAH_QSEL_ENABLE 0x10000000\n #define E1000_RAL_MAC_ADDR_LEN 4\n #define E1000_RAH_MAC_ADDR_LEN 2\n #define E1000_RAH_POOL_MASK 0x03FC0000\ndiff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h\nindex 4501b28ff7c5..dfef1702ba21 100644\n--- a/drivers/net/ethernet/intel/igb/igb.h\n+++ b/drivers/net/ethernet/intel/igb/igb.h\n@@ -474,6 +474,7 @@ struct igb_mac_addr {\n #define IGB_MAC_STATE_DEFAULT\t0x1\n #define IGB_MAC_STATE_IN_USE\t0x2\n #define IGB_MAC_STATE_SRC_ADDR 0x4\n+#define IGB_MAC_STATE_QUEUE_STEERING 0x8\n \n /* board specific private data structure */\n struct igb_adapter {\n@@ -739,4 +740,9 @@ int igb_add_filter(struct igb_adapter *adapter,\n int igb_erase_filter(struct igb_adapter *adapter,\n \t\t struct igb_nfc_filter *input);\n \n+int igb_add_mac_steering_filter(struct igb_adapter *adapter,\n+\t\t\t\tconst u8 *addr, u8 queue, u8 flags);\n+int igb_del_mac_steering_filter(struct igb_adapter *adapter,\n+\t\t\t\tconst u8 *addr, u8 queue, u8 flags);\n+\n #endif /* _IGB_H_ */\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex a5a681f7fbb2..52cd891aa579 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -6934,6 +6934,28 @@ static int igb_del_mac_filter(struct igb_adapter *adapter, const u8 *addr,\n \treturn igb_del_mac_filter_flags(adapter, addr, queue, 0);\n }\n \n+int igb_add_mac_steering_filter(struct igb_adapter *adapter,\n+\t\t\t\tconst u8 *addr, u8 queue, u8 flags)\n+{\n+\tstruct e1000_hw *hw = &adapter->hw;\n+\n+\t/* In theory, this should be supported on 82575 as well, but\n+\t * that part wasn't easily accessible during development.\n+\t */\n+\tif (hw->mac.type != e1000_i210)\n+\t\treturn -EOPNOTSUPP;\n+\n+\treturn igb_add_mac_filter_flags(adapter, addr, queue,\n+\t\t\t\t\tIGB_MAC_STATE_QUEUE_STEERING | flags);\n+}\n+\n+int igb_del_mac_steering_filter(struct igb_adapter *adapter,\n+\t\t\t\tconst u8 *addr, u8 queue, u8 flags)\n+{\n+\treturn igb_del_mac_filter_flags(adapter, addr, queue,\n+\t\t\t\t\tIGB_MAC_STATE_QUEUE_STEERING | flags);\n+}\n+\n static int igb_uc_sync(struct net_device *netdev, const unsigned char *addr)\n {\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\n@@ -8783,6 +8805,10 @@ static void igb_rar_set_index(struct igb_adapter *adapter, u32 index)\n \t\tswitch (hw->mac.type) {\n \t\tcase e1000_82575:\n \t\tcase e1000_i210:\n+\t\t\tif (adapter->mac_table[index].state &\n+\t\t\t IGB_MAC_STATE_QUEUE_STEERING)\n+\t\t\t\trar_high |= E1000_RAH_QSEL_ENABLE;\n+\n \t\t\trar_high |= E1000_RAH_POOL_1 *\n \t\t\t\t adapter->mac_table[index].queue;\n \t\t\tbreak;\n", "prefixes": [ "next-queue", "v5", "5/9" ] }