Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/889172/?format=api
{ "id": 889172, "url": "http://patchwork.ozlabs.org/api/patches/889172/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180322003353.29970-3-vinicius.gomes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180322003353.29970-3-vinicius.gomes@intel.com>", "list_archive_url": null, "date": "2018-03-22T00:33:46", "name": "[next-queue,v5,2/9] igb: Fix queue selection on MAC filters on i210", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "18f5b0665e93d43fb4f2649e901c02dff864dd0f", "submitter": { "id": 72272, "url": "http://patchwork.ozlabs.org/api/people/72272/?format=api", "name": "Vinicius Costa Gomes", "email": "vinicius.gomes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180322003353.29970-3-vinicius.gomes@intel.com/mbox/", "series": [ { "id": 35168, "url": "http://patchwork.ozlabs.org/api/series/35168/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=35168", "date": "2018-03-22T00:33:44", "name": "igb: offloading of receive filters", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/35168/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/889172/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/889172/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40673g6kJVz9s3D\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Mar 2018 11:34:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F3E018905E;\n\tThu, 22 Mar 2018 00:34:53 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AYq2CG4L9aH1; Thu, 22 Mar 2018 00:34:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CBC2989025;\n\tThu, 22 Mar 2018 00:34:52 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 277241C0AF7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 23A8487C7D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SWB-Pks2PY_X for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:49 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id AD82D87C71\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Mar 2018 00:34:49 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Mar 2018 17:34:48 -0700", "from ellie.jf.intel.com (HELO localhost.localdomain)\n\t([10.54.70.23])\n\tby orsmga006.jf.intel.com with ESMTP; 21 Mar 2018 17:34:48 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,341,1517904000\"; d=\"scan'208\";a=\"27785559\"", "From": "Vinicius Costa Gomes <vinicius.gomes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 21 Mar 2018 17:33:46 -0700", "Message-Id": "<20180322003353.29970-3-vinicius.gomes@intel.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180322003353.29970-1-vinicius.gomes@intel.com>", "References": "<20180322003353.29970-1-vinicius.gomes@intel.com>", "Subject": "[Intel-wired-lan] [next-queue PATCH v5 2/9] igb: Fix queue\n\tselection on MAC filters on i210", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On the RAH registers there are semantic differences on the meaning of\nthe \"queue\" parameter for traffic steering depending on the controller\nmodel: there is the 82575 meaning, which \"queue\" means a RX Hardware\nQueue, and the i350 meaning, where it is a reception pool.\n\nThe previous behaviour was having no effect for i210 based controllers\nbecause the QSEL bit of the RAH register wasn't being set.\n\nThis patch separates the condition in discrete cases, so the different\nhandling is clearer.\n\nFixes: 83c21335c876 (\"igb: improve MAC filter handling\")\nSigned-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 715bb32e6901..d0e8e796c6fa 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -8747,12 +8747,17 @@ static void igb_rar_set_index(struct igb_adapter *adapter, u32 index)\n \t\tif (is_valid_ether_addr(addr))\n \t\t\trar_high |= E1000_RAH_AV;\n \n-\t\tif (hw->mac.type == e1000_82575)\n+\t\tswitch (hw->mac.type) {\n+\t\tcase e1000_82575:\n+\t\tcase e1000_i210:\n \t\t\trar_high |= E1000_RAH_POOL_1 *\n-\t\t\t\t adapter->mac_table[index].queue;\n-\t\telse\n+\t\t\t\t adapter->mac_table[index].queue;\n+\t\t\tbreak;\n+\t\tdefault:\n \t\t\trar_high |= E1000_RAH_POOL_1 <<\n-\t\t\t\t adapter->mac_table[index].queue;\n+\t\t\t\tadapter->mac_table[index].queue;\n+\t\t\tbreak;\n+\t\t}\n \t}\n \n \twr32(E1000_RAL(index), rar_low);\n", "prefixes": [ "next-queue", "v5", "2/9" ] }