Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/889015/?format=api
{ "id": 889015, "url": "http://patchwork.ozlabs.org/api/patches/889015/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521658572-26354-6-git-send-email-okaya@codeaurora.org/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1521658572-26354-6-git-send-email-okaya@codeaurora.org>", "list_archive_url": null, "date": "2018-03-21T18:56:09", "name": "[REPOST,v4,5/7] ixgbevf: keep writel() closer to wmb()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f6cd088fe2811803f0f65e81a3556201f1a0ccd7", "submitter": { "id": 67496, "url": "http://patchwork.ozlabs.org/api/people/67496/?format=api", "name": "Sinan Kaya", "email": "okaya@codeaurora.org" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521658572-26354-6-git-send-email-okaya@codeaurora.org/mbox/", "series": [ { "id": 35128, "url": "http://patchwork.ozlabs.org/api/series/35128/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=35128", "date": "2018-03-21T18:56:05", "name": "[REPOST,v4,1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/35128/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/889015/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/889015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=codeaurora.org", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"VJi5Q7cD\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"bxuDbobN\"; dkim-atps=neutral", "pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org", "pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 405zYG37RDz9s1P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Mar 2018 05:56:34 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D56C187CF6;\n\tWed, 21 Mar 2018 18:56:32 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id U8Uc7N7-XBIg; Wed, 21 Mar 2018 18:56:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 64BEF87CB1;\n\tWed, 21 Mar 2018 18:56:31 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 939931C005F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 90C2F89F3B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:29 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DWM-9AhwnZGR for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:29 +0000 (UTC)", "from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 3FA3689F41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:29 +0000 (UTC)", "by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid B7D4760F78; Wed, 21 Mar 2018 18:56:28 +0000 (UTC)", "from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com\n\t[129.46.232.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 1E81360C55;\n\tWed, 21 Mar 2018 18:56:26 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1521658589;\n\tbh=/dk6LFTwdGuq2DfBfF7yg7MAPz5m1QtQ1ahc8Y6Agf8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VJi5Q7cDCHj0WA5V3w4qn/K8CSBE0sV5uCcXe19+MxTW4vZTnvHMGmvYzH4plcEoq\n\tLtTs6uh1xuyJANxeMNgG2kyKU8Gu/mJSz1YxQ4mhrT3EBHxHOltKJZfxrhITMRUEwl\n\toy4ARCNQQgV2U+L2Su08mtVJDnizlGxuku5KUSaA=", "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1521658587;\n\tbh=/dk6LFTwdGuq2DfBfF7yg7MAPz5m1QtQ1ahc8Y6Agf8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bxuDbobNqpgPAtje1kKJQz6dBdsouUQhSnV1mrjd5/koSKPfjRaZzPB132yVVtRQN\n\t5OQIJdsTsFOW02eJ2KTEYubz1xyGmtlsuRX7Ox7OnxZkw9G91gDCln9ZYKO1kO4fKC\n\tIerNJs0dTLA8//hzvrNYN6LkNOiUT0mLFRMEQFoc=" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1E81360C55", "From": "Sinan Kaya <okaya@codeaurora.org>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Wed, 21 Mar 2018 14:56:09 -0400", "Message-Id": "<1521658572-26354-6-git-send-email-okaya@codeaurora.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1521658572-26354-1-git-send-email-okaya@codeaurora.org>", "References": "<1521658572-26354-1-git-send-email-okaya@codeaurora.org>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH REPOST v4 5/7] ixgbevf: keep writel()\n\tcloser to wmb()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org,\n\tlinux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,\n\tintel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Remove ixgbevf_write_tail() in favor of moving writel() close to\nwmb().\n\nSigned-off-by: Sinan Kaya <okaya@codeaurora.org>\nReviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 -----\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--\n 2 files changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\nindex f695242..11e893e 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n@@ -244,11 +244,6 @@ static inline u16 ixgbevf_desc_unused(struct ixgbevf_ring *ring)\n \treturn ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1;\n }\n \n-static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value)\n-{\n-\twritel(value, ring->tail);\n-}\n-\n #define IXGBEVF_RX_DESC(R, i)\t\\\n \t(&(((union ixgbe_adv_rx_desc *)((R)->desc))[i]))\n #define IXGBEVF_TX_DESC(R, i)\t\\\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 9b3d43d..6bf778a 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,\n \t\t * such as IA-64).\n \t\t */\n \t\twmb();\n-\t\tixgbevf_write_tail(rx_ring, i);\n+\t\twritel(i, rx_ring->tail);\n \t}\n }\n \n@@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring,\n \ttx_ring->next_to_use = i;\n \n \t/* notify HW of packet */\n-\tixgbevf_write_tail(tx_ring, i);\n+\twritel(i, tx_ring->tail);\n \n \treturn;\n dma_error:\n", "prefixes": [ "REPOST", "v4", "5/7" ] }