Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/889012/?format=api
{ "id": 889012, "url": "http://patchwork.ozlabs.org/api/patches/889012/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521658572-26354-5-git-send-email-okaya@codeaurora.org/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1521658572-26354-5-git-send-email-okaya@codeaurora.org>", "list_archive_url": null, "date": "2018-03-21T18:56:08", "name": "[REPOST,v4,4/7] igb: eliminate duplicate barriers on weakly-ordered archs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "00021aec7f492a84afc0583b35e332d850fd2580", "submitter": { "id": 67496, "url": "http://patchwork.ozlabs.org/api/people/67496/?format=api", "name": "Sinan Kaya", "email": "okaya@codeaurora.org" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521658572-26354-5-git-send-email-okaya@codeaurora.org/mbox/", "series": [ { "id": 35128, "url": "http://patchwork.ozlabs.org/api/series/35128/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=35128", "date": "2018-03-21T18:56:05", "name": "[REPOST,v4,1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/35128/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/889012/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/889012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=codeaurora.org", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"bNMX1ku5\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"ENdnE0fC\"; dkim-atps=neutral", "pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org", "pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 405zYD2xLdz9s0t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Mar 2018 05:56:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CD6FA2F020;\n\tWed, 21 Mar 2018 18:56:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id r9qJcpsMTraJ; Wed, 21 Mar 2018 18:56:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 25FF92E949;\n\tWed, 21 Mar 2018 18:56:30 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8B9A51C005F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 886DD2288C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:26 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id a3RL82BEmBmY for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:26 +0000 (UTC)", "from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 21C362ECD1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 21 Mar 2018 18:56:26 +0000 (UTC)", "by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid F04F660F90; Wed, 21 Mar 2018 18:56:25 +0000 (UTC)", "from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com\n\t[129.46.232.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 487FB60817;\n\tWed, 21 Mar 2018 18:56:24 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1521658586;\n\tbh=+bI0tm8bhHIDFysh3wegWVamtyhDD/7eP9KsoC1eST4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bNMX1ku5ZaXVlbOvckRNLUK4Jia34vv5PJxBMuZFokPTtEYkEUQ0FdY0h08vtkH2I\n\tbJRxmE3lqxqAIKK28bFuf1c79fdT38IjLCwITU+mgy0oH60rH5+b9ZmJF7NoNGuUQo\n\taNXNyAEy5kG0QyODvr945jZNl8DLsY/Uw9b0coac=", "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1521658585;\n\tbh=+bI0tm8bhHIDFysh3wegWVamtyhDD/7eP9KsoC1eST4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ENdnE0fCmFZFjAkM0ZUZZ8ZoTXek0KCPaVsvOrl3FSBWEV27vaoRgsm6k+fyC7tfU\n\tjKZbSIdufKsmHhIXFGFsrc+6BqxteS1vS6ko/VRC013A1m2yzOlXBwL6ifu3Ppi0Gg\n\t7T0nXmc/9Qy2FUoIPUa2uzGukqeZf+Owq0inWnHg=" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 smtp.codeaurora.org 487FB60817", "From": "Sinan Kaya <okaya@codeaurora.org>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Wed, 21 Mar 2018 14:56:08 -0400", "Message-Id": "<1521658572-26354-5-git-send-email-okaya@codeaurora.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1521658572-26354-1-git-send-email-okaya@codeaurora.org>", "References": "<1521658572-26354-1-git-send-email-okaya@codeaurora.org>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH REPOST v4 4/7] igb: eliminate duplicate\n\tbarriers on weakly-ordered archs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org,\n\tlinux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,\n\tintel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Code includes wmb() followed by writel(). writel() already has a barrier\non some architectures like arm64.\n\nThis ends up CPU observing two barriers back to back before executing the\nregister write.\n\nSince code already has an explicit barrier call, changing writel() to\nwritel_relaxed().\n\nSigned-off-by: Sinan Kaya <okaya@codeaurora.org>\nReviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex b88fae7..82aea92 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5671,7 +5671,7 @@ static int igb_tx_map(struct igb_ring *tx_ring,\n \tigb_maybe_stop_tx(tx_ring, DESC_NEEDED);\n \n \tif (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {\n-\t\twritel(i, tx_ring->tail);\n+\t\twritel_relaxed(i, tx_ring->tail);\n \n \t\t/* we need this if more than one processor can write to our tail\n \t\t * at a time, it synchronizes IO on IA64/Altix systems\n@@ -8072,7 +8072,7 @@ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count)\n \t\t * such as IA-64).\n \t\t */\n \t\twmb();\n-\t\twritel(i, rx_ring->tail);\n+\t\twritel_relaxed(i, rx_ring->tail);\n \t}\n }\n \n", "prefixes": [ "REPOST", "v4", "4/7" ] }