Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/886995/?format=api
{ "id": 886995, "url": "http://patchwork.ozlabs.org/api/patches/886995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180316082637.49915-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180316082637.49915-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-03-16T08:26:30", "name": "[next,S89,1/8] i40e: move I40E_FLAG_FILTER_SYNC to a state bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a2d6a3fc9bd1b94e27e0d851699d832ba44448a1", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180316082637.49915-1-alice.michael@intel.com/mbox/", "series": [ { "id": 34226, "url": "http://patchwork.ozlabs.org/api/series/34226/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=34226", "date": "2018-03-16T08:26:33", "name": "[next,S89,1/8] i40e: move I40E_FLAG_FILTER_SYNC to a state bit", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/34226/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/886995/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/886995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 402rfC3jMwz9sNq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 17 Mar 2018 03:34:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 97F7A89881;\n\tFri, 16 Mar 2018 16:34:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id F2hslhhtRSDh; Fri, 16 Mar 2018 16:34:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3D028896CA;\n\tFri, 16 Mar 2018 16:34:55 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 273A41C1011\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Mar 2018 16:34:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 23FD42275B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Mar 2018 16:34:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1VIy14v2p7lM for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Mar 2018 16:34:52 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 2219D220CD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 16 Mar 2018 16:34:52 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Mar 2018 09:34:47 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga008.fm.intel.com with ESMTP; 16 Mar 2018 09:34:46 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,316,1517904000\"; d=\"scan'208\";a=\"25113526\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 16 Mar 2018 01:26:30 -0700", "Message-Id": "<20180316082637.49915-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S89 1/8] i40e: move\n\tI40E_FLAG_FILTER_SYNC to a state bit", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe I40E_FLAG_FILTER_SYNC flag is modified during run time possibly when\nthe RTNL lock is not held. Thus, it should not be part of pf->flags, and\ninstead should be using atomic bit operations in the pf->state field.\n\nCreate a __I40E_MACVLAN_SYNC_PENDING state bit, and use it instead of\nthe old I40E_FLAG_FILTER_SYNC flag.\n\nThis is part of a larger effort to remove the need for cmpxchg64 in\ni40e_set_priv_flags().\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 3 ++-\n drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++++++++-------\n 2 files changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 1e1cd52..e83fb37 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -162,6 +162,7 @@ enum i40e_state_t {\n \t__I40E_RESET_FAILED,\n \t__I40E_PORT_SUSPENDED,\n \t__I40E_VF_DISABLE,\n+\t__I40E_MACVLAN_SYNC_PENDING,\n \t/* This must be last as it determines the size of the BITMAP */\n \t__I40E_STATE_SIZE__,\n };\n@@ -516,7 +517,7 @@ struct i40e_pf {\n #define I40E_FLAG_MSIX_ENABLED\t\t\tBIT_ULL(2)\n #define I40E_FLAG_RSS_ENABLED\t\t\tBIT_ULL(3)\n #define I40E_FLAG_VMDQ_ENABLED\t\t\tBIT_ULL(4)\n-#define I40E_FLAG_FILTER_SYNC\t\t\tBIT_ULL(5)\n+/* Gap for BIT_ULL(5) */\n #define I40E_FLAG_SRIOV_ENABLED\t\t\tBIT_ULL(6)\n #define I40E_FLAG_DCB_CAPABLE\t\t\tBIT_ULL(7)\n #define I40E_FLAG_DCB_ENABLED\t\t\tBIT_ULL(8)\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 5a77dbf..e96c22a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1382,7 +1382,7 @@ struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,\n \t\thash_add(vsi->mac_filter_hash, &f->hlist, key);\n \n \t\tvsi->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n-\t\tvsi->back->flags |= I40E_FLAG_FILTER_SYNC;\n+\t\tset_bit(__I40E_MACVLAN_SYNC_PENDING, vsi->back->state);\n \t}\n \n \t/* If we're asked to add a filter that has been marked for removal, it\n@@ -1432,7 +1432,7 @@ void __i40e_del_filter(struct i40e_vsi *vsi, struct i40e_mac_filter *f)\n \t}\n \n \tvsi->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n-\tvsi->back->flags |= I40E_FLAG_FILTER_SYNC;\n+\tset_bit(__I40E_MACVLAN_SYNC_PENDING, vsi->state);\n }\n \n /**\n@@ -1955,7 +1955,7 @@ static void i40e_set_rx_mode(struct net_device *netdev)\n \t/* check for other flag changes */\n \tif (vsi->current_netdev_flags != vsi->netdev->flags) {\n \t\tvsi->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n-\t\tvsi->back->flags |= I40E_FLAG_FILTER_SYNC;\n+\t\tset_bit(__I40E_MACVLAN_SYNC_PENDING, vsi->back->state);\n \t}\n }\n \n@@ -2577,9 +2577,10 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf)\n {\n \tint v;\n \n-\tif (!pf || !(pf->flags & I40E_FLAG_FILTER_SYNC))\n+\tif (!pf)\n+\t\treturn;\n+\tif (!test_and_clear_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state))\n \t\treturn;\n-\tpf->flags &= ~I40E_FLAG_FILTER_SYNC;\n \n \tfor (v = 0; v < pf->num_alloc_vsi; v++) {\n \t\tif (pf->vsi[v] &&\n@@ -2588,7 +2589,8 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf)\n \n \t\t\tif (ret) {\n \t\t\t\t/* come back and try again later */\n-\t\t\t\tpf->flags |= I40E_FLAG_FILTER_SYNC;\n+\t\t\t\tset_bit(__I40E_MACVLAN_SYNC_PENDING,\n+\t\t\t\t\tpf->state);\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n@@ -12240,7 +12242,7 @@ static int i40e_add_vsi(struct i40e_vsi *vsi)\n \n \tif (f_count) {\n \t\tvsi->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n-\t\tpf->flags |= I40E_FLAG_FILTER_SYNC;\n+\t\tset_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state);\n \t}\n \n \t/* Update VSI BW information */\n", "prefixes": [ "next", "S89", "1/8" ] }