Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/886476/?format=api
{ "id": 886476, "url": "http://patchwork.ozlabs.org/api/patches/886476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521116527-49781-1-git-send-email-paul.greenwalt@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1521116527-49781-1-git-send-email-paul.greenwalt@intel.com>", "list_archive_url": null, "date": "2018-03-15T12:22:07", "name": "ixgbe: fix read-modify-write in x550 phy setup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f4205f861f0366dd08b0997e4938ff7489520605", "submitter": { "id": 71166, "url": "http://patchwork.ozlabs.org/api/people/71166/?format=api", "name": "Paul Greenwalt", "email": "paul.greenwalt@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521116527-49781-1-git-send-email-paul.greenwalt@intel.com/mbox/", "series": [ { "id": 34076, "url": "http://patchwork.ozlabs.org/api/series/34076/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=34076", "date": "2018-03-15T12:22:07", "name": "ixgbe: fix read-modify-write in x550 phy setup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/34076/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/886476/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/886476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 402MKf3lgpz9sVZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Mar 2018 08:33:58 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7B14E30183;\n\tThu, 15 Mar 2018 21:33:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bBrh1lqLVers; Thu, 15 Mar 2018 21:33:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9E63C226CC;\n\tThu, 15 Mar 2018 21:33:55 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E023D1C008D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:33:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DCECE226CC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:33:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gVTZRipoutLX for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:33:53 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 22C22221D5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:33:53 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Mar 2018 14:33:48 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.74])\n\tby fmsmga008.fm.intel.com with ESMTP; 15 Mar 2018 14:33:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,312,1517904000\"; d=\"scan'208\";a=\"24897187\"", "From": "Paul Greenwalt <paul.greenwalt@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 15 Mar 2018 08:22:07 -0400", "Message-Id": "<1521116527-49781-1-git-send-email-paul.greenwalt@intel.com>", "X-Mailer": "git-send-email 2.7.5", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: fix read-modify-write in x550 phy\n\tsetup", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Replaced an assignment operation with an OR operation.\n\nThe variable assignment was overwriting the value read from the PHY\nregister. The OR operation sets only the intended register bits.\n\nThe bits that were being overwritten are reserved, so the assignment had no\nfunctional impact.\n\nReported by: Shannon Nelson <shannon.nelson@oracle.com>\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex f470d02..3123267 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1847,9 +1847,9 @@ ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw, ixgbe_link_speed speed,\n \t\t\t (IXGBE_CS4227_EDC_MODE_SR << 1));\n \n \tif (setup_linear)\n-\t\treg_phy_ext = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 1;\n+\t\treg_phy_ext |= (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 1;\n \telse\n-\t\treg_phy_ext = (IXGBE_CS4227_EDC_MODE_SR << 1) | 1;\n+\t\treg_phy_ext |= (IXGBE_CS4227_EDC_MODE_SR << 1) | 1;\n \n \tret_val = hw->phy.ops.write_reg(hw, reg_slice,\n \t\t\t\t\tIXGBE_MDIO_ZERO_DEV_TYPE, reg_phy_ext);\n", "prefixes": [] }