Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/886466/?format=api
{ "id": 886466, "url": "http://patchwork.ozlabs.org/api/patches/886466/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521149003-1433-2-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1521149003-1433-2-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-03-15T21:23:20", "name": "[next-queue,1/4] ixgbe: no need for ipsec csum feature check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ffa488938fcad75f4a50a7bd52089de1ad33cf2f", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521149003-1433-2-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 34073, "url": "http://patchwork.ozlabs.org/api/series/34073/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=34073", "date": "2018-03-15T21:23:19", "name": "ixgbe: Enable tso and checksum offload with ipsec", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/34073/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/886466/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/886466/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"ZAnhiYKU\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 402M5s2zFwz9sVY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Mar 2018 08:23:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8E15D8A29E;\n\tThu, 15 Mar 2018 21:23:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hTNI5Obvtvm9; Thu, 15 Mar 2018 21:23:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D9DE68A29C;\n\tThu, 15 Mar 2018 21:23:40 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9FDC01C033D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9D4932265F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iPAvlbTFF0uA for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:38 +0000 (UTC)", "from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E0816221D5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:37 +0000 (UTC)", "from pps.filterd (aserp2120.oracle.com [127.0.0.1])\n\tby aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw2FKW8kt086562; Thu, 15 Mar 2018 21:23:37 GMT", "from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby aserp2120.oracle.com with ESMTP id 2gqyxx86jm-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 15 Mar 2018 21:23:36 +0000", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw2FLNatZ026836\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 15 Mar 2018 21:23:36 GMT", "from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw2FLNYjK028285; Thu, 15 Mar 2018 21:23:35 GMT", "from slnelson-mint18.us.oracle.com (/10.159.152.19)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 15 Mar 2018 14:23:34 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references;\n\ts=corp-2017-10-26; \n\tbh=t4ftLzfvQNHJuQpGRJ8ObV7jsh+BuDANhdrXdqrBKa0=;\n\tb=ZAnhiYKUJzxXZoRPdnOzPYr1L3R9Yiw6rUByafENODeVYfRJocbUJwCI5Vb20Tk5FxyN\n\t1/bk/zTrhWOjJXNsKkL6Of1J6liTamxesBd07YcidBvFB05DNg/1etiGLMqYXiOSf2hs\n\t7EYuAhraQnQpG7XXXWzV/yGGYykUdMMPXU3n1SUmR4NddWKudwRAurwMRx2kISiImbDl\n\tmvx++lI2vyb9Zv8RkN96mFzfzYjjQEd5A0GUbt41CrAa7QlAa5HbUDrhRh9hWwqKoaBf\n\tA2fGvMkmbVklAs4L28f6IzGkGpK3rfUrYXN/wsNwqDDmiY2OiYFVj4MdjOdKNWLKe4tA\n\tQg== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 15 Mar 2018 14:23:20 -0700", "Message-Id": "<1521149003-1433-2-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1521149003-1433-1-git-send-email-shannon.nelson@oracle.com>", "References": "<1521149003-1433-1-git-send-email-shannon.nelson@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8832\n\tsignatures=668690", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=1\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=699\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1803150169", "Subject": "[Intel-wired-lan] [next-queue 1/4] ixgbe: no need for ipsec csum\n\tfeature check", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "steffen.klassert@secunet.com, netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "With the patch\ncommit f8aa2696b4af (\"esp: check the NETIF_F_HW_ESP_TX_CSUM bit before segmenting\")\nwe no longer need to protect ourself from checksum\noffload requests on IPsec packets, so we can remove\nthe check in our .ndo_features_check callback.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 8536942..153cd9e 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9908,12 +9908,6 @@ ixgbe_features_check(struct sk_buff *skb, struct net_device *dev,\n \tif (skb->encapsulation && !(features & NETIF_F_TSO_MANGLEID))\n \t\tfeatures &= ~NETIF_F_TSO;\n \n-#ifdef CONFIG_XFRM_OFFLOAD\n-\t/* IPsec offload doesn't get along well with others *yet* */\n-\tif (skb->sp)\n-\t\tfeatures &= ~(NETIF_F_TSO | NETIF_F_HW_CSUM);\n-#endif\n-\n \treturn features;\n }\n \n", "prefixes": [ "next-queue", "1/4" ] }