Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/886464/?format=api
{ "id": 886464, "url": "http://patchwork.ozlabs.org/api/patches/886464/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521149003-1433-4-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1521149003-1433-4-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-03-15T21:23:22", "name": "[next-queue,3/4] ixgbe: no need for esp trailer if gso", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "92a65661b3b8e6389fe43013bf724c83ec7271e9", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1521149003-1433-4-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 34073, "url": "http://patchwork.ozlabs.org/api/series/34073/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=34073", "date": "2018-03-15T21:23:19", "name": "ixgbe: Enable tso and checksum offload with ipsec", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/34073/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/886464/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/886464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"uuwdgbRv\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 402M5q3yTsz9sMl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Mar 2018 08:23:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 20A4988259;\n\tThu, 15 Mar 2018 21:23:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1H8z3KmKGgVt; Thu, 15 Mar 2018 21:23:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1C9AB88282;\n\tThu, 15 Mar 2018 21:23:41 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 06F931CF04F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 03A16890A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:39 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u1dM1ssEOFwN for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:38 +0000 (UTC)", "from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 0EE7889077\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Mar 2018 21:23:37 +0000 (UTC)", "from pps.filterd (aserp2120.oracle.com [127.0.0.1])\n\tby aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw2FKWHX4086631; Thu, 15 Mar 2018 21:23:37 GMT", "from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp2120.oracle.com with ESMTP id 2gqyxx86jn-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 15 Mar 2018 21:23:36 +0000", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw2FLNaiG032185\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 15 Mar 2018 21:23:36 GMT", "from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw2FLNZeq028298; Thu, 15 Mar 2018 21:23:36 GMT", "from slnelson-mint18.us.oracle.com (/10.159.152.19)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 15 Mar 2018 14:23:35 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references;\n\ts=corp-2017-10-26; \n\tbh=PvI25boyxARNiomlD1ZYdGh2KFxQOqWEnNIsAf4wizc=;\n\tb=uuwdgbRvE87O/ZdOD03RlY2iU9q9P2ubgKvP4Dh01htjEaYByPmFSm7ESOjoFiIb+QtY\n\thzFjVwY+IagU0c+TjkcHIfNKbRm4CHdCgkLRsA+l0ccH9lNVUwcGI4ZFJUIN7HksAiSm\n\ttdQPcQi+aUZQPsHm48r9RqqWBKVZ+rIidGaMpQ1ly/pL68rxZ26CaXIuNZyZKyHY1VBY\n\tBz+391oBgoRGshXZflda4jlDUZcvlxMjY0WdCjtCtdjpS0GiXTVFfcTQ/30tRpl+pHFO\n\tmTyblsjKyFt/ncqE+AL695xaBokEACOg/I4+FXG+TJv9n8ot2linZ1gd5+RqjuHCllqm\n\tCA== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 15 Mar 2018 14:23:22 -0700", "Message-Id": "<1521149003-1433-4-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1521149003-1433-1-git-send-email-shannon.nelson@oracle.com>", "References": "<1521149003-1433-1-git-send-email-shannon.nelson@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8832\n\tsignatures=668690", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=1\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1803150169", "Subject": "[Intel-wired-lan] [next-queue 3/4] ixgbe: no need for esp trailer\n\tif gso", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "steffen.klassert@secunet.com, netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "There is no need to calculate the trailer length if we're doing\na GSO/TSO, as there is no trailer added to the packet data.\nAlso, don't bother clearing the flags field as it was already\ncleared earlier.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 37 +++++++++++++++-----------\n 1 file changed, 21 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex f225452..5ddea43 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -774,11 +774,7 @@ int ixgbe_ipsec_tx(struct ixgbe_ring *tx_ring,\n \n \tfirst->tx_flags |= IXGBE_TX_FLAGS_IPSEC | IXGBE_TX_FLAGS_CC;\n \n-\titd->flags = 0;\n \tif (xs->id.proto == IPPROTO_ESP) {\n-\t\tstruct sk_buff *skb = first->skb;\n-\t\tint ret, authlen, trailerlen;\n-\t\tu8 padlen;\n \n \t\titd->flags |= IXGBE_ADVTXD_TUCMD_IPSEC_TYPE_ESP |\n \t\t\t IXGBE_ADVTXD_TUCMD_L4T_TCP;\n@@ -790,19 +786,28 @@ int ixgbe_ipsec_tx(struct ixgbe_ring *tx_ring,\n \t\t * padlen bytes of padding. This ends up not the same\n \t\t * as the static value found in xs->props.trailer_len (21).\n \t\t *\n-\t\t * The \"correct\" way to get the auth length would be to use\n-\t\t * authlen = crypto_aead_authsize(xs->data);\n-\t\t * but since we know we only have one size to worry about\n-\t\t * we can let the compiler use the constant and save us a\n-\t\t * few CPU cycles.\n+\t\t * ... but if we're doing GSO, don't bother as the stack\n+\t\t * doesn't add a trailer for those.\n \t\t */\n-\t\tauthlen = IXGBE_IPSEC_AUTH_BITS / 8;\n-\n-\t\tret = skb_copy_bits(skb, skb->len - (authlen + 2), &padlen, 1);\n-\t\tif (unlikely(ret))\n-\t\t\treturn 0;\n-\t\ttrailerlen = authlen + 2 + padlen;\n-\t\titd->trailer_len = trailerlen;\n+\t\tif (!skb_is_gso(first->skb)) {\n+\t\t\t/* The \"correct\" way to get the auth length would be\n+\t\t\t * to use\n+\t\t\t * authlen = crypto_aead_authsize(xs->data);\n+\t\t\t * but since we know we only have one size to worry\n+\t\t\t * about * we can let the compiler use the constant\n+\t\t\t * and save us a few CPU cycles.\n+\t\t\t */\n+\t\t\tconst int authlen = IXGBE_IPSEC_AUTH_BITS / 8;\n+\t\t\tstruct sk_buff *skb = first->skb;\n+\t\t\tu8 padlen;\n+\t\t\tint ret;\n+\n+\t\t\tret = skb_copy_bits(skb, skb->len - (authlen + 2),\n+\t\t\t\t\t &padlen, 1);\n+\t\t\tif (unlikely(ret))\n+\t\t\t\treturn 0;\n+\t\t\titd->trailer_len = authlen + 2 + padlen;\n+\t\t}\n \t}\n \tif (tsa->encrypt)\n \t\titd->flags |= IXGBE_ADVTXD_TUCMD_IPSEC_ENCRYPT_EN;\n", "prefixes": [ "next-queue", "3/4" ] }