Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/885629/?format=api
{ "id": 885629, "url": "http://patchwork.ozlabs.org/api/patches/885629/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20180314071312.17492-1-joel@jms.id.au/", "project": { "id": 57, "url": "http://patchwork.ozlabs.org/api/projects/57/?format=api", "name": "Linux ASPEED SoC development", "link_name": "linux-aspeed", "list_id": "linux-aspeed.lists.ozlabs.org", "list_email": "linux-aspeed@lists.ozlabs.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180314071312.17492-1-joel@jms.id.au>", "list_archive_url": null, "date": "2018-03-14T07:13:12", "name": "ARM: dts: aspeed: Add default memory node", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "63913a1b087a433ed146da6928bf777e19a46659", "submitter": { "id": 48628, "url": "http://patchwork.ozlabs.org/api/people/48628/?format=api", "name": "Joel Stanley", "email": "joel@jms.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20180314071312.17492-1-joel@jms.id.au/mbox/", "series": [ { "id": 33653, "url": "http://patchwork.ozlabs.org/api/series/33653/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/list/?series=33653", "date": "2018-03-14T07:13:12", "name": "ARM: dts: aspeed: Add default memory node", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/33653/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/885629/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/885629/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 401NHM6tYCz9sV3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 14 Mar 2018 18:13:35 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 401NHM5CdXzF0xw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 14 Mar 2018 18:13:35 +1100 (AEDT)", "from mail-pg0-x241.google.com (mail-pg0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c05::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 401NHH1g3rzF0vb\n\tfor <linux-aspeed@lists.ozlabs.org>;\n\tWed, 14 Mar 2018 18:13:30 +1100 (AEDT)", "by mail-pg0-x241.google.com with SMTP id m15so1014987pgc.1\n\tfor <linux-aspeed@lists.ozlabs.org>;\n\tWed, 14 Mar 2018 00:13:30 -0700 (PDT)", "from aurora.jms.id.au ([203.0.153.9])\n\tby smtp.gmail.com with ESMTPSA id\n\t5sm3963615pfh.133.2018.03.14.00.13.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 14 Mar 2018 00:13:27 -0700 (PDT)", "by aurora.jms.id.au (sSMTP sendmail emulation);\n\tWed, 14 Mar 2018 17:43:20 +1030" ], "Authentication-Results": [ "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=jms.id.au", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P6AVzKH/\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=jms.id.au", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P6AVzKH/\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::241; helo=mail-pg0-x241.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=<UNKNOWN>)", "lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=jms.id.au", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P6AVzKH/\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=GFXm3xzOq4xiDGhxuyTb+5z0CI5YGgFIAdGaY2LcH6M=;\n\tb=P6AVzKH/t9etLtF7IZKYnF4i7MLwInjN/2IhszqpYlhsbD6Yrwi2oMfVm06i6XKVBC\n\tnYfMtKP03NtI75CznKIxMqKnVag3DyOe2Zz5bNwx7paGD23cUJ/0bX0grDMcR4B58plr\n\tJk42T8AAyLNj74tuPaOrJmxE8YCguBN+6t3NLDjcuHrjyO2bFFkQKO/Z7tAVrkdPEKNl\n\tuqmR/wmOlutMJajUXCHaeX57CdvHuCBH0IZoix5MGIhSLmErLhSilssW8V0JvQMKVLPF\n\tm2d3a8NIN7UHcHysO7c5/2Yiv0c2eRUc6TbisqVoGsyvn0egi8sOcLzKFHk0A6QI54hC\n\tut0w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=GFXm3xzOq4xiDGhxuyTb+5z0CI5YGgFIAdGaY2LcH6M=;\n\tb=rIvKH8WeWFG68ztV3jyIShK3CzL4rcRclqhvZ2KIZDrSoAhJjWY0PSdO1VcLCFruDU\n\tU4CGC0kXCDTtoc3oHbHB81wfsNF0d0F3wGVr/WmonEN5etJdm7QZs73tGKZNjAO1unux\n\tqf9zi506wGR6Iq97y27tCGL6kJRO4tX6CHLVnhQJhTxFUZ5NpC87BCfCvlsPxYq3gdVY\n\tZ/268e3HEklsEOgS4u349R4Shv8ZrQpCie3Bwrj8aZWn6lxPVAcbKRJIXcWMr1JxhD/Y\n\t5/ByvvipqaOvd+/Zp+SipR1EVz4pQIxd1w7yIOiwVq9L4cFWTkRDsdDC3V7FmX0Yp/4C\n\tqA1g==", "X-Gm-Message-State": "AElRT7HkajphgoEsm0pGkz+XSm/pthejhxjvfUVAEuvqI49hnq/zUY0E\n\tnCVmDXjAsE/2ggcsg29Ex/E=", "X-Google-Smtp-Source": "AG47ELsNmZNFAzpIwv8juOVOOgEEemD2T5l1HP5NFrR4IcyqC/1FcuFp3XHv40nYgKJFnm6dtxsbfw==", "X-Received": "by 10.98.15.72 with SMTP id x69mr3288111pfi.16.1521011608079;\n\tWed, 14 Mar 2018 00:13:28 -0700 (PDT)", "From": "Joel Stanley <joel@jms.id.au>", "To": "Arnd Bergmann <arnd@arndb.de>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>", "Subject": "[PATCH] ARM: dts: aspeed: Add default memory node", "Date": "Wed, 14 Mar 2018 17:43:12 +1030", "Message-Id": "<20180314071312.17492-1-joel@jms.id.au>", "X-Mailer": "git-send-email 2.15.1", "X-BeenThere": "linux-aspeed@lists.ozlabs.org", "X-Mailman-Version": "2.1.26", "Precedence": "list", "List-Id": "Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linux-aspeed/>", "List-Post": "<mailto:linux-aspeed@lists.ozlabs.org>", "List-Help": "<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n\t<mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>", "Cc": "stable@vger.kernel.org, linux-aspeed@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Linux-aspeed\"\n\t<linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "When we removed the inclusion of skeleton.dtsi from the device trees, we\nbroke booting for systems with bootloaders that aren't device tre aware.\nThis can be seen, for example, when appending the device tree blob to\nthe kernel image.\n\nThe reason booting broke was that the kernel lacked the device_type\nlabel in the memory node. Add in a default memory node wth the\ndevice_type. It can contain the memory address as the location is fixed\nfor each SoC generation, but the size needs to be added by the\nbootloader or the board specific dts.\n\nFixes: 73102d6fdc32 (\"ARM: dts: aspeed: Remove skeleton.dtsi\")\nCc: <stable@vger.kernel.org>\nReported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>\nSigned-off-by: Joel Stanley <joel@jms.id.au>\n---\nArnd, can you please merge this as a fix for 4.16?\n\n arch/arm/boot/dts/aspeed-g4.dtsi | 5 +++++\n arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi\nindex 36ae23aa3b48..518d2bc7c7fc 100644\n--- a/arch/arm/boot/dts/aspeed-g4.dtsi\n+++ b/arch/arm/boot/dts/aspeed-g4.dtsi\n@@ -42,6 +42,11 @@\n \t\t};\n \t};\n \n+\tmemory@40000000 {\n+\t\tdevice_type = \"memory\";\n+\t\treg = <0x40000000 0>;\n+\t};\n+\n \tahb {\n \t\tcompatible = \"simple-bus\";\n \t\t#address-cells = <1>;\ndiff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi\nindex 17ee0fa33a14..f9917717dd08 100644\n--- a/arch/arm/boot/dts/aspeed-g5.dtsi\n+++ b/arch/arm/boot/dts/aspeed-g5.dtsi\n@@ -42,6 +42,11 @@\n \t\t};\n \t};\n \n+\tmemory@80000000 {\n+\t\tdevice_type = \"memory\";\n+\t\treg = <0x80000000 0>;\n+\t};\n+\n \tahb {\n \t\tcompatible = \"simple-bus\";\n \t\t#address-cells = <1>;\n", "prefixes": [] }