Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/885592/?format=api
{ "id": 885592, "url": "http://patchwork.ozlabs.org/api/patches/885592/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180314024552.7086.86874.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180314024552.7086.86874.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2018-03-14T02:45:52", "name": "[next-queue] i40evf: Reorder configure_clsflower to avoid deadlock on error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8f46dcb243707db2c44815f3d627294b41c8fd5b", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180314024552.7086.86874.stgit@localhost.localdomain/mbox/", "series": [ { "id": 33629, "url": "http://patchwork.ozlabs.org/api/series/33629/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=33629", "date": "2018-03-14T02:45:52", "name": "[next-queue] i40evf: Reorder configure_clsflower to avoid deadlock on error", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/33629/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/885592/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/885592/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"cUZJqqB2\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 401GLc2V6vz9sTT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 14 Mar 2018 13:45:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 54146226D6;\n\tWed, 14 Mar 2018 02:45:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iulpqW2RoWE4; Wed, 14 Mar 2018 02:45:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6BDF6226CA;\n\tWed, 14 Mar 2018 02:45:57 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1D2311C16D3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Mar 2018 02:45:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 18DBA226CA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Mar 2018 02:45:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yWoy31dRj4FG for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Mar 2018 02:45:55 +0000 (UTC)", "from mail-io0-f193.google.com (mail-io0-f193.google.com\n\t[209.85.223.193])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5B79222648\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Mar 2018 02:45:55 +0000 (UTC)", "by mail-io0-f193.google.com with SMTP id m83so2538527ioi.8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 13 Mar 2018 19:45:55 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tv18sm127527ita.22.2018.03.13.19.45.53\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 13 Mar 2018 19:45:53 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=aRDaVzP+GKa5FEBgQocS6aioNZ6qnNwz61PmrRaFHZY=;\n\tb=cUZJqqB20ScYCSguUHbyHB2metHqjyhIcvIdfYykbNj0paHI1uBpbhRSlRRxJsWkbC\n\tDPeQSWaoE3Zp1AWL9GD+ZGmgjhfKrsP4Y1+ll+mXiP5Ak4BHUcAvmjSzhOu2bbpsizza\n\tPLUBfdTFf/7yImrLc1/U08GHPLyZu//7sWs+3ezwb0pXLjVSj3p8pgY2QDiRbp2FOHvV\n\tUa0ckoDYlTv47EHJNhNC08LPyrJWspYCvimeVxjfIxuG78s91eZ2ybVk7Ah/PU9aPqYq\n\tpUhd5k8aCCAax13cYRqUl/d3ynIxhuNyn48Bmc0DTaXxsVTWLSUMC7CPpOx10kIMlgp2\n\tNv4Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=aRDaVzP+GKa5FEBgQocS6aioNZ6qnNwz61PmrRaFHZY=;\n\tb=WoBnfBgkHs8MtPji9LuI5vNkPlKzpBGryG/8fOV5KLrUIF2lO8l9FkDILWyzPminV5\n\tZ+cM+ajpmXlp2M5iuzbIiY+TW0tdy+7AubtpEnJh+wb36eiUpJ9j7KKdOanDTXGQPdHP\n\tf5wIb9jqz6xImcuP5NL7H99ugHr8sd9qXXG8erLlmrBylJTURGApM6WO3xsTvdZt7oFa\n\t7jbickLpK+8AO0djNLg9NX17Gt0PPnAEbTsbTHmq6bKMXzr0+fXmTBtpjfWxRXdQuhwg\n\tKMUqlJJ0PUBzlqvC1nymy4YT+1PbbgKyuOemvtHbzjGQpaOJbKwpNyYRovqVBVYN8GyR\n\tk4Tw==", "X-Gm-Message-State": "AElRT7HzMogDe1NDjyhmK76JkaqGzBltvToFHSLRWpHqee/AZPEAHiiN\n\t/Nk//CJj5f8sIYSRtsla7yJiq9Mz", "X-Google-Smtp-Source": "AG47ELvhUb+CareQyI3z9EVeVSoN+x9aRePHUarjddg2eUUJyWjPoooPWgJiPubxXjjOMM5hMFxuFQ==", "X-Received": "by 10.107.135.157 with SMTP id r29mr3075996ioi.248.1520995554193;\n\tTue, 13 Mar 2018 19:45:54 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 13 Mar 2018 19:45:52 -0700", "Message-ID": "<20180314024552.7086.86874.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH] i40evf: Reorder\n\tconfigure_clsflower to avoid deadlock on error", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nWhile doing some code review I noticed that we can get into a state where\nwe exit with the \"IN_CRITICAL_TASK\" bit set while notifying the PF of\nflower filters. This patch is meant to address that plus tweak the ordering\nof the while loop waiting on it slightly so that we don't wait an extra\nperiod after we have failed for the last time.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 23 +++++++++++------------\n 1 file changed, 11 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 52a017c42ffd..57e74f845dc4 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -2792,14 +2792,7 @@ static int i40evf_configure_clsflower(struct i40evf_adapter *adapter,\n {\n \tint tc = tc_classid_to_hwtc(adapter->netdev, cls_flower->classid);\n \tstruct i40evf_cloud_filter *filter = NULL;\n-\tint err = 0, count = 50;\n-\n-\twhile (test_and_set_bit(__I40EVF_IN_CRITICAL_TASK,\n-\t\t\t\t&adapter->crit_section)) {\n-\t\tudelay(1);\n-\t\tif (--count == 0)\n-\t\t\treturn -EINVAL;\n-\t}\n+\tint err = -EINVAL, count = 50;\n \n \tif (tc < 0) {\n \t\tdev_err(&adapter->pdev->dev, \"Invalid traffic class\\n\");\n@@ -2807,10 +2800,16 @@ static int i40evf_configure_clsflower(struct i40evf_adapter *adapter,\n \t}\n \n \tfilter = kzalloc(sizeof(*filter), GFP_KERNEL);\n-\tif (!filter) {\n-\t\terr = -ENOMEM;\n-\t\tgoto clearout;\n+\tif (!filter)\n+\t\treturn -ENOMEM;\n+\n+\twhile (test_and_set_bit(__I40EVF_IN_CRITICAL_TASK,\n+\t\t\t\t&adapter->crit_section)) {\n+\t\tif (--count == 0)\n+\t\t\tgoto err;\n+\t\tudelay(1);\n \t}\n+\n \tfilter->cookie = cls_flower->cookie;\n \n \t/* set the mask to all zeroes to begin with */\n@@ -2835,7 +2834,7 @@ static int i40evf_configure_clsflower(struct i40evf_adapter *adapter,\n err:\n \tif (err)\n \t\tkfree(filter);\n-clearout:\n+\n \tclear_bit(__I40EVF_IN_CRITICAL_TASK, &adapter->crit_section);\n \treturn err;\n }\n", "prefixes": [ "next-queue" ] }