Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/883392/?format=api
{ "id": 883392, "url": "http://patchwork.ozlabs.org/api/patches/883392/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180308225211.12254-2-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180308225211.12254-2-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2018-03-08T22:52:06", "name": "[S87,v5,2/7] i40e: Cleanup i40e_vlan_rx_register", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "162401fda2298207e397eddf6a71542a31ede7f4", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180308225211.12254-2-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 32763, "url": "http://patchwork.ozlabs.org/api/series/32763/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=32763", "date": "2018-03-08T22:52:05", "name": "[S87,v5,1/7] i40e: Fix attach VF to VM issue", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/32763/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/883392/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/883392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zy5P06H0hz9scZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 9 Mar 2018 09:52:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 37BD487A7C;\n\tThu, 8 Mar 2018 22:52:03 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tSIjCAZMYIt3; Thu, 8 Mar 2018 22:52:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8070F87AB1;\n\tThu, 8 Mar 2018 22:52:02 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E23D21CF0C9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DCC1A2290C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:51 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fRT-66EHdC5k for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:46 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D850622688\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:46 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Mar 2018 14:51:46 -0800", "from jtkirshe-nuc.jf.intel.com ([134.134.177.59])\n\tby orsmga001.jf.intel.com with ESMTP; 08 Mar 2018 14:51:45 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.47,442,1515484800\"; d=\"scan'208\";a=\"37164038\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 8 Mar 2018 14:52:06 -0800", "Message-Id": "<20180308225211.12254-2-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180308225211.12254-1-jeffrey.t.kirsher@intel.com>", "References": "<20180308225211.12254-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [S87 v5 2/7] i40e: Cleanup i40e_vlan_rx_register", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nWe used to use the function i40e_vlan_rx_register as a way to hook\ninto the now defunct .ndo_vlan_rx_register netdev hook. This was\nremoved but we kept the function around because we still used it\ninternally to control enabling or disabling of VLAN stripping.\n\nAs pointed out in upstream review, VLAN stripping is only used in a\nsingle location and the previous function is quite small, just inline\nit into i40e_restore_vlan() rather than carrying the function\nseparately.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 21 ++++-----------------\n 1 file changed, 4 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4b34bbc83b99..183c8b84b7ea 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2719,22 +2719,6 @@ void i40e_vlan_stripping_disable(struct i40e_vsi *vsi)\n \t}\n }\n \n-/**\n- * i40e_vlan_rx_register - Setup or shutdown vlan offload\n- * @netdev: network interface to be adjusted\n- * @features: netdev features to test if VLAN offload is enabled or not\n- **/\n-static void i40e_vlan_rx_register(struct net_device *netdev, u32 features)\n-{\n-\tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n-\tstruct i40e_vsi *vsi = np->vsi;\n-\n-\tif (features & NETIF_F_HW_VLAN_CTAG_RX)\n-\t\ti40e_vlan_stripping_enable(vsi);\n-\telse\n-\t\ti40e_vlan_stripping_disable(vsi);\n-}\n-\n /**\n * i40e_add_vlan_all_mac - Add a MAC/VLAN filter for each existing MAC address\n * @vsi: the vsi being configured\n@@ -2910,7 +2894,10 @@ static void i40e_restore_vlan(struct i40e_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\ti40e_vlan_rx_register(vsi->netdev, vsi->netdev->features);\n+\tif (vsi->netdev->features & NETIF_F_HW_VLAN_CTAG_RX)\n+\t\ti40e_vlan_stripping_enable(vsi);\n+\telse\n+\t\ti40e_vlan_stripping_disable(vsi);\n \n \tfor_each_set_bit(vid, vsi->active_vlans, VLAN_N_VID)\n \t\ti40e_vlan_rx_add_vid(vsi->netdev, htons(ETH_P_8021Q),\n", "prefixes": [ "S87", "v5", "2/7" ] }