Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/883390/?format=api
{ "id": 883390, "url": "http://patchwork.ozlabs.org/api/patches/883390/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180308225211.12254-5-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180308225211.12254-5-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2018-03-08T22:52:09", "name": "[S87,v5,5/7] i40e: factor out re-enable functions for ATR and SB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "382cd4fa87543d542328fd49c051e4eb4e3564e1", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180308225211.12254-5-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 32763, "url": "http://patchwork.ozlabs.org/api/series/32763/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=32763", "date": "2018-03-08T22:52:05", "name": "[S87,v5,1/7] i40e: Fix attach VF to VM issue", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/32763/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/883390/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/883390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zy5Nx6lphz9scR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 9 Mar 2018 09:52:01 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8853584B65;\n\tThu, 8 Mar 2018 22:52:00 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XxdvZNpl-lkx; Thu, 8 Mar 2018 22:52:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F41B784B7A;\n\tThu, 8 Mar 2018 22:51:59 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C33131CF0BF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BF2E122927\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:51 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4zND32FKLuon for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:47 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 4FDF52290C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Mar 2018 22:51:47 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Mar 2018 14:51:46 -0800", "from jtkirshe-nuc.jf.intel.com ([134.134.177.59])\n\tby orsmga001.jf.intel.com with ESMTP; 08 Mar 2018 14:51:45 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.47,442,1515484800\"; d=\"scan'208\";a=\"37164043\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 8 Mar 2018 14:52:09 -0800", "Message-Id": "<20180308225211.12254-5-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180308225211.12254-1-jeffrey.t.kirsher@intel.com>", "References": "<20180308225211.12254-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [S87 v5 5/7] i40e: factor out re-enable functions\n\tfor ATR and SB", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nA future patch needs to expand on the logic for re-enabling ATR. Doing\nso would cause some code to break the 80-character line limit.\n\nTo reduce the level of indentation, factor out helper functions for\nre-enabling ATR and SB rules.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 48 +++++++++++++++++++----------\n 1 file changed, 32 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 0b45650b7e31..89bcfd1c3213 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8136,6 +8136,34 @@ u32 i40e_get_global_fd_count(struct i40e_pf *pf)\n \treturn fcnt_prog;\n }\n \n+/**\n+ * i40e_reenable_fdir_sb - Restore FDir SB capability\n+ * @pf: board private structure\n+ **/\n+static void i40e_reenable_fdir_sb(struct i40e_pf *pf)\n+{\n+\tif (pf->flags & I40E_FLAG_FD_SB_AUTO_DISABLED) {\n+\t\tpf->flags &= ~I40E_FLAG_FD_SB_AUTO_DISABLED;\n+\t\tif ((pf->flags & I40E_FLAG_FD_SB_ENABLED) &&\n+\t\t (I40E_DEBUG_FD & pf->hw.debug_mask))\n+\t\t\tdev_info(&pf->pdev->dev, \"FD Sideband/ntuple is being enabled since we have space in the table now\\n\");\n+\t}\n+}\n+\n+/**\n+ * i40e_reenable_fdir_atr - Restore FDir ATR capability\n+ * @pf: board private structure\n+ **/\n+static void i40e_reenable_fdir_atr(struct i40e_pf *pf)\n+{\n+\tif (pf->flags & I40E_FLAG_FD_ATR_AUTO_DISABLED) {\n+\t\tpf->flags &= ~I40E_FLAG_FD_ATR_AUTO_DISABLED;\n+\t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n+\t\t (I40E_DEBUG_FD & pf->hw.debug_mask))\n+\t\t\tdev_info(&pf->pdev->dev, \"ATR is being enabled since we have space in the table and there are no conflicting ntuple rules\\n\");\n+\t}\n+}\n+\n /**\n * i40e_delete_invalid_filter - Delete an invalid FDIR filter\n * @pf: board private structure\n@@ -8199,28 +8227,16 @@ void i40e_fdir_check_and_reenable(struct i40e_pf *pf)\n \tfcnt_avail = pf->fdir_pf_filter_count;\n \tif ((fcnt_prog < (fcnt_avail - I40E_FDIR_BUFFER_HEAD_ROOM)) ||\n \t (pf->fd_add_err == 0) ||\n-\t (i40e_get_current_atr_cnt(pf) < pf->fd_atr_cnt)) {\n-\t\tif (pf->flags & I40E_FLAG_FD_SB_AUTO_DISABLED) {\n-\t\t\tpf->flags &= ~I40E_FLAG_FD_SB_AUTO_DISABLED;\n-\t\t\tif ((pf->flags & I40E_FLAG_FD_SB_ENABLED) &&\n-\t\t\t (I40E_DEBUG_FD & pf->hw.debug_mask))\n-\t\t\t\tdev_info(&pf->pdev->dev, \"FD Sideband/ntuple is being enabled since we have space in the table now\\n\");\n-\t\t}\n-\t}\n+\t (i40e_get_current_atr_cnt(pf) < pf->fd_atr_cnt))\n+\t\ti40e_reenable_fdir_sb(pf);\n \n \t/* We should wait for even more space before re-enabling ATR.\n \t * Additionally, we cannot enable ATR as long as we still have TCP SB\n \t * rules active.\n \t */\n \tif ((fcnt_prog < (fcnt_avail - I40E_FDIR_BUFFER_HEAD_ROOM_FOR_ATR)) &&\n-\t (pf->fd_tcp4_filter_cnt == 0)) {\n-\t\tif (pf->flags & I40E_FLAG_FD_ATR_AUTO_DISABLED) {\n-\t\t\tpf->flags &= ~I40E_FLAG_FD_ATR_AUTO_DISABLED;\n-\t\t\tif ((pf->flags & I40E_FLAG_FD_ATR_ENABLED) &&\n-\t\t\t (I40E_DEBUG_FD & pf->hw.debug_mask))\n-\t\t\t\tdev_info(&pf->pdev->dev, \"ATR is being enabled since we have space in the table and there are no conflicting ntuple rules\\n\");\n-\t\t}\n-\t}\n+\t (pf->fd_tcp4_filter_cnt == 0))\n+\t\ti40e_reenable_fdir_atr(pf);\n \n \t/* if hw had a problem adding a filter, delete it */\n \tif (pf->fd_inv > 0) {\n", "prefixes": [ "S87", "v5", "5/7" ] }