Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/880744/?format=api
{ "id": 880744, "url": "http://patchwork.ozlabs.org/api/patches/880744/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180302184344.5744-3-vinicius.gomes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180302184344.5744-3-vinicius.gomes@intel.com>", "list_archive_url": null, "date": "2018-03-02T18:43:38", "name": "[next-queue,v2,2/8] igb: Fix queue selection on MAC filters on i210 and i211", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8e22b001f7a694085594e85be819e51397a1cb13", "submitter": { "id": 72272, "url": "http://patchwork.ozlabs.org/api/people/72272/?format=api", "name": "Vinicius Costa Gomes", "email": "vinicius.gomes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180302184344.5744-3-vinicius.gomes@intel.com/mbox/", "series": [ { "id": 31605, "url": "http://patchwork.ozlabs.org/api/series/31605/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=31605", "date": "2018-03-02T18:43:37", "name": "igb: offloading of receive filters", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/31605/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/880744/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/880744/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ztJBG0394z9s8h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 3 Mar 2018 05:44:37 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 566D92265E;\n\tFri, 2 Mar 2018 18:44:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HDwyBBmmEfL5; Fri, 2 Mar 2018 18:44:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 63A4B2E771;\n\tFri, 2 Mar 2018 18:44:28 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A3B101C062C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Mar 2018 18:44:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9DF7E89080\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Mar 2018 18:44:25 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bWTmdrTacQzc for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Mar 2018 18:44:23 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 6E7428907A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 2 Mar 2018 18:44:23 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Mar 2018 10:44:23 -0800", "from ellie.jf.intel.com (HELO localhost.localdomain)\n\t([10.24.13.29])\n\tby fmsmga001.fm.intel.com with ESMTP; 02 Mar 2018 10:44:22 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.47,413,1515484800\"; d=\"scan'208\";a=\"35044390\"", "From": "Vinicius Costa Gomes <vinicius.gomes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 2 Mar 2018 10:43:38 -0800", "Message-Id": "<20180302184344.5744-3-vinicius.gomes@intel.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180302184344.5744-1-vinicius.gomes@intel.com>", "References": "<20180302184344.5744-1-vinicius.gomes@intel.com>", "Subject": "[Intel-wired-lan] [next-queue PATCH v2 2/8] igb: Fix queue\n\tselection on MAC filters on i210 and i211", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On the RAH registers there are semantic differences on the meaning of\nthe \"queue\" parameter for traffic steering depending on the controller\nmodel: there is the 82575 meaning, which \"queue\" means a RX Hardware\nQueue, and the i350 meaning, where it is a reception pool.\n\nThe previous behaviour was having no effect for i210 and i211 based\ncontrollers because the QSEL bit of the RAH register wasn't being set.\n\nThis patch separates the condition in discrete cases, so the different\nhandling is clearer.\n\nFixes: 83c21335c876 (\"igb: improve MAC filter handling\")\nSigned-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>\n---\n drivers/net/ethernet/intel/igb/e1000_defines.h | 1 +\n drivers/net/ethernet/intel/igb/igb_main.c | 15 +++++++++++----\n 2 files changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_defines.h b/drivers/net/ethernet/intel/igb/e1000_defines.h\nindex 83cabff1e0ab..573bf177fd08 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_defines.h\n+++ b/drivers/net/ethernet/intel/igb/e1000_defines.h\n@@ -490,6 +490,7 @@\n * manageability enabled, allowing us room for 15 multicast addresses.\n */\n #define E1000_RAH_AV 0x80000000 /* Receive descriptor valid */\n+#define E1000_RAH_QSEL_ENABLE 0x10000000\n #define E1000_RAL_MAC_ADDR_LEN 4\n #define E1000_RAH_MAC_ADDR_LEN 2\n #define E1000_RAH_POOL_MASK 0x03FC0000\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex b88fae785369..0ea32be07d71 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -8741,12 +8741,19 @@ static void igb_rar_set_index(struct igb_adapter *adapter, u32 index)\n \t\tif (is_valid_ether_addr(addr))\n \t\t\trar_high |= E1000_RAH_AV;\n \n-\t\tif (hw->mac.type == e1000_82575)\n+\t\tswitch (hw->mac.type) {\n+\t\tcase e1000_82575:\n+\t\tcase e1000_i210:\n+\t\tcase e1000_i211:\n+\t\t\trar_high |= E1000_RAH_QSEL_ENABLE;\n \t\t\trar_high |= E1000_RAH_POOL_1 *\n-\t\t\t\t adapter->mac_table[index].queue;\n-\t\telse\n+\t\t\t\t adapter->mac_table[index].queue;\n+\t\t\tbreak;\n+\t\tdefault:\n \t\t\trar_high |= E1000_RAH_POOL_1 <<\n-\t\t\t\t adapter->mac_table[index].queue;\n+\t\t\t\tadapter->mac_table[index].queue;\n+\t\t\tbreak;\n+\t\t}\n \t}\n \n \twr32(E1000_RAL(index), rar_low);\n", "prefixes": [ "next-queue", "v2", "2/8" ] }