Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/876805/?format=api
{ "id": 876805, "url": "http://patchwork.ozlabs.org/api/patches/876805/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1519326597-7679-2-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1519326597-7679-2-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-02-22T19:09:55", "name": "[next-queue,1/3] ixgbe: check for 128-bit authentication", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d7de29288c51049de8ec3200a3fa021f9cb56f01", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1519326597-7679-2-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 30010, "url": "http://patchwork.ozlabs.org/api/series/30010/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=30010", "date": "2018-02-22T19:09:55", "name": "[next-queue,1/3] ixgbe: check for 128-bit authentication", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/30010/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/876805/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/876805/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"BnEgR4Iq\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3znP7c1LqZz9s7T\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 23 Feb 2018 06:10:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B803D88C1C;\n\tThu, 22 Feb 2018 19:10:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WqF97rssj2D2; Thu, 22 Feb 2018 19:10:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 54D4488F7D;\n\tThu, 22 Feb 2018 19:10:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2B06F1C2193\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Feb 2018 19:10:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2766B89BF5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Feb 2018 19:10:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5d7ocd57U9uY for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Feb 2018 19:10:14 +0000 (UTC)", "from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 94D5A89C35\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Feb 2018 19:10:14 +0000 (UTC)", "from pps.filterd (aserp2130.oracle.com [127.0.0.1])\n\tby aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw1MJ3Kus084860; Thu, 22 Feb 2018 19:10:13 GMT", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp2130.oracle.com with ESMTP id 2ga322gavp-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 22 Feb 2018 19:10:13 +0000", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w1MJACUe021626\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=FAIL); Thu, 22 Feb 2018 19:10:13 GMT", "from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw1MJABx5008129; Thu, 22 Feb 2018 19:10:12 GMT", "from slnelson-mint18.us.oracle.com (/10.159.159.10)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 22 Feb 2018 11:10:11 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references;\n\ts=corp-2017-10-26; \n\tbh=MYDRvxeIBu7xWIAGgVenBSXm/HMSyiuk7KrFmWdhrSE=;\n\tb=BnEgR4Iq42RlhC02x20QmUbKQo4t+W8XUglCnktG3aGVh/r6d4QwRW5pI0lu4HzRm8eA\n\tfvcbk4E9FidQB5ugzyCaBXMGa+4wIBJEwoDw/onJaYGah9zquSWcJkQtTDp86GwlE2YW\n\tGQnWkWcnJdIYbHlpfrAbnIwbimviK7rNbmlCMgIrxJPvDa9tl/LqNtbw2j3mRzYeItNc\n\thaCZjSH2lzMdEXtbX73U5jGYNWFcXz7NdAqisGW65m6ykf0+1qzb41m5rA3pUa1xHiYA\n\t9FOLV/w668H4crOD/ARzVVGsvKrafDOtLlILNgK3t6EgzyV70RXBYbJIJ4oT/UUjxcox\n\tlA== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 22 Feb 2018 11:09:55 -0800", "Message-Id": "<1519326597-7679-2-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1519326597-7679-1-git-send-email-shannon.nelson@oracle.com>", "References": "<1519326597-7679-1-git-send-email-shannon.nelson@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8812\n\tsignatures=668677", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=1\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1802220240", "Subject": "[Intel-wired-lan] [PATCH next-queue 1/3] ixgbe: check for 128-bit\n\tauthentication", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "steffen.klassert@secunet.com, netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Make sure the Security Association is using\na 128-bit authentication, since that's the only\nsize that the hardware offload supports.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 +++++++++++-----\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 1 +\n 2 files changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex 93eacdd..8b7dbc8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -423,15 +423,21 @@ static int ixgbe_ipsec_parse_proto_keys(struct xfrm_state *xs,\n \tconst char aes_gcm_name[] = \"rfc4106(gcm(aes))\";\n \tint key_len;\n \n-\tif (xs->aead) {\n-\t\tkey_data = &xs->aead->alg_key[0];\n-\t\tkey_len = xs->aead->alg_key_len;\n-\t\talg_name = xs->aead->alg_name;\n-\t} else {\n+\tif (!xs->aead) {\n \t\tnetdev_err(dev, \"Unsupported IPsec algorithm\\n\");\n \t\treturn -EINVAL;\n \t}\n \n+\tif (xs->aead->alg_icv_len != IXGBE_IPSEC_AUTH_BITS) {\n+\t\tnetdev_err(dev, \"IPsec offload requires %d bit authentication\\n\",\n+\t\t\t IXGBE_IPSEC_AUTH_BITS);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tkey_data = &xs->aead->alg_key[0];\n+\tkey_len = xs->aead->alg_key_len;\n+\talg_name = xs->aead->alg_name;\n+\n \tif (strcmp(alg_name, aes_gcm_name)) {\n \t\tnetdev_err(dev, \"Unsupported IPsec algorithm - please use %s\\n\",\n \t\t\t aes_gcm_name);\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h\nindex da3ce78..87d2800 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h\n@@ -32,6 +32,7 @@\n #define IXGBE_IPSEC_MAX_RX_IP_COUNT\t128\n #define IXGBE_IPSEC_BASE_RX_INDEX\t0\n #define IXGBE_IPSEC_BASE_TX_INDEX\tIXGBE_IPSEC_MAX_SA_COUNT\n+#define IXGBE_IPSEC_AUTH_BITS\t\t128\n \n #define IXGBE_RXTXIDX_IPS_EN\t\t0x00000001\n #define IXGBE_RXIDX_TBL_SHIFT\t\t1\n", "prefixes": [ "next-queue", "1/3" ] }