Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/875411/?format=api
{ "id": 875411, "url": "http://patchwork.ozlabs.org/api/patches/875411/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180220061200.17708-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180220061200.17708-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2018-02-20T06:12:00", "name": "[net-queue] e1000e: Fix check_for_link return value with autoneg off.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2c4a89bf1b56ff2c6ef63f31062b48fafe5ce567", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180220061200.17708-1-bpoirier@suse.com/mbox/", "series": [ { "id": 29462, "url": "http://patchwork.ozlabs.org/api/series/29462/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=29462", "date": "2018-02-20T06:12:00", "name": "[net-queue] e1000e: Fix check_for_link return value with autoneg off.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/29462/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/875411/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/875411/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zlqyx4klbz9s01\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 20 Feb 2018 17:12:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E60A887835;\n\tTue, 20 Feb 2018 06:12:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Hi90QgKKp2tn; Tue, 20 Feb 2018 06:12:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5EE7186195;\n\tTue, 20 Feb 2018 06:12:21 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7F6271C2D3D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Feb 2018 06:12:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7849186195\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Feb 2018 06:12:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5V1FmtAt6awj for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Feb 2018 06:12:18 +0000 (UTC)", "from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id A584186165\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Feb 2018 06:12:18 +0000 (UTC)", "from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 7F372ACDD;\n\tTue, 20 Feb 2018 06:12:15 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "by amavisd-new at test-mx.suse.de" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 20 Feb 2018 15:12:00 +0900", "Message-Id": "<20180220061200.17708-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.16.1", "Subject": "[Intel-wired-lan] [PATCH net-queue] e1000e: Fix check_for_link\n\treturn value with autoneg off.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When autoneg is off, the .check_for_link callback functions clear the\nget_link_status flag and systematically return a \"pseudo-error\". This means\nthat the link is not detected as up until the next execution of the\ne1000_watchdog_task() 2 seconds later.\n\nFixes: 19110cfbb34d (\"e1000e: Separate signaling for link check/link up\")\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 +-\n drivers/net/ethernet/intel/e1000e/mac.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex 31277d3bb7dc..ff308b05d68c 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -1602,7 +1602,7 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n \t * we have already determined whether we have link or not.\n \t */\n \tif (!mac->autoneg)\n-\t\treturn -E1000_ERR_CONFIG;\n+\t\treturn 1;\n \n \t/* Auto-Neg is enabled. Auto Speed Detection takes care\n \t * of MAC speed/duplex configuration. So we only need to\ndiff --git a/drivers/net/ethernet/intel/e1000e/mac.c b/drivers/net/ethernet/intel/e1000e/mac.c\nindex f457c5703d0c..db735644b312 100644\n--- a/drivers/net/ethernet/intel/e1000e/mac.c\n+++ b/drivers/net/ethernet/intel/e1000e/mac.c\n@@ -450,7 +450,7 @@ s32 e1000e_check_for_copper_link(struct e1000_hw *hw)\n \t * we have already determined whether we have link or not.\n \t */\n \tif (!mac->autoneg)\n-\t\treturn -E1000_ERR_CONFIG;\n+\t\treturn 1;\n \n \t/* Auto-Neg is enabled. Auto Speed Detection takes care\n \t * of MAC speed/duplex configuration. So we only need to\n", "prefixes": [ "net-queue" ] }