Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/874104/?format=api
{ "id": 874104, "url": "http://patchwork.ozlabs.org/api/patches/874104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180215195052.29037-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180215195052.29037-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-02-15T19:50:52", "name": "i40e: check that pointer vsi is not null before dereferencing it", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "50b3cd1720701d9b277f3f18ecb64490ce1e2425", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180215195052.29037-1-colin.king@canonical.com/mbox/", "series": [ { "id": 28865, "url": "http://patchwork.ozlabs.org/api/series/28865/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=28865", "date": "2018-02-15T19:50:52", "name": "i40e: check that pointer vsi is not null before dereferencing it", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/28865/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/874104/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/874104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zj6Mk356mz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Feb 2018 06:50:58 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B290E8A20E;\n\tThu, 15 Feb 2018 19:50:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qVdWsWS1r3pz; Thu, 15 Feb 2018 19:50:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4290C8A202;\n\tThu, 15 Feb 2018 19:50:56 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6403E1BFD3C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:50:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5F7288A202\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:50:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gEQNgDEG+1dt for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:50:55 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id D43068A20C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:50:54 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1emPYS-0003MG-SL; Thu, 15 Feb 2018 19:50:52 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Thu, 15 Feb 2018 19:50:52 +0000", "Message-Id": "<20180215195052.29037-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.15.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: check that pointer vsi is not null\n\tbefore dereferencing it", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nFunction i40e_find_vsi_from_id can potentially return null, hence\nvsi may be null, so defensively check it is non-null before\ndereferencing it to check the seid.\n\nFixes: e284fc280473 (\"i40e: Add and delete cloud filter\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 5cca083da93c..14bbd5c1db78 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -3062,7 +3062,7 @@ static struct i40e_vsi *i40e_find_vsi_from_seid(struct i40e_vf *vf, u16 seid)\n \n \tfor (i = 0; i < vf->num_tc ; i++) {\n \t\tvsi = i40e_find_vsi_from_id(pf, vf->ch[i].vsi_id);\n-\t\tif (vsi->seid == seid)\n+\t\tif (vsi && vsi->seid == seid)\n \t\t\treturn vsi;\n \t}\n \treturn NULL;\n", "prefixes": [] }