Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/874095/?format=api
{ "id": 874095, "url": "http://patchwork.ozlabs.org/api/patches/874095/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180215192605.28350-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180215192605.28350-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-02-15T19:26:05", "name": "i40evf: pass struct virtchnl_filter by reference rather than by value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3de67fbaadf23f45c09ace106826c0db5d4e619c", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180215192605.28350-1-colin.king@canonical.com/mbox/", "series": [ { "id": 28856, "url": "http://patchwork.ozlabs.org/api/series/28856/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=28856", "date": "2018-02-15T19:26:05", "name": "i40evf: pass struct virtchnl_filter by reference rather than by value", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/28856/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/874095/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/874095/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zj5qD2Y39z9sRW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Feb 2018 06:26:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7299C8916D;\n\tThu, 15 Feb 2018 19:26:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id htAMN9wj9F1c; Thu, 15 Feb 2018 19:26:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B21838917F;\n\tThu, 15 Feb 2018 19:26:13 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 798DC1C0015\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:26:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 733E88916D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:26:12 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bq1yzcx-+n5F for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:26:11 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 9DDDC8917F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Feb 2018 19:26:11 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1emPAT-0001fA-Vs; Thu, 15 Feb 2018 19:26:06 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Thu, 15 Feb 2018 19:26:05 +0000", "Message-Id": "<20180215192605.28350-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.15.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40evf: pass struct virtchnl_filter by\n\treference rather than by value", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nPassing struct virtchnl_filter f by value requires a 272 byte copy\non x86_64, so instead pass it by reference is much more efficient. Also\nadjust some lines that are over 80 chars.\n\nDetected by CoverityScan, CID#1465285 (\"Big parameter passed by value\")\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 32 ++++++++++++----------\n 1 file changed, 18 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex 6134b61e0938..3c76c817ca1a 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -1048,24 +1048,28 @@ void i40evf_disable_channels(struct i40evf_adapter *adapter)\n * Print the cloud filter\n **/\n static void i40evf_print_cloud_filter(struct i40evf_adapter *adapter,\n-\t\t\t\t struct virtchnl_filter f)\n+\t\t\t\t struct virtchnl_filter *f)\n {\n-\tswitch (f.flow_type) {\n+\tswitch (f->flow_type) {\n \tcase VIRTCHNL_TCP_V4_FLOW:\n \t\tdev_info(&adapter->pdev->dev, \"dst_mac: %pM src_mac: %pM vlan_id: %hu dst_ip: %pI4 src_ip %pI4 dst_port %hu src_port %hu\\n\",\n-\t\t\t &f.data.tcp_spec.dst_mac, &f.data.tcp_spec.src_mac,\n-\t\t\t ntohs(f.data.tcp_spec.vlan_id),\n-\t\t\t &f.data.tcp_spec.dst_ip[0], &f.data.tcp_spec.src_ip[0],\n-\t\t\t ntohs(f.data.tcp_spec.dst_port),\n-\t\t\t ntohs(f.data.tcp_spec.src_port));\n+\t\t\t &f->data.tcp_spec.dst_mac,\n+\t\t\t &f->data.tcp_spec.src_mac,\n+\t\t\t ntohs(f->data.tcp_spec.vlan_id),\n+\t\t\t &f->data.tcp_spec.dst_ip[0],\n+\t\t\t &f->data.tcp_spec.src_ip[0],\n+\t\t\t ntohs(f->data.tcp_spec.dst_port),\n+\t\t\t ntohs(f->data.tcp_spec.src_port));\n \t\tbreak;\n \tcase VIRTCHNL_TCP_V6_FLOW:\n \t\tdev_info(&adapter->pdev->dev, \"dst_mac: %pM src_mac: %pM vlan_id: %hu dst_ip: %pI6 src_ip %pI6 dst_port %hu src_port %hu\\n\",\n-\t\t\t &f.data.tcp_spec.dst_mac, &f.data.tcp_spec.src_mac,\n-\t\t\t ntohs(f.data.tcp_spec.vlan_id),\n-\t\t\t &f.data.tcp_spec.dst_ip, &f.data.tcp_spec.src_ip,\n-\t\t\t ntohs(f.data.tcp_spec.dst_port),\n-\t\t\t ntohs(f.data.tcp_spec.src_port));\n+\t\t\t &f->data.tcp_spec.dst_mac,\n+\t\t\t &f->data.tcp_spec.src_mac,\n+\t\t\t ntohs(f->data.tcp_spec.vlan_id),\n+\t\t\t &f->data.tcp_spec.dst_ip,\n+\t\t\t &f->data.tcp_spec.src_ip,\n+\t\t\t ntohs(f->data.tcp_spec.dst_port),\n+\t\t\t ntohs(f->data.tcp_spec.src_port));\n \t\tbreak;\n \t}\n }\n@@ -1303,7 +1307,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \t\t\t\t\t\t i40evf_stat_str(&adapter->hw,\n \t\t\t\t\t\t\t\t v_retval));\n \t\t\t\t\ti40evf_print_cloud_filter(adapter,\n-\t\t\t\t\t\t\t\t cf->f);\n+\t\t\t\t\t\t\t\t &cf->f);\n \t\t\t\t\tlist_del(&cf->list);\n \t\t\t\t\tkfree(cf);\n \t\t\t\t\tadapter->num_cloud_filters--;\n@@ -1322,7 +1326,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \t\t\t\t\t\t i40evf_stat_str(&adapter->hw,\n \t\t\t\t\t\t\t\t v_retval));\n \t\t\t\t\ti40evf_print_cloud_filter(adapter,\n-\t\t\t\t\t\t\t\t cf->f);\n+\t\t\t\t\t\t\t\t &cf->f);\n \t\t\t\t}\n \t\t\t}\n \t\t\t}\n", "prefixes": [] }