Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/873895/?format=api
{ "id": 873895, "url": "http://patchwork.ozlabs.org/api/patches/873895/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/1518704164-22198-9-git-send-email-koen.vandeputte@ncentric.com/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1518704164-22198-9-git-send-email-koen.vandeputte@ncentric.com>", "list_archive_url": null, "date": "2018-02-15T14:16:03", "name": "[LEDE-DEV,8/9] uqmi: use built-in command for data-link verification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b0222cbb52c8b0b53fed4a9d71189ab19791ad2a", "submitter": { "id": 69184, "url": "http://patchwork.ozlabs.org/api/people/69184/?format=api", "name": "Koen Vandeputte", "email": "koen.vandeputte@ncentric.com" }, "delegate": { "id": 54613, "url": "http://patchwork.ozlabs.org/api/users/54613/?format=api", "username": "blogic", "first_name": "John", "last_name": "Crispin", "email": "blogic@openwrt.org" }, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/1518704164-22198-9-git-send-email-koen.vandeputte@ncentric.com/mbox/", "series": [ { "id": 28782, "url": "http://patchwork.ozlabs.org/api/series/28782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=28782", "date": "2018-02-15T14:15:55", "name": "uqmi: Add raw-ip mode support for 17.01 branch", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/28782/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/873895/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/873895/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"hapIrWHL\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ncentric.com header.i=@ncentric.com\n\theader.b=\"EBg8Y6ij\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zhz3g4zy3z9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Feb 2018 01:21:35 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux))\n\tid 1emKPj-00036R-BQ; Thu, 15 Feb 2018 14:21:31 +0000", "from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235])\n\tby bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux))\n\tid 1emKLM-00075Q-DE\n\tfor lede-dev@lists.infradead.org; Thu, 15 Feb 2018 14:17:13 +0000", "by mail-wm0-x235.google.com with SMTP id k87so1133144wmi.0\n\tfor <lede-dev@lists.infradead.org>;\n\tThu, 15 Feb 2018 06:16:49 -0800 (PST)", "from localhost.localdomain (d515300d8.static.telenet.be.\n\t[81.83.0.216]) by smtp.googlemail.com with ESMTPSA id\n\td6sm3462692edm.52.2018.02.15.06.16.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 15 Feb 2018 06:16:47 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References:\n\tIn-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=9anMSoGrwfRjwFnytcIvkFOt8cEKnkVLSkoGNlRPFoM=;\n\tb=hapIrWHL2+tikg\n\tMfWcQxWMpYkhP0VK1RtNf0QVP0YMC3Fjr29Gx3Ur131WpeIDCLYUpUfPgrAOE3HLfldhtmPK2TdzG\n\t3wf5JNo+1ARLsunriOvynsKm+pYPDZ0cGAs/f71nD1egpn9QVYN6byqpzmt0qxP9x6vwa6nMHEBxi\n\tG21ttNvTqbbopeMqSg+e+2cSuurXI8Xt+1iGzOXQ18sT8jwt0n3Kj8Vhs68UeGwbrD7+92ggnxaXZ\n\tNY6w1l9+MmKhSNK0WMTk2fg29gTYZr0bi+J7O5emO7AvgxzvuhYp7fPyNSIVf9kxSC713kyB2z68q\n\tdSIA82CAD8WTAF2rVQiw==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncentric.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ooMc0XveajF2+xlkQQk1v3vTpQrYheD3XpzDKzuMmBU=;\n\tb=EBg8Y6ijLAUjKZhNbUt3Xb0bUbA5+/zcMS48Hk+CURL4v2l00hnJDkALTnk66Pj3oV\n\tsl4uevNuKeyu9hvKl9VnEhIOMSH9EfR0riNkm18V7kcgiBQsr3ULzrVO8L4aCmIO8cG2\n\t+xGGBjNfImdN4IPjpsOj1m4DlWPpNg5lvsiWY=" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ooMc0XveajF2+xlkQQk1v3vTpQrYheD3XpzDKzuMmBU=;\n\tb=DbwsiFXVIsPalN9KbU5PKznvAStcOdrEz9hIGcHWTdBih//WPMckbCM9nQGxA+bcl8\n\thXpOMou0/oQxD46z51ucdiQ1Jgf9r90JN/H+sH9I/+tB0vw8ImxEhZwYAccV/9pmkoMB\n\t2HaiIL7OWIaZkDTjWA3XZDHRuYhOxdYVJaYoV/Bt28IBIZr1MwtAkQoLv1Ddrz340FB2\n\tSUzSmsUJIvCL3225GnZyB1Xx3txyExjRzXfL2Wwnmqa4TXcXU9kXJnbmqEOAtdXRg/YL\n\t4ANetcEuigYt8PJqmXpzE0+PdB4qXhuH0YBa+L8gDcb4Je3/agw0flPhbHwpMIgbP8GF\n\t9I9Q==", "X-Gm-Message-State": "APf1xPB0lh7gxw8VboT+e5dRgkePGzn4mppQzQR+tVCuMfiuVaZdcCer\n\tU7o4Fn7WOXJM9V8Sfz9enDp/Ff4PTR8=", "X-Google-Smtp-Source": "AH8x227ejAsqPvbmcswKAPg335uKZ/bOfc+TPwmB3LHA1bitSVlTBIkIvEBV5JwB2YaCjyvmIrcerQ==", "X-Received": "by 10.80.180.184 with SMTP id w53mr3525672edd.149.1518704208199; \n\tThu, 15 Feb 2018 06:16:48 -0800 (PST)", "From": "Koen Vandeputte <koen.vandeputte@ncentric.com>", "To": "lede-dev@lists.infradead.org", "Date": "Thu, 15 Feb 2018 15:16:03 +0100", "Message-Id": "<1518704164-22198-9-git-send-email-koen.vandeputte@ncentric.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1518704164-22198-1-git-send-email-koen.vandeputte@ncentric.com>", "References": "<1518704164-22198-1-git-send-email-koen.vandeputte@ncentric.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180215_061700_534763_C7EC1B3F ", "X-CRM114-Status": "GOOD ( 13.77 )", "X-Spam-Score": "-2.7 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a00:1450:400c:c09:0:0:0:235 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "Subject": "[LEDE-DEV] [PATCH 8/9] uqmi: use built-in command for data-link\n\tverification", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "leventelist@gmail.com, lynxis@fe80.eu,\n\tKoen Vandeputte <koen.vandeputte@ncentric.com>, john@phrozen.org,\n\tbjorn@mork.no, nbd@nbd.name", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "uqmi contains a command for directly querying the modem if there\nis a valid data connection, so let's use it.\n\nThis avoids the cases were all previous tests are succesful, but the\nactual data link is not up for some reasons, leading to states were we\nthought the link was up when it actually wasn't ..\n\nSigned-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>\n---\n .../network/utils/uqmi/files/lib/netifd/proto/qmi.sh | 20 +++++++++++++++++++-\n 1 file changed, 19 insertions(+), 1 deletion(-)", "diff": "diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\nindex bdab5ee5143b..c3da5ede26b1 100755\n--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\n+++ b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\n@@ -27,7 +27,7 @@ proto_qmi_init_config() {\n \n proto_qmi_setup() {\n \tlocal interface=\"$1\"\n-\tlocal dataformat\n+\tlocal dataformat connstat\n \tlocal device apn auth username password pincode delay modes pdptype profile dhcpv6 autoconnect plmn $PROTO_DEFAULT_OPTIONS\n \tlocal cid_4 pdh_4 cid_6 pdh_6\n \tlocal ip_6 ip_prefix_length gateway_6 dns1_6 dns2_6\n@@ -164,6 +164,15 @@ proto_qmi_setup() {\n \t\t\tproto_notify_error \"$interface\" CALL_FAILED\n \t\t\treturn 1\n \t\tfi\n+\n+ # Check data connection state\n+\t\tconnstat=$(uqmi -s -d \"$device\" --get-data-status)\n+ [ \"$connstat\" == '\"connected\"' ] || {\n+ echo \"No data link!\"\n+ uqmi -s -d \"$device\" --set-client-id wds,\"$cid_4\" --release-client-id wds\n+ proto_notify_error \"$interface\" CALL_FAILED\n+ return 1\n+ }\n \t}\n \n \t[ \"$pdptype\" = \"ipv6\" -o \"$pdptype\" = \"ipv4v6\" ] && {\n@@ -192,6 +201,15 @@ proto_qmi_setup() {\n \t\t\tproto_notify_error \"$interface\" CALL_FAILED\n \t\t\treturn 1\n \t\tfi\n+\n+ # Check data connection state\n+\t\tconnstat=$(uqmi -s -d \"$device\" --get-data-status)\n+ [ \"$connstat\" == '\"connected\"' ] || {\n+ echo \"No data link!\"\n+ uqmi -s -d \"$device\" --set-client-id wds,\"$cid_6\" --release-client-id wds\n+ proto_notify_error \"$interface\" CALL_FAILED\n+ return 1\n+ }\n \t}\n \n \techo \"Setting up $ifname\"\n", "prefixes": [ "LEDE-DEV", "8/9" ] }