Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/873892/?format=api
{ "id": 873892, "url": "http://patchwork.ozlabs.org/api/patches/873892/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/1518704164-22198-7-git-send-email-koen.vandeputte@ncentric.com/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1518704164-22198-7-git-send-email-koen.vandeputte@ncentric.com>", "list_archive_url": null, "date": "2018-02-15T14:16:01", "name": "[LEDE-DEV,6/9] uqmi: use general method for state cleaning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7662bb0f3b583c2e797c5f9ac73814482a860ae0", "submitter": { "id": 69184, "url": "http://patchwork.ozlabs.org/api/people/69184/?format=api", "name": "Koen Vandeputte", "email": "koen.vandeputte@ncentric.com" }, "delegate": { "id": 54613, "url": "http://patchwork.ozlabs.org/api/users/54613/?format=api", "username": "blogic", "first_name": "John", "last_name": "Crispin", "email": "blogic@openwrt.org" }, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/1518704164-22198-7-git-send-email-koen.vandeputte@ncentric.com/mbox/", "series": [ { "id": 28782, "url": "http://patchwork.ozlabs.org/api/series/28782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=28782", "date": "2018-02-15T14:15:55", "name": "uqmi: Add raw-ip mode support for 17.01 branch", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/28782/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/873892/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/873892/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"t76ysOL6\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ncentric.com header.i=@ncentric.com\n\theader.b=\"n25Djsvi\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zhz2T5FVJz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Feb 2018 01:20:33 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux))\n\tid 1emKOj-0001xh-9F; Thu, 15 Feb 2018 14:20:29 +0000", "from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux))\n\tid 1emKLH-00074d-8d\n\tfor lede-dev@lists.infradead.org; Thu, 15 Feb 2018 14:17:01 +0000", "by mail-wm0-x242.google.com with SMTP id v123so1085441wmd.5\n\tfor <lede-dev@lists.infradead.org>;\n\tThu, 15 Feb 2018 06:16:47 -0800 (PST)", "from localhost.localdomain (d515300d8.static.telenet.be.\n\t[81.83.0.216]) by smtp.googlemail.com with ESMTPSA id\n\td6sm3462692edm.52.2018.02.15.06.16.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 15 Feb 2018 06:16:45 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References:\n\tIn-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=xbVgjKPJcM7ibjOoepZiStgqKjF+BCV8ILRbyS10t60=;\n\tb=t76ysOL6jdaQUl\n\tSdRNjzDzAJNAUy0GfJqusMq8/kYLY5cViDMu272EVV6B+Y00vQPHvWWn4sMR8l8UUrJ43o8ZDv7gr\n\t8LZhbm+ePk/nRbPC9IYVe74561ET0C+tHtNwSp61gF/MFOrmB8O/SU+uRiNhZAOVYc9fekcx18DR9\n\tDnAVM+shNWNbGEKcC160RdJ+x8I/0ifSTJ8HdV2IF18UslEs4mm/k2QF5TqC4VnxsZPay69KtxaH1\n\tRo1X1PG+CGBI4utwpVLPPQD1FhffGG0XIF89RF4u/H40+04qoq3hVY2tSUpkiwQQpvnI1C9L6mZDv\n\tmRevFpNW2CnSMu3j7R8w==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncentric.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=3jp9fTY8gz5PDJHg2jTYvOR9St8qHhDRyW5e0L4v56U=;\n\tb=n25Djsvi5b8PiIQ51tfOTZWFCmvgalMJ9Af0wMlcnnYbyg7PFNkcLg3tGfhjX2UGEg\n\tF7+iA/YywKAvmC7JpXXr0qaEJHKe7OpsTMw3h7m4Bkq0wEQsvogCePQOYRcrcaDtToCz\n\tL70qzVrKkUVzWkn0bkMRLqiHQ3QbnK5gyQP18=" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=3jp9fTY8gz5PDJHg2jTYvOR9St8qHhDRyW5e0L4v56U=;\n\tb=n3oECXvMZ+IkJrXErdpwc8F8g7++Mk5x53/71E7st16Jw+jJdjF/HOAY7JkbLAgbBo\n\t+PVmKgTlZz4GuLrQuFGR6EZJdg5u52T5fOa0rc46wAbTn3LrGRceuruys0GXtrriaqAz\n\tXgQnpDq/mFiyyd+rvn6v2r6EGj30dQSDVrpBwNUpdoeEa4oZHQ6h2aVBJbx2GEUsVmLX\n\t0l367Iz8/6AgR3nmxbBOIdMhSHoU/zavwjn3xQdokMlVtNgTwUOMdi4SINmA7tXl44bN\n\tyZ1DPqexqyF4NnRsUX/EO2O7IJM/hSvNysH/hOaIxOE6gw1KNoa8TZJFpuJuR1rsZwzL\n\tt3PA==", "X-Gm-Message-State": "APf1xPA80DwVkiB0UIICc8CJra3zGqPTkI/cUANuJRR1guy/StNUcPUH\n\tXcsucIcTOr22yjkeAeQBW4JMP+lTvRM=", "X-Google-Smtp-Source": "AH8x227ZPYlWY6ba/VGBF+/onGWRfru2pbR+qBF1EgJQ5PNn8ABgrP/jrYRSiXDYrEuqqR4W2C0VSg==", "X-Received": "by 10.80.240.2 with SMTP id r2mr3596117edl.91.1518704206113;\n\tThu, 15 Feb 2018 06:16:46 -0800 (PST)", "From": "Koen Vandeputte <koen.vandeputte@ncentric.com>", "To": "lede-dev@lists.infradead.org", "Date": "Thu, 15 Feb 2018 15:16:01 +0100", "Message-Id": "<1518704164-22198-7-git-send-email-koen.vandeputte@ncentric.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1518704164-22198-1-git-send-email-koen.vandeputte@ncentric.com>", "References": "<1518704164-22198-1-git-send-email-koen.vandeputte@ncentric.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180215_061655_426877_D64FE1C2 ", "X-CRM114-Status": "UNSURE ( 9.61 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-2.0 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "Subject": "[LEDE-DEV] [PATCH 6/9] uqmi: use general method for state cleaning", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "leventelist@gmail.com, lynxis@fe80.eu,\n\tKoen Vandeputte <koen.vandeputte@ncentric.com>, john@phrozen.org,\n\tbjorn@mork.no, nbd@nbd.name", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Debugging shows that using the general method properly cleans on each\nrun, while the method specifying the client-ID shows \"No effect\"\neven while in connected state.\n\nFixes several connectivity issues seen on specific modems.\n\nSigned-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>\n---\n package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\nindex 1619c2b35eb9..eba0922e57de 100755\n--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\n+++ b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\n@@ -97,6 +97,10 @@ proto_qmi_setup() {\n \t\t}\n \t}\n \n+\t# Cleanup current state if any\n+\tuqmi -s -d \"$device\" --stop-network 0xffffffff --autoconnect\n+\n+\t# Set IP format\n \tuqmi -s -d \"$device\" --set-data-format 802.3\n \tuqmi -s -d \"$device\" --wda-set-data-format 802.3\n \tdataformat=\"$(uqmi -s -d \"$device\" --wda-get-data-format)\"\n@@ -144,11 +148,6 @@ proto_qmi_setup() {\n \n \t\tuqmi -s -d \"$device\" --set-client-id wds,\"$cid_4\" --set-ip-family ipv4 > /dev/null\n \n-\t\t# try to clear previous autoconnect state\n-\t\tuqmi -s -d \"$device\" --set-client-id wds,\"$cid_4\" \\\n-\t\t\t--stop-network 0xffffffff \\\n-\t\t\t--autoconnect > /dev/null\n-\n \t\tpdh_4=$(uqmi -s -d \"$device\" --set-client-id wds,\"$cid_4\" \\\n \t\t\t--start-network \\\n \t\t\t${apn:+--apn $apn} \\\n@@ -175,11 +174,6 @@ proto_qmi_setup() {\n \n \t\tuqmi -s -d \"$device\" --set-client-id wds,\"$cid_6\" --set-ip-family ipv6 > /dev/null\n \n-\t\t# try to clear previous autoconnect state\n-\t\tuqmi -s -d \"$device\" --set-client-id wds,\"$cid_6\" \\\n-\t\t\t--stop-network 0xffffffff \\\n-\t\t\t--autoconnect > /dev/null\n-\n \t\tpdh_6=$(uqmi -s -d \"$device\" --set-client-id wds,\"$cid_6\" \\\n \t\t\t--start-network \\\n \t\t\t${apn:+--apn $apn} \\\n", "prefixes": [ "LEDE-DEV", "6/9" ] }