Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/873889/?format=api
{ "id": 873889, "url": "http://patchwork.ozlabs.org/api/patches/873889/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/1518704164-22198-8-git-send-email-koen.vandeputte@ncentric.com/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1518704164-22198-8-git-send-email-koen.vandeputte@ncentric.com>", "list_archive_url": null, "date": "2018-02-15T14:16:02", "name": "[LEDE-DEV,7/9] uqmi: use correct value for connection checking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ba49c1181cddcc440450b3762076f14dcf0c51ff", "submitter": { "id": 69184, "url": "http://patchwork.ozlabs.org/api/people/69184/?format=api", "name": "Koen Vandeputte", "email": "koen.vandeputte@ncentric.com" }, "delegate": { "id": 54613, "url": "http://patchwork.ozlabs.org/api/users/54613/?format=api", "username": "blogic", "first_name": "John", "last_name": "Crispin", "email": "blogic@openwrt.org" }, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/1518704164-22198-8-git-send-email-koen.vandeputte@ncentric.com/mbox/", "series": [ { "id": 28782, "url": "http://patchwork.ozlabs.org/api/series/28782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=28782", "date": "2018-02-15T14:15:55", "name": "uqmi: Add raw-ip mode support for 17.01 branch", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/28782/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/873889/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/873889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"uVixI71O\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ncentric.com header.i=@ncentric.com\n\theader.b=\"Da+r3qMV\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zhz1C5sH2z9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Feb 2018 01:19:27 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux))\n\tid 1emKNd-0000N8-EZ; Thu, 15 Feb 2018 14:19:21 +0000", "from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232])\n\tby bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux))\n\tid 1emKLI-00075B-9o\n\tfor lede-dev@lists.infradead.org; Thu, 15 Feb 2018 14:17:00 +0000", "by mail-wm0-x232.google.com with SMTP id 141so1107880wme.3\n\tfor <lede-dev@lists.infradead.org>;\n\tThu, 15 Feb 2018 06:16:48 -0800 (PST)", "from localhost.localdomain (d515300d8.static.telenet.be.\n\t[81.83.0.216]) by smtp.googlemail.com with ESMTPSA id\n\td6sm3462692edm.52.2018.02.15.06.16.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 15 Feb 2018 06:16:46 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References:\n\tIn-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=vFNo6BEGpBujzer3X2uTaGunFKaxDaaDYyCWjMNWi3g=;\n\tb=uVixI71OlF2pmk\n\tsBVNV+OVfC1CM2JbXr3rdtw8cMQvQhWfR0/AWUu4pn9yB7B8vDXMq7HgW6zkb+rleyRTFM/hDkthV\n\tm+h1ons4eHVLpJkHm3UhNve9pneyYaYDq23g9wgOWqPTVMoDkAyjT4vTEZG4ues7XdYqzr+/0VxxP\n\tu5V1jSckM3vqNPE8tr7f7O/kBQRCBsIcSdffDjFswSXgeaOMULUoG3lv5rQypD3lAPUydCZXS3JUi\n\tNXtXY+dj7NF4556x0F+s8es58jSpCkhfZB5lrqW7QhZU9rQYrAKspUEjZo07APJN4cLDkKtv8nel5\n\tYKZNPxfMYhokBKZ7OmCg==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncentric.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=rSnQsxXCAiXnU1H8ncpS8lfcNewbvKYngXN7MjNpn8k=;\n\tb=Da+r3qMVTDjNhrs/VppzG+5cOjLtsTnFLE4U3TpZXGgh2zUnHNkLPtqsMMtVH2OLmN\n\tDCq8nGCi1Yy2B0RNOF4gA0GMoRoK6/haI5JuA1hw91tXOfWUszHJR1PqYgbd27SlVTWQ\n\t6Wt45lfsEgNxbjQsLpl/f/b7exnETjhhoaNVA=" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=rSnQsxXCAiXnU1H8ncpS8lfcNewbvKYngXN7MjNpn8k=;\n\tb=Pr9JRcVP4H4HW01/d9fnTc0AHCBR5otikn3tHIphIncXxg5BE+fERXvOUzAeufMSkj\n\tT27dEONRLvKpa9R8x65p98APoHpalbsOUhxSU1y9CjUMHOXlv6ib7aKkY/2wH3t07wlo\n\tfUbmuPayA0El3XTNcrqQ3th2VH1KkUfu1zYminKdotQp8iaYuUplZQ05qNC1NICQItIw\n\tzL1kLslSOCtbDuuuUwGbI/tgx3ynq0ZCSTFLifSBec/qeKBVzuzDKVUhW+72NAQuN7rd\n\t9Zm5LI3/qBqP21qDv3ubW6OMclleBFsJnrghsT5i8iDGJI95jQuLEuapJyrWg1e7vXr2\n\t4ONQ==", "X-Gm-Message-State": "APf1xPAFVAWeFSGM2rKczV33imBrzLyiqIbkx+Ol7e0Tj8fGHRa4anRl\n\t5irsS00dIwTIcg3Lfe3cuIRnToPANw0=", "X-Google-Smtp-Source": "AH8x227IxdOMuQhvN1z0R5s8/vuRXYeZVMuFWted5C08iWuhoparUZcLdt708ZpPrkWmqOQmtesHmA==", "X-Received": "by 10.80.183.173 with SMTP id h42mr3548674ede.287.1518704207233; \n\tThu, 15 Feb 2018 06:16:47 -0800 (PST)", "From": "Koen Vandeputte <koen.vandeputte@ncentric.com>", "To": "lede-dev@lists.infradead.org", "Date": "Thu, 15 Feb 2018 15:16:02 +0100", "Message-Id": "<1518704164-22198-8-git-send-email-koen.vandeputte@ncentric.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1518704164-22198-1-git-send-email-koen.vandeputte@ncentric.com>", "References": "<1518704164-22198-1-git-send-email-koen.vandeputte@ncentric.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20180215_061656_440856_1FB5993C ", "X-CRM114-Status": "GOOD ( 11.17 )", "X-Spam-Score": "-2.7 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a00:1450:400c:c09:0:0:0:232 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "Subject": "[LEDE-DEV] [PATCH 7/9] uqmi: use correct value for connection\n\tchecking", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "leventelist@gmail.com, lynxis@fe80.eu,\n\tKoen Vandeputte <koen.vandeputte@ncentric.com>, john@phrozen.org,\n\tbjorn@mork.no, nbd@nbd.name", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Originally, the implementation only checked if uqmi command\nexecution succeeded properly without actually checking it's returned data.\n\nThis lead to a pass, even when the returned data was indicating an error.\n\nRework the verification to actually check the returned data,\nwhich can only be correct if the uqmi command itself also executed correctly.\n\nOn command execution success, value \"pdh_\" is a pure numeric value.\n\nSigned-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>\n---\n package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\nindex eba0922e57de..bdab5ee5143b 100755\n--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\n+++ b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh\n@@ -156,12 +156,14 @@ proto_qmi_setup() {\n \t\t\t${username:+--username $username} \\\n \t\t\t${password:+--password $password} \\\n \t\t\t${autoconnect:+--autoconnect})\n-\t\t[ $? -ne 0 ] && {\n+\n+ # pdh_4 is a numeric value on success\n+\t\tif ! [ \"$pdh_4\" -eq \"$pdh_4\" ] 2> /dev/null; then\n \t\t\techo \"Unable to connect IPv4\"\n \t\t\tuqmi -s -d \"$device\" --set-client-id wds,\"$cid_4\" --release-client-id wds\n \t\t\tproto_notify_error \"$interface\" CALL_FAILED\n \t\t\treturn 1\n-\t\t}\n+\t\tfi\n \t}\n \n \t[ \"$pdptype\" = \"ipv6\" -o \"$pdptype\" = \"ipv4v6\" ] && {\n@@ -182,12 +184,14 @@ proto_qmi_setup() {\n \t\t\t${username:+--username $username} \\\n \t\t\t${password:+--password $password} \\\n \t\t\t${autoconnect:+--autoconnect})\n-\t\t[ $? -ne 0 ] && {\n+\n+ # pdh_6 is a numeric value on success\n+\t\tif ! [ \"$pdh_6\" -eq \"$pdh_6\" ] 2> /dev/null; then\n \t\t\techo \"Unable to connect IPv6\"\n \t\t\tuqmi -s -d \"$device\" --set-client-id wds,\"$cid_6\" --release-client-id wds\n \t\t\tproto_notify_error \"$interface\" CALL_FAILED\n \t\t\treturn 1\n-\t\t}\n+\t\tfi\n \t}\n \n \techo \"Setting up $ifname\"\n", "prefixes": [ "LEDE-DEV", "7/9" ] }