Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/870761/?format=api
{ "id": 870761, "url": "http://patchwork.ozlabs.org/api/patches/870761/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180208064714.6042-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180208064714.6042-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2018-02-08T06:47:12", "name": "[net-queue,1/3] Partial revert \"e1000e: Avoid receiver overrun interrupt bursts\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "230c2e7b42121f37f421c0162f3ea23755286731", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180208064714.6042-1-bpoirier@suse.com/mbox/", "series": [ { "id": 27517, "url": "http://patchwork.ozlabs.org/api/series/27517/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=27517", "date": "2018-02-08T06:47:12", "name": "[net-queue,1/3] Partial revert \"e1000e: Avoid receiver overrun interrupt bursts\"", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/27517/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/870761/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/870761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zcTJw08Ftz9t20\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Feb 2018 17:47:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EC4EF2F06D;\n\tThu, 8 Feb 2018 06:47:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wjgh6n1HuQdb; Thu, 8 Feb 2018 06:47:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E4E302A293;\n\tThu, 8 Feb 2018 06:47:24 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B07CD1C0916\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Feb 2018 06:47:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AC5A188A83\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Feb 2018 06:47:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2PlHLVUHpipc for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Feb 2018 06:47:23 +0000 (UTC)", "from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 092F188A54\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Feb 2018 06:47:23 +0000 (UTC)", "from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id DDF84AE22;\n\tThu, 8 Feb 2018 06:47:20 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "by amavisd-new at test-mx.suse.de" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Thu, 8 Feb 2018 15:47:12 +0900", "Message-Id": "<20180208064714.6042-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.16.1", "Subject": "[Intel-wired-lan] [PATCH net-queue 1/3] Partial revert \"e1000e:\n\tAvoid receiver overrun interrupt bursts\"", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This partially reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d.\n\nWe keep the fix for the first part of the problem (1) described in the log\nof that commit, that is to read ICR in the other interrupt handler. We\nremove the fix for the second part of the problem (2), Other interrupt\nthrottling.\n\nBursts of \"Other\" interrupts may once again occur during rxo (receive\noverflow) traffic conditions. This is deemed acceptable in the interest of\navoiding unforeseen fallout from changes that are not strictly necessary.\nAs discussed, the e1000e driver should be in \"maintenance mode\".\n\nLink: https://www.spinics.net/lists/netdev/msg480675.html\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++--------------\n 1 file changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 153ad406c65e..3b36efa6228d 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -1915,21 +1915,10 @@ static irqreturn_t e1000_msix_other(int __always_unused irq, void *data)\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n \tstruct e1000_hw *hw = &adapter->hw;\n \tu32 icr;\n-\tbool enable = true;\n \n \ticr = er32(ICR);\n \tew32(ICR, E1000_ICR_OTHER);\n \n-\tif (icr & E1000_ICR_RXO) {\n-\t\tew32(ICR, E1000_ICR_RXO);\n-\t\tenable = false;\n-\t\t/* napi poll will re-enable Other, make sure it runs */\n-\t\tif (napi_schedule_prep(&adapter->napi)) {\n-\t\t\tadapter->total_rx_bytes = 0;\n-\t\t\tadapter->total_rx_packets = 0;\n-\t\t\t__napi_schedule(&adapter->napi);\n-\t\t}\n-\t}\n \tif (icr & E1000_ICR_LSC) {\n \t\tew32(ICR, E1000_ICR_LSC);\n \t\thw->mac.get_link_status = true;\n@@ -1938,7 +1927,7 @@ static irqreturn_t e1000_msix_other(int __always_unused irq, void *data)\n \t\t\tmod_timer(&adapter->watchdog_timer, jiffies + 1);\n \t}\n \n-\tif (enable && !test_bit(__E1000_DOWN, &adapter->state))\n+\tif (!test_bit(__E1000_DOWN, &adapter->state))\n \t\tew32(IMS, E1000_IMS_OTHER);\n \n \treturn IRQ_HANDLED;\n@@ -2708,8 +2697,7 @@ static int e1000e_poll(struct napi_struct *napi, int weight)\n \t\tnapi_complete_done(napi, work_done);\n \t\tif (!test_bit(__E1000_DOWN, &adapter->state)) {\n \t\t\tif (adapter->msix_entries)\n-\t\t\t\tew32(IMS, adapter->rx_ring->ims_val |\n-\t\t\t\t E1000_IMS_OTHER);\n+\t\t\t\tew32(IMS, adapter->rx_ring->ims_val);\n \t\t\telse\n \t\t\t\te1000_irq_enable(adapter);\n \t\t}\n", "prefixes": [ "net-queue", "1/3" ] }