Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/870652/?format=api
{ "id": 870652, "url": "http://patchwork.ozlabs.org/api/patches/870652/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180207222306.30003.49713.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180207222306.30003.49713.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2018-02-07T22:23:06", "name": "ixgbe: fix crash in build_skb Rx code path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bf8364995cc81e2501b41f8de9dff2e0aa34c156", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180207222306.30003.49713.stgit@localhost6.localdomain6/mbox/", "series": [ { "id": 27471, "url": "http://patchwork.ozlabs.org/api/series/27471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=27471", "date": "2018-02-07T22:23:06", "name": "ixgbe: fix crash in build_skb Rx code path", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/27471/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/870652/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/870652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zcFzr1N4Tz9t3J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 8 Feb 2018 09:16:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2ADF18866F;\n\tWed, 7 Feb 2018 22:16:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6NDmAWx+UYwR; Wed, 7 Feb 2018 22:16:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5CEA3883FA;\n\tWed, 7 Feb 2018 22:16:51 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2C7C31C2BA8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Feb 2018 22:16:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2809A8701E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Feb 2018 22:16:50 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id orzP3p4jRDdO for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Feb 2018 22:16:49 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 48EC58700D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Feb 2018 22:16:49 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Feb 2018 14:16:48 -0800", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.100])\n\tby orsmga002.jf.intel.com with ESMTP; 07 Feb 2018 14:16:48 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,473,1511856000\"; d=\"scan'208\";a=\"32946753\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 07 Feb 2018 14:23:06 -0800", "Message-ID": "<20180207222306.30003.49713.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: fix crash in build_skb Rx code path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add check for build_skb enabled ring in ixgbe_dma_sync_frag().\nIn that case &skb_shinfo(skb)->frags[0] may not always be set which\ncan lead to a crash. Instead we derive the page offset from skb->data.\n\nFixes: 42073d91a214\n(\"ixgbe: Have the CPU take ownership of the buffers sooner\")\nReported-by: Ambarish Soman <asoman@redhat.com>\nSuggested-by: Alexander Duyck <alexander.h.duyck@intel.com>\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex b032091..8536942 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1888,6 +1888,14 @@ static void ixgbe_dma_sync_frag(struct ixgbe_ring *rx_ring,\n \t\t\t\t ixgbe_rx_pg_size(rx_ring),\n \t\t\t\t DMA_FROM_DEVICE,\n \t\t\t\t IXGBE_RX_DMA_ATTR);\n+\t} else if (ring_uses_build_skb(rx_ring)) {\n+\t\tunsigned long offset = (unsigned long)(skb->data) & ~PAGE_MASK;\n+\n+\t\tdma_sync_single_range_for_cpu(rx_ring->dev,\n+\t\t\t\t\t IXGBE_CB(skb)->dma,\n+\t\t\t\t\t offset,\n+\t\t\t\t\t skb_headlen(skb),\n+\t\t\t\t\t DMA_FROM_DEVICE);\n \t} else {\n \t\tstruct skb_frag_struct *frag = &skb_shinfo(skb)->frags[0];\n \n", "prefixes": [] }