Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/870043/?format=api
{ "id": 870043, "url": "http://patchwork.ozlabs.org/api/patches/870043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180206194759.26991-1-christophe.jaillet@wanadoo.fr/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180206194759.26991-1-christophe.jaillet@wanadoo.fr>", "list_archive_url": null, "date": "2018-02-06T19:47:59", "name": "igb: Fix a test with HWTSTAMP_TX_ON", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c39042f04b696ad6462cdce619a94e60b266288c", "submitter": { "id": 66309, "url": "http://patchwork.ozlabs.org/api/people/66309/?format=api", "name": "Christophe JAILLET", "email": "christophe.jaillet@wanadoo.fr" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180206194759.26991-1-christophe.jaillet@wanadoo.fr/mbox/", "series": [ { "id": 27241, "url": "http://patchwork.ozlabs.org/api/series/27241/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=27241", "date": "2018-02-06T19:47:59", "name": "igb: Fix a test with HWTSTAMP_TX_ON", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/27241/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/870043/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/870043/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zbZw029msz9s4q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 7 Feb 2018 06:56:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 30EF6881CB;\n\tTue, 6 Feb 2018 19:56:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2Lr4beXDif+Q; Tue, 6 Feb 2018 19:56:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4A6AB86E30;\n\tTue, 6 Feb 2018 19:56:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4FD001C2BAA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Feb 2018 19:56:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 48AF32EA4C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Feb 2018 19:56:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id I90okNmumk1R for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Feb 2018 19:56:10 +0000 (UTC)", "from smtp.smtpout.orange.fr (smtp02.smtpout.orange.fr\n\t[80.12.242.124])\n\tby silver.osuosl.org (Postfix) with ESMTP id BAA8B2DE07\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Feb 2018 19:56:09 +0000 (UTC)", "from linux.numericable.fr ([77.198.79.136]) by mwinf5d56 with ME\n\tid 7XoN1x0072wTeBR03XoNFz; Tue, 06 Feb 2018 20:48:28 +0100" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:07:39 by SQLgrey-1.7.6", "X-ME-Helo": "linux.numericable.fr", "X-ME-Auth": "Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI=", "X-ME-Date": "Tue, 06 Feb 2018 20:48:28 +0100", "X-ME-IP": "77.198.79.136", "From": "Christophe JAILLET <christophe.jaillet@wanadoo.fr>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Tue, 6 Feb 2018 20:47:59 +0100", "Message-Id": "<20180206194759.26991-1-christophe.jaillet@wanadoo.fr>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "X-Antivirus": "Avast (VPS 180206-2, 06/02/2018), Outbound message", "X-Antivirus-Status": "Clean", "Subject": "[Intel-wired-lan] [PATCH] igb: Fix a test with HWTSTAMP_TX_ON", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tChristophe JAILLET <christophe.jaillet@wanadoo.fr>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask.\nThe modified code should behave the same, because HWTSTAMP_TX_ON is 1\nand no other possible values of 'tx_type' would match the test.\nHowever, this is more future-proof, should other values be allowed one day.\n\nSee 'struct hwtstamp_config' in 'include/uapi/linux/net_tstamp.h'\n\nThis fixes a warning reported by smatch:\n igb_xmit_frame_ring() warn: bit shifter 'HWTSTAMP_TX_ON' used for logical '&'\n\nFixes: 26bd4e2db06be (\"igb: protect TX timestamping from API misuse\")\nSigned-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex c208753ff5b7..e945d1f7c7fe 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5727,7 +5727,7 @@ netdev_tx_t igb_xmit_frame_ring(struct sk_buff *skb,\n \tif (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {\n \t\tstruct igb_adapter *adapter = netdev_priv(tx_ring->netdev);\n \n-\t\tif (adapter->tstamp_config.tx_type & HWTSTAMP_TX_ON &&\n+\t\tif (adapter->tstamp_config.tx_type == HWTSTAMP_TX_ON &&\n \t\t !test_and_set_bit_lock(__IGB_PTP_TX_IN_PROGRESS,\n \t\t\t\t\t &adapter->state)) {\n \t\t\tskb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;\n", "prefixes": [] }