Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/869560/?format=api
{ "id": 869560, "url": "http://patchwork.ozlabs.org/api/patches/869560/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180205210337.22102-3-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180205210337.22102-3-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2018-02-05T21:03:32", "name": "[S86,v3,3/8] i40evf: Use an iterator of the same type as the list", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6f5306088772657ea51eafa40c4448258fc08c49", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180205210337.22102-3-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 27070, "url": "http://patchwork.ozlabs.org/api/series/27070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=27070", "date": "2018-02-05T21:03:31", "name": "[S86,v3,1/8] i40e: don't leak memory addresses", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/27070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/869560/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/869560/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zb0SH3gsJz9t2c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 6 Feb 2018 08:03:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 18EE28812A;\n\tMon, 5 Feb 2018 21:03:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XRWTFbp9e2jH; Mon, 5 Feb 2018 21:03:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A85B88813C;\n\tMon, 5 Feb 2018 21:03:38 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 535021C0A7F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 5 Feb 2018 21:03:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4FA3A8812C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 5 Feb 2018 21:03:35 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id b3gtdx1Fxrb3 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 5 Feb 2018 21:03:34 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1A42788113\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 5 Feb 2018 21:03:34 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Feb 2018 13:03:33 -0800", "from jtkirshe-nuc.jf.intel.com ([134.134.177.59])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Feb 2018 13:03:33 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,466,1511856000\"; d=\"scan'208\";a=\"15608850\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 5 Feb 2018 13:03:32 -0800", "Message-Id": "<20180205210337.22102-3-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180205210337.22102-1-jeffrey.t.kirsher@intel.com>", "References": "<20180205210337.22102-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [S86 v3 3/8] i40evf: Use an iterator of the same\n\ttype as the list", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n\nWhen iterating through the linked list of vlan filters, make the\niterator the same type as that of the linked list.\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 69d7e457e593..fcc49e1177d7 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1027,6 +1027,7 @@ static void i40evf_up_complete(struct i40evf_adapter *adapter)\n void i40evf_down(struct i40evf_adapter *adapter)\n {\n \tstruct net_device *netdev = adapter->netdev;\n+\tstruct i40evf_vlan_filter *vlf;\n \tstruct i40evf_mac_filter *f;\n \tstruct i40evf_cloud_filter *cf;\n \n@@ -1046,8 +1047,8 @@ void i40evf_down(struct i40evf_adapter *adapter)\n \t\tf->remove = true;\n \t}\n \t/* remove all VLAN filters */\n-\tlist_for_each_entry(f, &adapter->vlan_filter_list, list) {\n-\t\tf->remove = true;\n+\tlist_for_each_entry(vlf, &adapter->vlan_filter_list, list) {\n+\t\tvlf->remove = true;\n \t}\n \n \tspin_unlock_bh(&adapter->mac_vlan_list_lock);\n@@ -3857,6 +3858,7 @@ static void i40evf_remove(struct pci_dev *pdev)\n {\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n \tstruct i40evf_adapter *adapter = netdev_priv(netdev);\n+\tstruct i40evf_vlan_filter *vlf, *vlftmp;\n \tstruct i40evf_mac_filter *f, *ftmp;\n \tstruct i40evf_cloud_filter *cf, *cftmp;\n \tstruct i40e_hw *hw = &adapter->hw;\n@@ -3921,9 +3923,10 @@ static void i40evf_remove(struct pci_dev *pdev)\n \t\tlist_del(&f->list);\n \t\tkfree(f);\n \t}\n-\tlist_for_each_entry_safe(f, ftmp, &adapter->vlan_filter_list, list) {\n-\t\tlist_del(&f->list);\n-\t\tkfree(f);\n+\tlist_for_each_entry_safe(vlf, vlftmp, &adapter->vlan_filter_list,\n+\t\t\t\t list) {\n+\t\tlist_del(&vlf->list);\n+\t\tkfree(vlf);\n \t}\n \n \tspin_unlock_bh(&adapter->mac_vlan_list_lock);\n", "prefixes": [ "S86", "v3", "3/8" ] }