Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/867833/?format=api
{ "id": 867833, "url": "http://patchwork.ozlabs.org/api/patches/867833/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180131072627.18305-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180131072627.18305-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2018-01-31T07:26:27", "name": "[net] e1000e: Remove Other from EIAC.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "32659ba82dca47ebe36806afc8a0cb59bb218b42", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180131072627.18305-1-bpoirier@suse.com/mbox/", "series": [ { "id": 26210, "url": "http://patchwork.ozlabs.org/api/series/26210/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=26210", "date": "2018-01-31T07:26:27", "name": "[net] e1000e: Remove Other from EIAC.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/26210/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/867833/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/867833/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zWZZ92wz1z9s72\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 31 Jan 2018 18:26:56 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EBC2E2F335;\n\tWed, 31 Jan 2018 07:26:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nu+wxHbs-jhx; Wed, 31 Jan 2018 07:26:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id EC87A2EDF8;\n\tWed, 31 Jan 2018 07:26:53 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A5F91C21CA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 07:26:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 24769875BB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 07:26:52 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YGFeVdFkgLTG for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 07:26:51 +0000 (UTC)", "from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4248F8754C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 07:26:51 +0000 (UTC)", "from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 1D879AC64;\n\tWed, 31 Jan 2018 07:26:48 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "by amavisd-new at test-mx.suse.de" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Wed, 31 Jan 2018 16:26:27 +0900", "Message-Id": "<20180131072627.18305-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.15.1", "Subject": "[Intel-wired-lan] [PATCH net] e1000e: Remove Other from EIAC.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "It was reported that emulated e1000e devices in vmware esxi 6.5 Build\n7526125 do not link up after commit 4aea7a5c5e94 (\"e1000e: Avoid receiver\noverrun interrupt bursts\", v4.15-rc1). Some tracing shows that after\ne1000e_trigger_lsc() is called, ICR reads out as 0x0 in e1000_msix_other()\non emulated e1000e devices. In comparison, on real e1000e 82574 hardware,\nicr=0x80000004 (_INT_ASSERTED | _LSC) in the same situation.\n\nSome experimentation showed that this flaw in vmware e1000e emulation can\nbe worked around by not setting Other in EIAC. This is how it was before\n16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\", v4.5-rc1).\n\nFixes: 4aea7a5c5e94 (\"e1000e: Avoid receiver overrun interrupt bursts\")\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 9f18d39bdc8f..625a4c9a86a4 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -1918,6 +1918,8 @@ static irqreturn_t e1000_msix_other(int __always_unused irq, void *data)\n \tbool enable = true;\n \n \ticr = er32(ICR);\n+\tew32(ICR, E1000_ICR_OTHER);\n+\n \tif (icr & E1000_ICR_RXO) {\n \t\tew32(ICR, E1000_ICR_RXO);\n \t\tenable = false;\n@@ -2040,7 +2042,6 @@ static void e1000_configure_msix(struct e1000_adapter *adapter)\n \t\t hw->hw_addr + E1000_EITR_82574(vector));\n \telse\n \t\twritel(1, hw->hw_addr + E1000_EITR_82574(vector));\n-\tadapter->eiac_mask |= E1000_IMS_OTHER;\n \n \t/* Cause Tx interrupts on every write back */\n \tivar |= BIT(31);\n@@ -2265,7 +2266,7 @@ static void e1000_irq_enable(struct e1000_adapter *adapter)\n \n \tif (adapter->msix_entries) {\n \t\tew32(EIAC_82574, adapter->eiac_mask & E1000_EIAC_MASK_82574);\n-\t\tew32(IMS, adapter->eiac_mask | E1000_IMS_LSC);\n+\t\tew32(IMS, adapter->eiac_mask | E1000_IMS_OTHER | E1000_IMS_LSC);\n \t} else if (hw->mac.type >= e1000_pch_lpt) {\n \t\tew32(IMS, IMS_ENABLE_MASK | E1000_IMS_ECCER);\n \t} else {\n", "prefixes": [ "net" ] }