Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/867753/?format=api
{ "id": 867753, "url": "http://patchwork.ozlabs.org/api/patches/867753/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180131005127.19264.83738.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180131005127.19264.83738.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2018-01-31T00:51:27", "name": "[4/9] ixgbevf: setup queue counts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b3beb6c565644d58c27e25fe60b3aeab2a3cd3bc", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180131005127.19264.83738.stgit@localhost6.localdomain6/mbox/", "series": [ { "id": 26180, "url": "http://patchwork.ozlabs.org/api/series/26180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=26180", "date": "2018-01-31T00:51:07", "name": "ixgbevf: build_skb support and related changes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/26180/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/867753/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/867753/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zWPg23vkfz9ryQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 31 Jan 2018 11:45:34 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DD54287DD9;\n\tWed, 31 Jan 2018 00:45:32 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KMqEupmKZcAA; Wed, 31 Jan 2018 00:45:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 70A1E87DAC;\n\tWed, 31 Jan 2018 00:45:31 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4B51A1C4377\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 00:45:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 46FF788E8D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 00:45:30 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LdSPIkkV1Pbt for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 00:45:29 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 8A95188B60\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 31 Jan 2018 00:45:29 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Jan 2018 16:45:29 -0800", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.100])\n\tby fmsmga001.fm.intel.com with ESMTP; 30 Jan 2018 16:45:28 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,437,1511856000\"; d=\"scan'208\";a=\"26789967\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 30 Jan 2018 16:51:27 -0800", "Message-ID": "<20180131005127.19264.83738.stgit@localhost6.localdomain6>", "In-Reply-To": "<20180131005015.19264.44085.stgit@localhost6.localdomain6>", "References": "<20180131005015.19264.44085.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 4/9] ixgbevf: setup queue counts", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add calls for netif_set_real_num_t/rx_queues() in ixgbevf_open().\nMake sure that calls to ixgbevf_open() are rtnl protected and improve\nthe error handling when setting up multiple queues.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 44 ++++++++++++++-------\n 1 file changed, 29 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex f8e1b1c..cb9d00a 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -3119,9 +3119,14 @@ static int ixgbevf_setup_all_tx_resources(struct ixgbevf_adapter *adapter)\n \t\tif (!err)\n \t\t\tcontinue;\n \t\thw_dbg(&adapter->hw, \"Allocation for Tx Queue %u failed\\n\", i);\n-\t\tbreak;\n+\t\tgoto err_setup_tx;\n \t}\n \n+\treturn 0;\n+err_setup_tx:\n+\t/* rewind the index freeing the rings as we go */\n+\twhile (i--)\n+\t\tixgbevf_free_tx_resources(adapter->tx_ring[i]);\n \treturn err;\n }\n \n@@ -3179,8 +3184,14 @@ static int ixgbevf_setup_all_rx_resources(struct ixgbevf_adapter *adapter)\n \t\tif (!err)\n \t\t\tcontinue;\n \t\thw_dbg(&adapter->hw, \"Allocation for Rx Queue %u failed\\n\", i);\n-\t\tbreak;\n+\t\tgoto err_setup_rx;\n \t}\n+\n+\treturn 0;\n+err_setup_rx:\n+\t/* rewind the index freeing the rings as we go */\n+\twhile (i--)\n+\t\tixgbevf_free_rx_resources(adapter->rx_ring[i]);\n \treturn err;\n }\n \n@@ -3285,18 +3296,27 @@ int ixgbevf_open(struct net_device *netdev)\n \tif (err)\n \t\tgoto err_req_irq;\n \n+\t/* Notify the stack of the actual queue counts. */\n+\terr = netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);\n+\tif (err)\n+\t\tgoto err_set_queues;\n+\n+\terr = netif_set_real_num_rx_queues(netdev, adapter->num_rx_queues);\n+\tif (err)\n+\t\tgoto err_set_queues;\n+\n \tixgbevf_up_complete(adapter);\n \n \treturn 0;\n \n+err_set_queues:\n+\tixgbevf_free_irq(adapter);\n err_req_irq:\n-\tixgbevf_down(adapter);\n-err_setup_rx:\n \tixgbevf_free_all_rx_resources(adapter);\n-err_setup_tx:\n+err_setup_rx:\n \tixgbevf_free_all_tx_resources(adapter);\n+err_setup_tx:\n \tixgbevf_reset(adapter);\n-\n err_setup_reset:\n \n \treturn err;\n@@ -3948,17 +3968,11 @@ static int ixgbevf_resume(struct pci_dev *pdev)\n \n \trtnl_lock();\n \terr = ixgbevf_init_interrupt_scheme(adapter);\n+\tif (!err && netif_running(netdev))\n+\t\terr = ixgbevf_open(netdev);\n \trtnl_unlock();\n-\tif (err) {\n-\t\tdev_err(&pdev->dev, \"Cannot initialize interrupts\\n\");\n+\tif (err)\n \t\treturn err;\n-\t}\n-\n-\tif (netif_running(netdev)) {\n-\t\terr = ixgbevf_open(netdev);\n-\t\tif (err)\n-\t\t\treturn err;\n-\t}\n \n \tnetif_device_attach(netdev);\n \n", "prefixes": [ "4/9" ] }