Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/867359/?format=api
{ "id": 867359, "url": "http://patchwork.ozlabs.org/api/patches/867359/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180129235748.21304-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180129235748.21304-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2018-01-29T23:57:48", "name": "ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b2ea9c768781ff5eb8dd75cc13e3c3a1b5999de7", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180129235748.21304-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 25986, "url": "http://patchwork.ozlabs.org/api/series/25986/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=25986", "date": "2018-01-29T23:57:48", "name": "ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/25986/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/867359/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/867359/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zVmfb1ZCtz9s72\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 30 Jan 2018 10:57:58 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DAC198835C;\n\tMon, 29 Jan 2018 23:57:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rirrWVIlMXA8; Mon, 29 Jan 2018 23:57:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A0E9B882F8;\n\tMon, 29 Jan 2018 23:57:55 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 833D41C0ADE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jan 2018 23:57:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7F352882F8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jan 2018 23:57:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id F-PAXELHAA37 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jan 2018 23:57:53 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id E0AAF81CB2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jan 2018 23:57:52 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jan 2018 15:57:52 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.177.161])\n\tby fmsmga007.fm.intel.com with ESMTP; 29 Jan 2018 15:57:50 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,433,1511856000\"; d=\"scan'208\";a=\"13902900\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 29 Jan 2018 15:57:48 -0800", "Message-Id": "<20180129235748.21304-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.15.1.478.ga1e07cd25f8b", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: prevent ptp_rx_hang from running\n\twhen in FILTER_ALL mode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On hardware which supports timestamping all packets, the timestamps are\nrecorded in the packet buffer, and the driver no longer uses or reads\nthe registers. This makes the logic for checking and clearing Rx\ntimestmap hangs meaningless.\n\nIf we run the ixgbe_ptp_rx_hang() function in this case, then the driver\nwill continuously spam the log output with \"Clearing Rx timestamp hang\".\nThese messages are spurious, and confusing to end users.\n\nThe original code in commit a9763f3cb54c (\"ixgbe: Update PTP to support\nX550EM_x devices\", 2015-12-03) did have a flag PTP_RX_TIMESTAMP_IN_REGISTER\nwhich was intended to be used to avoid the Rx timestamp hang check,\nhowever it did not actually check the flag before calling the function.\n\nDo so now in order to stop the checks and prevent the spurious log\nmessages.\n\nFixes: a9763f3cb54c (\"ixgbe: Update PTP to support X550EM_x devices\", 2015-12-03)\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\nApparently this fix was not squashed into Mark's upstreaming effort for\nthe PTP updates for X550. Here it is now.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 0da5aa2c8aba..b032091022a8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7703,7 +7703,8 @@ static void ixgbe_service_task(struct work_struct *work)\n \n \tif (test_bit(__IXGBE_PTP_RUNNING, &adapter->state)) {\n \t\tixgbe_ptp_overflow_check(adapter);\n-\t\tixgbe_ptp_rx_hang(adapter);\n+\t\tif (adapter->flags & IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER)\n+\t\t\tixgbe_ptp_rx_hang(adapter);\n \t\tixgbe_ptp_tx_hang(adapter);\n \t}\n \n", "prefixes": [] }