Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/866458/?format=api
{ "id": 866458, "url": "http://patchwork.ozlabs.org/api/patches/866458/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180126102404.GA26578@poseidon.lin.mbt.kalray.eu/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180126102404.GA26578@poseidon.lin.mbt.kalray.eu>", "list_archive_url": null, "date": "2018-01-26T10:24:12", "name": "e1000e: allocate ring descriptors with dma_zalloc_coherent", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "95fa649cfe5b3e886f71d9a78e1d9bb0e0215220", "submitter": { "id": 73318, "url": "http://patchwork.ozlabs.org/api/people/73318/?format=api", "name": "Pierre-Yves Kerbrat", "email": "pkerbrat@kalray.eu" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180126102404.GA26578@poseidon.lin.mbt.kalray.eu/mbox/", "series": [ { "id": 25607, "url": "http://patchwork.ozlabs.org/api/series/25607/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=25607", "date": "2018-01-26T10:24:12", "name": "e1000e: allocate ring descriptors with dma_zalloc_coherent", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/25607/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/866458/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/866458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=kalray.eu header.i=@kalray.eu\n\theader.b=\"Nobf0zJu\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zSkkb6tYKz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Jan 2018 03:24:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0623A8A43F;\n\tFri, 26 Jan 2018 16:24:22 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id T+fI253FGwe8; Fri, 26 Jan 2018 16:24:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9C2A38A453;\n\tFri, 26 Jan 2018 16:24:19 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 462B41C2630\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Jan 2018 10:29:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 41F42835E3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Jan 2018 10:29:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0VnNkjV2-jKJ for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Jan 2018 10:29:48 +0000 (UTC)", "from zimbra1.kalray.eu (zimbra1.kalray.eu [92.103.151.219])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id AF99083359\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Jan 2018 10:29:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby zimbra1.kalray.eu (Postfix) with ESMTP id 0DDEA28009B;\n\tFri, 26 Jan 2018 11:24:17 +0100 (CET)", "from zimbra1.kalray.eu ([127.0.0.1])\n\tby localhost (zimbra1.kalray.eu [127.0.0.1]) (amavisd-new, port 10032)\n\twith ESMTP id Y1L9_-iC-K5A; Fri, 26 Jan 2018 11:24:16 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n\tby zimbra1.kalray.eu (Postfix) with ESMTP id 38708280099;\n\tFri, 26 Jan 2018 11:24:16 +0100 (CET)", "from zimbra1.kalray.eu ([127.0.0.1])\n\tby localhost (zimbra1.kalray.eu [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id ZllTC-B07Tb6; Fri, 26 Jan 2018 11:24:16 +0100 (CET)", "from poseidon.lin.mbt.kalray.eu (unknown [192.168.37.136])\n\tby zimbra1.kalray.eu (Postfix) with ESMTPSA id 1881E280096;\n\tFri, 26 Jan 2018 11:24:16 +0100 (CET)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "amavisd-new at kalray.eu" ], "X-Greylist": "delayed 00:05:28 by SQLgrey-1.7.6", "DKIM-Filter": "OpenDKIM Filter v2.9.2 zimbra1.kalray.eu 38708280099", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalray.eu;\n\ts=32AE1B44-9502-11E5-BA35-3734643DEF29; t=1516962256;\n\tbh=GYU+vhmmVVgIYjySS6Kel4QjjEFYRZMkumQN85eY4g8=;\n\th=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type;\n\tb=Nobf0zJuvn/QBMUDHfGccHQJ/1cSdnKtd/1KgOf7KLnle9Rz5ElQHMJfpGJj5R8zm\n\t0lajglLTN/TXweOzYiZY0qJt5iLEUx/vKNE4sp+x/3iRa1WnVy9ZfftwXgLBroFMW9\n\ti1J8e5S+1t0366Le9LyRXej95/rq8FywBncszG9M=", "Date": "Fri, 26 Jan 2018 11:24:12 +0100", "From": "Pierre-Yves Kerbrat <pkerbrat@kalray.eu>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org", "Message-ID": "<20180126102404.GA26578@poseidon.lin.mbt.kalray.eu>", "MIME-Version": "1.0", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.21 (2010-09-15)", "X-Mailman-Approved-At": "Fri, 26 Jan 2018 16:24:17 +0000", "Subject": "[Intel-wired-lan] [PATCH] e1000e: allocate ring descriptors with\n\tdma_zalloc_coherent", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Marius Gligor <mgligor@kalray.eu>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Descriptor rings were not initialized at zero when allocated\nWhen area contained garbage data, it caused skb_over_panic in\ne1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set)\n\nThis patch makes use of dma_zalloc_coherent to make sure the\nring is memset at 0 to prevent the area from containing garbage.\n\nFollowing is the signature of the panic:\nIODDR0@0.0: skbuff: skb_over_panic: text:80407b20 len:64010 put:64010 head:ab46d800 data:ab46d842 tail:0xab47d24c end:0xab46df40 dev:eth0\nIODDR0@0.0: BUG: failure at net/core/skbuff.c:105/skb_panic()!\nIODDR0@0.0: Kernel panic - not syncing: BUG!\nIODDR0@0.0:\nIODDR0@0.0: Process swapper/0 (pid: 0, threadinfo=81728000, task=8173cc00 ,cpu: 0)\nIODDR0@0.0: SP = <815a1c0c>\nIODDR0@0.0: Stack: 00000001\nIODDR0@0.0: b2d89800 815e33ac\nIODDR0@0.0: ea73c040 00000001\nIODDR0@0.0: 60040003 0000fa0a\nIODDR0@0.0: 00000002\nIODDR0@0.0:\nIODDR0@0.0: 804540c0 815a1c70\nIODDR0@0.0: b2744000 602ac070\nIODDR0@0.0: 815a1c44 b2d89800\nIODDR0@0.0: 8173cc00 815a1c08\nIODDR0@0.0:\nIODDR0@0.0: 00000006\nIODDR0@0.0: 815a1b50 00000000\nIODDR0@0.0: 80079434 00000001\nIODDR0@0.0: ab46df40 b2744000\nIODDR0@0.0: b2d89800\nIODDR0@0.0:\nIODDR0@0.0: 0000fa0a 8045745c\nIODDR0@0.0: 815a1c88 0000fa0a\nIODDR0@0.0: 80407b20 b2789f80\nIODDR0@0.0: 00000005 80407b20\nIODDR0@0.0:\nIODDR0@0.0:\nIODDR0@0.0: Call Trace:\nIODDR0@0.0: [<804540bc>] skb_panic+0xa4/0xa8\nIODDR0@0.0: [<80079430>] console_unlock+0x2f8/0x6d0\nIODDR0@0.0: [<80457458>] skb_put+0xa0/0xc0\nIODDR0@0.0: [<80407b1c>] e1000_clean_rx_irq+0x2dc/0x3e8\nIODDR0@0.0: [<80407b1c>] e1000_clean_rx_irq+0x2dc/0x3e8\nIODDR0@0.0: [<804079c8>] e1000_clean_rx_irq+0x188/0x3e8\nIODDR0@0.0: [<80407b1c>] e1000_clean_rx_irq+0x2dc/0x3e8\nIODDR0@0.0: [<80468b48>] __dev_kfree_skb_any+0x88/0xa8\nIODDR0@0.0: [<804101ac>] e1000e_poll+0x94/0x288\nIODDR0@0.0: [<8046e9d4>] net_rx_action+0x19c/0x4e8\nIODDR0@0.0: ...\nIODDR0@0.0: Maximum depth to print reached. Use kstack=<maximum_depth_to_print> To specify a custom value (where 0 means to display the full backtrace)\nIODDR0@0.0: ---[ end Kernel panic - not syncing: BUG!\n\nSigned-off-by: Pierre-Yves Kerbrat <pkerbrat@kalray.eu>\nSigned-off-by: Marius Gligor <mgligor@kalray.eu>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 1298b69..26121ed 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -2333,7 +2333,7 @@ static int e1000_alloc_ring_dma(struct e1000_adapter *adapter,\n {\n \tstruct pci_dev *pdev = adapter->pdev;\n \n-\tring->desc = dma_alloc_coherent(&pdev->dev, ring->size, &ring->dma,\n+\tring->desc = dma_zalloc_coherent(&pdev->dev, ring->size, &ring->dma,\n \t\t\t\t\tGFP_KERNEL);\n \tif (!ring->desc)\n \t\treturn -ENOMEM;\n", "prefixes": [] }