Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/862613/?format=api
{ "id": 862613, "url": "http://patchwork.ozlabs.org/api/patches/862613/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180117214910.56422.26379.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180117214910.56422.26379.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2018-01-17T21:49:10", "name": "[net-queue] e1000e: Workaround for VMware emulated 82574 setting of LSC", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "c32453ca94f2c14d2cbe9b572cc673cfe020b105", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180117214910.56422.26379.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 24008, "url": "http://patchwork.ozlabs.org/api/series/24008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=24008", "date": "2018-01-17T21:49:10", "name": "[net-queue] e1000e: Workaround for VMware emulated 82574 setting of LSC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/24008/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/862613/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/862613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zMLTg0pD2z9t5Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 18 Jan 2018 08:54:30 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DB4F386F1D;\n\tWed, 17 Jan 2018 21:54:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g8ZTXjWlze50; Wed, 17 Jan 2018 21:54:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DC63486423;\n\tWed, 17 Jan 2018 21:54:26 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3758D1C219A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Jan 2018 21:54:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0504B893DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Jan 2018 21:54:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jdWGixiL5NYL for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Jan 2018 21:54:11 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C051789269\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Jan 2018 21:54:11 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Jan 2018 13:54:11 -0800", "from ahduyck-green-test.jf.intel.com ([10.166.244.140])\n\tby orsmga006.jf.intel.com with ESMTP; 17 Jan 2018 13:54:11 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,374,1511856000\"; d=\"scan'208\";a=\"11394852\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 17 Jan 2018 16:49:10 -0500", "Message-ID": "<20180117214910.56422.26379.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-queue PATCH] e1000e: Workaround for VMware\n\temulated 82574 setting of LSC", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch is meant to address the fact that after the patch for addressing\nreceive overrun interrupt bursts VMware emulated versions of the 82574 were\nno longer able to bring up link. I believe this is due to the fact that the\nemulation was based more on the driver implementation then on the actual\nhardware behavior.\n\nIn order to resolve this we will need to modify the fix so that we only\nforce the LSC checks when the receiver overrun bit is set in the ICR\nregister. By doing this we can maintain the legacy behavior needed to keep\nthe emulated interfaces going while also addressing the issues with the RXO\ninterrupt cause seen with the physical hardware.\n\nFixes: 4aea7a5c5e94 (\"e1000e: Avoid receiver overrun interrupt bursts\")\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 1298b69..74d5352 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -1927,8 +1927,15 @@ static irqreturn_t e1000_msix_other(int __always_unused irq, void *data)\n \t\t\tadapter->total_rx_packets = 0;\n \t\t\t__napi_schedule(&adapter->napi);\n \t\t}\n-\t}\n-\tif (icr & E1000_ICR_LSC) {\n+\t\tif (icr & E1000_ICR_LSC)\n+\t\t\tgoto update_link;\n+\t} else {\n+\t\t/* We assume if the RXO bit is not set that this is a\n+\t\t * link status change event. This is needed due to emulated\n+\t\t * versions of the device that may not correctly populate\n+\t\t * the LSC bit.\n+\t\t */\n+update_link:\n \t\tew32(ICR, E1000_ICR_LSC);\n \t\thw->mac.get_link_status = true;\n \t\t/* guard against interrupt when we're going down */\n", "prefixes": [ "net-queue" ] }