Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/860064/?format=api
{ "id": 860064, "url": "http://patchwork.ozlabs.org/api/patches/860064/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180112171310.27973-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180112171310.27973-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-01-12T17:13:10", "name": "[next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "80ab0d9c6dd237b49bf196844a812c266d9c61d3", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180112171310.27973-1-colin.king@canonical.com/mbox/", "series": [ { "id": 23011, "url": "http://patchwork.ozlabs.org/api/series/23011/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=23011", "date": "2018-01-12T17:13:10", "name": "[next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/23011/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/860064/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/860064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zJ8TV2Wpnz9sQm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 13 Jan 2018 04:13:17 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 59E2888CC7;\n\tFri, 12 Jan 2018 17:13:16 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id L6R3T5lnIZd4; Fri, 12 Jan 2018 17:13:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C297288C59;\n\tFri, 12 Jan 2018 17:13:14 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 107541C0190\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Jan 2018 17:13:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0BBC288C59\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Jan 2018 17:13:14 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QRKMwWtshzPP for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Jan 2018 17:13:13 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 71F3086B09\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Jan 2018 17:13:13 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1ea2tD-00041W-5Z; Fri, 12 Jan 2018 17:13:11 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Fri, 12 Jan 2018 17:13:10 +0000", "Message-Id": "<20180112171310.27973-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.15.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH][next] ixgbe: fix comparison of offset\n\twith zero or NVM_INVALID_PTR", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThe incorrect operator && is being used and will always return false\nas offset can never be two different values at the same time. Fix this\nby using the || operator instead.\n\nDetected by CoverityScan, CID#1463806 (\"Logically dead code\")\n\nFixes: 73834aec7199 (\"ixgbe: extend firmware version support\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 1948e4208fb4..27de8a7f2aeb 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -4084,7 +4084,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,\n \thw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);\n \n \t/* Return is offset to OEM Product Version block is invalid */\n-\tif (offset == 0x0 && offset == NVM_INVALID_PTR)\n+\tif (offset == 0x0 || offset == NVM_INVALID_PTR)\n \t\treturn;\n \n \t/* Read product version block */\n", "prefixes": [ "next" ] }